Re: [PATCH] tar: Fix build error when CONFIG_UNCOMPRESS is not selected

2015-07-01 Thread Denys Vlasenko
Rob Landley has an opposite view: preprocessor #if's are evil. I agree with him that they do tend to obfuscate. On Sun, Jun 28, 2015 at 9:44 AM, Michael Tokarev m...@tls.msk.ru wrote: [Rehashing a thread from 3 years ago] 28.01.2013 11:48, Denys Vlasenko wrote: On Monday 28 January 2013

Re: [PATCH] tar: Fix build error when CONFIG_UNCOMPRESS is not selected

2015-07-01 Thread Michael Tokarev
01.07.2015 19:55, Denys Vlasenko wrote: Rob Landley has an opposite view: preprocessor #if's are evil. I agree with him that they do tend to obfuscate. So what's the solution to this? Blame compilers and force them to act like GCC does? Thanks, /mjt On Sun, Jun 28, 2015 at 9:44 AM,

Re: [PATCH] tar: Fix build error when CONFIG_UNCOMPRESS is not selected

2015-06-28 Thread Michael Tokarev
[Rehashing a thread from 3 years ago] 28.01.2013 11:48, Denys Vlasenko wrote: On Monday 28 January 2013 00:17, Abdoulaye Walsimou GAYE wrote: diff --git a/archival/libarchive/Kbuild.src b/archival/libarchive/Kbuild.src index 58457fc..87e1ab9 100644 --- a/archival/libarchive/Kbuild.src +++

Re: [PATCH] tar: Fix build error when CONFIG_UNCOMPRESS is not selected

2013-01-28 Thread Abdoulaye Walsimou GAYE
On 01/28/2013 08:48 AM, Denys Vlasenko wrote: Hello, See attached .config file and see below the build link error, /home/walsimou/embtoolkit.git/build/packages_build-mipsel-linux-mips32/busybox-1.20.2/archival/tar.c:1065: undefined reference to `unpack_Z_stream'

Re: [PATCH] tar: Fix build error when CONFIG_UNCOMPRESS is not selected

2013-01-27 Thread Denys Vlasenko
On Saturday 26 January 2013 16:24, Abdoulaye Walsimou Gaye wrote: Signed-off-by: Abdoulaye Walsimou Gaye a...@embtoolkit.org --- archival/libarchive/Kbuild.src |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/archival/libarchive/Kbuild.src

Re: [PATCH] tar: Fix build error when CONFIG_UNCOMPRESS is not selected

2013-01-27 Thread Abdoulaye Walsimou GAYE
On 01/27/2013 11:48 PM, Denys Vlasenko wrote: On Saturday 26 January 2013 16:24, Abdoulaye Walsimou Gaye wrote: Signed-off-by: Abdoulaye Walsimou Gaye a...@embtoolkit.org --- archival/libarchive/Kbuild.src |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] tar: Fix build error when CONFIG_UNCOMPRESS is not selected

2013-01-27 Thread Abdoulaye Walsimou GAYE
On 01/28/2013 12:07 AM, Abdoulaye Walsimou GAYE wrote: On 01/27/2013 11:48 PM, Denys Vlasenko wrote: On Saturday 26 January 2013 16:24, Abdoulaye Walsimou Gaye wrote: Signed-off-by: Abdoulaye Walsimou Gaye a...@embtoolkit.org --- archival/libarchive/Kbuild.src |2 +- 1 file changed, 1

Re: [PATCH] tar: Fix build error when CONFIG_UNCOMPRESS is not selected

2013-01-27 Thread Denys Vlasenko
On Monday 28 January 2013 00:17, Abdoulaye Walsimou GAYE wrote: On 01/28/2013 12:07 AM, Abdoulaye Walsimou GAYE wrote: On 01/27/2013 11:48 PM, Denys Vlasenko wrote: On Saturday 26 January 2013 16:24, Abdoulaye Walsimou Gaye wrote: Signed-off-by: Abdoulaye Walsimou Gaye a...@embtoolkit.org

[PATCH] tar: Fix build error when CONFIG_UNCOMPRESS is not selected

2013-01-26 Thread Abdoulaye Walsimou Gaye
Signed-off-by: Abdoulaye Walsimou Gaye a...@embtoolkit.org --- archival/libarchive/Kbuild.src |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/archival/libarchive/Kbuild.src b/archival/libarchive/Kbuild.src index 58457fc..87e1ab9 100644 --- a/archival/libarchive/Kbuild.src