Re: [PATCH] wget: new option FEATURE_WGET_FTP to enable/disable FTP

2021-03-09 Thread Denys Vlasenko
Applied, except for - h->protocol = P_FTP; + h->protocol = NULL; bit (->protocol[0] must exist). On Sun, Jan 17, 2021 at 7:35 PM Sergey Ponomarev wrote: > > Introduce a separate option FTPS_SUPPORTED instead of not obvious > ENABLE_FEATURE_WGET_HTTPS. > > function

Re: [PATCH] wget: new option FEATURE_WGET_FTP to enable/disable FTP

2021-01-17 Thread Sergey Ponomarev
The good idea, I also was confused. The reason is that if you enabled internal tls then FTPS itself ads only dozen bytes. So no practical reason to disable it. The whole FTP disabling gives only additional 1-1.5 kb On Mon, Jan 18, 2021 at 02:04 Kang-Che Sung wrote: > > > On Monday, January

Re: [PATCH] wget: new option FEATURE_WGET_FTP to enable/disable FTP

2021-01-17 Thread Kang-Che Sung
On Monday, January 18, 2021, Sergey Ponomarev wrote: > Introduce a separate option FTPS_SUPPORTED instead of not obvious ENABLE_FEATURE_WGET_HTTPS. > I juat wonder... If you are bothered to add FTP configure option, how about making FTPS separate from HTTPS as well?

[PATCH] wget: new option FEATURE_WGET_FTP to enable/disable FTP

2021-01-17 Thread Sergey Ponomarev
Introduce a separate option FTPS_SUPPORTED instead of not obvious ENABLE_FEATURE_WGET_HTTPS. function old new delta P_FTP 4 - -4 P_FTPS 5