Re: [PATCH 2/2] udhcpc: fixed a TODO in fill_envp using option scanner

2020-07-05 Thread Raymond Jansen
Glad to hear you're planning on improving compliance with DHCP standards. I understand that for the sake of simplicity and binary size one would prefer ignoring niche features in RFCs; however, correct handling of long options in DHCP (RFC 3396) is crucial for interoperability and ignoring it

Re: [PATCH 2/2] udhcpc: fixed a TODO in fill_envp using option scanner

2020-07-02 Thread Martin Lewis
Thank you for applying the commits! I started implementing support for RFC 3396, hopefully it will be ready soon. Martin On Mon, 29 Jun 2020 at 08:40, Denys Vlasenko wrote: > Applied, thanks > > On Tue, Jun 23, 2020 at 3:41 PM Martin Lewis > wrote: > > > > fill_envp now iterates over the

Re: [PATCH 2/2] udhcpc: fixed a TODO in fill_envp using option scanner

2020-06-29 Thread Denys Vlasenko
Applied, thanks On Tue, Jun 23, 2020 at 3:41 PM Martin Lewis wrote: > > fill_envp now iterates over the packet only once instead of a few hundred > times > using the new option scanner. > > Signed-off-by: Martin Lewis > --- > networking/udhcp/dhcpc.c | 201 >

[PATCH 2/2] udhcpc: fixed a TODO in fill_envp using option scanner

2020-06-23 Thread Martin Lewis
fill_envp now iterates over the packet only once instead of a few hundred times using the new option scanner. Signed-off-by: Martin Lewis --- networking/udhcp/dhcpc.c | 201 --- 1 file changed, 87 insertions(+), 114 deletions(-) diff --git