Re: [PATCH 2/7] df: Use statvfs instead of non-standard statfs

Hi Ralf, Ralf Friedl wrote, > Here are the patches: > - Define _STATFS_F_FRSIZE for MIPS. > - Only emulate statfs64 if __NR_statfs64 is not defined. > Thanks, both patches applied and pushed, best regards Waldemar ___ busybox mailing list

Re: [PATCH 2/7] df: Use statvfs instead of non-standard statfs

Applied, thanks! On Sat, Oct 7, 2017 at 7:53 PM, James Clarke wrote: > Platforms differ on what their implementations of statfs include. > Importantly, FreeBSD's does not include a f_frsize member inside struct > statfs. However, statvfs is specified by POSIX and includes

Re: [PATCH 2/7] df: Use statvfs instead of non-standard statfs

Waldemar Brodkorb wrote: Ralf Friedl wrote, I just want to point out that while uClibc statvfs does always set f_frsize, currently on MIPS at least it doesn't use the value returned by the kernel, instead it copies the value from f_bsize, thus negating commit

Re: [PATCH 2/7] df: Use statvfs instead of non-standard statfs

Hi Waldemar, On Sat, Oct 28, 2017 at 10:16 AM, Waldemar Brodkorb wrote: > May be somebody can suggest a patch to fix the bug in uClibc? > I am always open for bugfixes. I'll do in a couple of days (after the long weekend here in Germany). Cheers, Gene

Re: [PATCH 2/7] df: Use statvfs instead of non-standard statfs

Hi, Ralf Friedl wrote, > Eugene Rudoy wrote: > >just wanted to point out that besides making the code more portable > >the change suggested by James has another positive side effect. It > >eliminates the need for the uClibc related and as of now unreliable > >workaround added in the second hunk

Re: [PATCH 2/7] df: Use statvfs instead of non-standard statfs

Eugene Rudoy wrote: just wanted to point out that besides making the code more portable the change suggested by James has another positive side effect. It eliminates the need for the uClibc related and as of now unreliable workaround added in the second hunk of e184a88 [1]. Why unreliable?

Re: [PATCH 2/7] df: Use statvfs instead of non-standard statfs

Hi all, just wanted to point out that besides making the code more portable the change suggested by James has another positive side effect. It eliminates the need for the uClibc related and as of now unreliable workaround added in the second hunk of e184a88 [1]. Why unreliable? "statfs

[PATCH 2/7] df: Use statvfs instead of non-standard statfs

Platforms differ on what their implementations of statfs include. Importantly, FreeBSD's does not include a f_frsize member inside struct statfs. However, statvfs is specified by POSIX and includes everything we need, so we can just use that instead. Signed-off-by: James Clarke