Re: [PATCH v2 3/3] touch: remove unneeded GETOPT32 defines

2021-04-12 Thread Denys Vlasenko
Applied all 3 patches. Thank you. On Sat, Apr 10, 2021 at 12:44 AM Xabier Oneca -- xOneca wrote: > > > Long options handling (getopt32 vs getopt32long) is done in libb.h, no need > > to > > care here of the same logic. This cleans the code a bit. > > > > Also, --no-create was grouped as a SUSv3

Re: [PATCH v2 3/3] touch: remove unneeded GETOPT32 defines

2021-04-09 Thread Peter D
> Grr..! GMail botched indentation for review, but the attached patch is > correct. git send-email never will :) I gave it some testing, and everything worked as intended. I tried the using the following commands: ./busybox touch -d 2000-01-01 -m FILE This correctly set the access date to Access

Re: [PATCH v2 3/3] touch: remove unneeded GETOPT32 defines

2021-04-09 Thread Xabier Oneca -- xOneca
> Long options handling (getopt32 vs getopt32long) is done in libb.h, no need to > care here of the same logic. This cleans the code a bit. > > Also, --no-create was grouped as a SUSv3 option, where as the short -c was > not. > Even if it is part of SUS, leave it out as was the short option. > > v

[PATCH v2 3/3] touch: remove unneeded GETOPT32 defines

2021-04-09 Thread Xabier Oneca -- xOneca
ONGOPTS - IF_FEATURE_TOUCH_SUSV3(, &reference_file) - IF_FEATURE_TOUCH_SUSV3(, &date_str) - IF_FEATURE_TOUCH_SUSV3(, &date_str) + /*ignored:*/ "f" IF_NOT_FEATURE_TOUCH_SUSV3("am"), + touch_longopts +#if ENABLE_FEATURE_TOUCH_SUSV3 + , &reference_file + , &date_str + , &date_s