Re: Memory leak in ash with script using "local" incorrectly

On 29 October 2015 at 16:36, Ron Yorston wrote: > Bastian Bittorf wrote: >>i just tested v1.24.1 on OpenWrt[1] and there is *no* leak. > > I think this is due to > > <0a0acb5> 2015-04-18 [Denys Vlasenko] ash: fix handling of duplicate "local" > > which is included in 1.24 but

Re: Memory leak in ash with script using "local" incorrectly

* Rafał Miłecki [29.10.2015 07:29]: > while loop. Minimal test-case: > while [ 1 ]; do local foo=$(date); done > BusyBox's ash never complained but it was leaking a memory. i did some more testing with an OpenWrt-UML: i=0;while :; do i=$(( i + 1 )); local foo=$(:); case "$i" in

Re: Memory leak in ash with script using "local" incorrectly

* Rafał Miłecki [29.10.2015 07:29]: > However I guess it would be nice thing to stop memory leak, even if > script code is incorrect. Could someone take a look at this, please? > > My BusyBox/ash version: > BusyBox v1.23.2 (2015-07-12 11:22:27 CEST) built-in shell (ash) i just

Re: Memory leak in ash with script using "local" incorrectly

Bastian Bittorf wrote: >i just tested v1.24.1 on OpenWrt[1] and there is *no* leak. I think this is due to <0a0acb5> 2015-04-18 [Denys Vlasenko] ash: fix handling of duplicate "local" which is included in 1.24 but not 1.23. This patch detects if a local variable is being declared more than

Memory leak in ash with script using "local" incorrectly

Hi, I incorrectly used "local" in my script assuming it's allowed in a while loop. Minimal test-case: while [ 1 ]; do local foo=$(date); done BusyBox's ash never complained but it was leaking a memory. I don't know if such incorrect usage is worth any warning. For a reference, bash does this: >

Re: Memory leak in ash with script using "local" incorrectly

* Rafał Miłecki [29.10.2015 07:29]: > However I guess it would be nice thing to stop memory leak, even if > script code is incorrect. Could someone take a look at this, please? > > My BusyBox/ash version: > BusyBox v1.23.2 (2015-07-12 11:22:27 CEST) built-in shell (ash) can

Re: Memory leak in ash with script using "local" incorrectly

* Rafał Miłecki [29.10.2015 07:29]: > However I guess it would be nice thing to stop memory leak, even if > script code is incorrect. Could someone take a look at this, please? > > My BusyBox/ash version: > BusyBox v1.23.2 (2015-07-12 11:22:27 CEST) built-in shell (ash) please