Re: NOEXEC environment bug

2017-11-03 Thread Denys Vlasenko
On Wed, Nov 1, 2017 at 8:50 PM, Ron Yorston wrote: > There's a related problem when SH_STANDALONE and SH_NOFORK are enabled: > changed shell variables aren't visible to NOFORK applets. For example, > >$ ./busybox sh >$ mkdir ~/mybin >$ cp busybox ~/mybin/thing >$ export PATH=~/myb

Re: NOEXEC environment bug

2017-11-02 Thread Ralf Friedl
Jack Schmidt wrote: On 2017-11-02, at 08:26 , Denys Vlasenko wrote: On Wed, Nov 1, 2017 at 2:28 AM, Jack Schmidt wrote: I believe I have found a bug in the current version of busybox. When: * an applet is marked NOEXEC, * busybox is configured with CONFIG_FEATURE_SH_STANDALONE=y, and * busyb

Re: NOEXEC environment bug

2017-11-02 Thread Jack Schmidt
> On 2017-11-02, at 08:26 , Denys Vlasenko wrote: > > On Wed, Nov 1, 2017 at 2:28 AM, Jack Schmidt wrote: >> I believe I have found a bug in the current version of busybox. >> >> When: >> * an applet is marked NOEXEC, >> * busybox is configured with CONFIG_FEATURE_SH_STANDALONE=y, and >> * bus

Re: NOEXEC environment bug

2017-11-02 Thread Denys Vlasenko
On Wed, Nov 1, 2017 at 2:28 AM, Jack Schmidt wrote: > I believe I have found a bug in the current version of busybox. > > When: > * an applet is marked NOEXEC, > * busybox is configured with CONFIG_FEATURE_SH_STANDALONE=y, and > * busybox's ash is asked to do "ENV_VAR=newval no_exec_app" > Then th

Re: NOEXEC environment bug

2017-11-01 Thread Ron Yorston
There's a related problem when SH_STANDALONE and SH_NOFORK are enabled: changed shell variables aren't visible to NOFORK applets. For example, $ ./busybox sh $ mkdir ~/mybin $ cp busybox ~/mybin/thing $ export PATH=~/mybin:$PATH $ which thing $ If SH_NOFORK is disabled (or 'wh

NOEXEC environment bug

2017-10-31 Thread Jack Schmidt
I believe I have found a bug in the current version of busybox. When: * an applet is marked NOEXEC, * busybox is configured with CONFIG_FEATURE_SH_STANDALONE=y, and * busybox's ash is asked to do "ENV_VAR=newval no_exec_app" Then the no_exec app is not called with the new environment. This affec