RE: Re: Re: missing format string in applets/usage_pod.c

2014-08-18 Thread Cathey, Jim
-boun...@busybox.net] On Behalf Of Tanguy Pruvot Sent: Thursday, August 14, 2014 6:45 AM To: Laszlo Papp Cc: wald...@gmx.de; busybox Subject: Re: Re: Re: missing format string in applets/usage_pod.c its the same with bionic libc (arm) printf(test) is ok but not printf(buf) with char buf[] = test

Re: Re: Re: missing format string in applets/usage_pod.c

2014-08-18 Thread Laszlo Papp
, 2014 6:45 AM *To:* Laszlo Papp *Cc:* wald...@gmx.de; busybox *Subject:* Re: Re: Re: missing format string in applets/usage_pod.c its the same with bionic libc (arm) printf(test) is ok but not printf(buf) with char buf[] = test; printf(%s, buf) is ok 2014-08-14 15:29 GMT+02:00

Re: Re: Re: missing format string in applets/usage_pod.c

2014-08-15 Thread Isaac Dunham
On Thu, Aug 14, 2014 at 04:15:50PM +0100, Laszlo Papp wrote: On Thu, Aug 14, 2014 at 4:05 PM, Rich Felker dal...@libc.org wrote: On Thu, Aug 14, 2014 at 03:28:51PM +0100, Laszlo Papp wrote: On Thu, Aug 14, 2014 at 2:44 PM, Tanguy Pruvot tanguy.pru...@gmail.com wrote: its the same

Re: Re: Re: missing format string in applets/usage_pod.c

2014-08-15 Thread Rich Felker
On Thu, Aug 14, 2014 at 11:58:56PM -0700, Isaac Dunham wrote: On Thu, Aug 14, 2014 at 04:15:50PM +0100, Laszlo Papp wrote: On Thu, Aug 14, 2014 at 4:05 PM, Rich Felker dal...@libc.org wrote: On Thu, Aug 14, 2014 at 03:28:51PM +0100, Laszlo Papp wrote: On Thu, Aug 14, 2014 at 2:44 PM,

Re: Re: Re: missing format string in applets/usage_pod.c

2014-08-15 Thread Laszlo Papp
On Fri, Aug 15, 2014 at 6:31 PM, Rich Felker dal...@libc.org wrote: On Thu, Aug 14, 2014 at 11:58:56PM -0700, Isaac Dunham wrote: On Thu, Aug 14, 2014 at 04:15:50PM +0100, Laszlo Papp wrote: On Thu, Aug 14, 2014 at 4:05 PM, Rich Felker dal...@libc.org wrote: On Thu, Aug 14, 2014 at

Re: Re: Re: missing format string in applets/usage_pod.c

2014-08-15 Thread Isaac Dunham
On Fri, Aug 15, 2014 at 06:39:39PM +0100, Laszlo Papp wrote: On Fri, Aug 15, 2014 at 6:31 PM, Rich Felker dal...@libc.org wrote: On Thu, Aug 14, 2014 at 11:58:56PM -0700, Isaac Dunham wrote: On Thu, Aug 14, 2014 at 04:15:50PM +0100, Laszlo Papp wrote: On Thu, Aug 14, 2014 at 4:05 PM,

Re: Re: Re: missing format string in applets/usage_pod.c

2014-08-14 Thread Laszlo Papp
Sorry, the list was left out at some point due to my mistake ... See below. On Thu, Aug 14, 2014 at 2:28 PM, Laszlo Papp lp...@kde.org wrote: On Thu, Aug 14, 2014 at 2:04 PM, wald...@gmx.de wrote: Hi Laszlo, Cannot reproduce with -Wall -Wpedantic -Wextra. Did you notice:

Re: Re: Re: missing format string in applets/usage_pod.c

2014-08-14 Thread Tanguy Pruvot
its the same with bionic libc (arm) printf(test) is ok but not printf(buf) with char buf[] = test; printf(%s, buf) is ok 2014-08-14 15:29 GMT+02:00 Laszlo Papp lp...@kde.org: Sorry, the list was left out at some point due to my mistake ... See below. On Thu, Aug 14, 2014 at 2:28 PM, Laszlo

Re: Re: Re: missing format string in applets/usage_pod.c

2014-08-14 Thread Laszlo Papp
On Thu, Aug 14, 2014 at 2:44 PM, Tanguy Pruvot tanguy.pru...@gmail.com wrote: its the same with bionic libc (arm) printf(test) is ok but not printf(buf) with char buf[] = test; printf(%s, buf) is ok Yeah, I guess it is about personal preference. I personally do not like the extended code

Re: Re: Re: Re: missing format string in applets/usage_pod.c

2014-08-14 Thread Laszlo Papp
On Thu, Aug 14, 2014 at 3:36 PM, wald...@gmx.de wrote: Hi Laszlo, Yeah, I guess it is about personal preference. I personally do not like the extended code just to make some smart option silent. ... Based on your arguing it seems that you have NEVER heard about format string exploits

Re: Re: Re: missing format string in applets/usage_pod.c

2014-08-14 Thread Rich Felker
On Thu, Aug 14, 2014 at 03:28:51PM +0100, Laszlo Papp wrote: On Thu, Aug 14, 2014 at 2:44 PM, Tanguy Pruvot tanguy.pru...@gmail.com wrote: its the same with bionic libc (arm) printf(test) is ok but not printf(buf) with char buf[] = test; printf(%s, buf) is ok Yeah, I guess it is

Re: Re: Re: missing format string in applets/usage_pod.c

2014-08-14 Thread Laszlo Papp
On Thu, Aug 14, 2014 at 4:05 PM, Rich Felker dal...@libc.org wrote: On Thu, Aug 14, 2014 at 03:28:51PM +0100, Laszlo Papp wrote: On Thu, Aug 14, 2014 at 2:44 PM, Tanguy Pruvot tanguy.pru...@gmail.com wrote: its the same with bionic libc (arm) printf(test) is ok but not printf(buf)

Re: Re: Re: missing format string in applets/usage_pod.c

2014-08-14 Thread Laszlo Papp
Here is my benchmark just to show I am not speaking out of an imaginary world: #include stdio.h int main() { const char *buff = foo; int i = 0; for (i; i 100; ++i) // fputs(buff, stdout); printf(%s, buff); return 0; } Fputs: real0m1.761s user