From 0bc9113dc8fa6c3f631094dd1caa44c2874984b0 Mon Sep 17 00:00:00 2001
From: John Spencer maillist-busy...@barfooze.de
Date: Fri, 20 Sep 2013 19:28:29 +0200
Subject: [PATCH] tar: support xz compression as well
the previous patch by Boris Reisig, dfc2473b9ed88039697ac89ee2a4301cdaefcf84 ,
while
Hmm, can you send your patches via git-email? It's easier for a review.
Do we need all this zipWTF variables now (when we have gzip|bzip2|xz)?
gzipPid, zipMode, zip_exec etc.
What about using ct (shortform of compressor) instead (ctPid,
ctMode, ct_exec, etc.)?
- Sedat -
2013/9/20 John Spencer
Is ENABLE_FEATURE_SEAMLESS_GZ missing here?
...
+static const char compressor[][6] = {
# if ENABLE_FEATURE_SEAMLESS_GZ
+[ct_gzip - 1] = gzip,
#endif
+#if ENABLE_FEATURE_SEAMLESS_BZ2
+[ct_bzip2 - 1] = bzip2,
+#endif
+#if ENABLE_FEATURE_SEAMLESS_XZ
+[ct_xz - 1]= xz,
On 09/20/2013 09:46 PM, Sedat Dilek wrote:
Is ENABLE_FEATURE_SEAMLESS_GZ missing here?
no, because
1) the function will only be called/compiled if at least one compressor
is enabled
2) if gzip is disabled, it's array index (enum value) doesnt change
because of that, so the first array must
it occured to me that it's more efficient to pass around the string
itself instead of an enum, so here's patch v2.
On 09/20/2013 08:28 PM, John Spencer wrote:
___
busybox mailing list
busybox@busybox.net
