Re: klogd broken in 1.13.0?

2008-11-19 Thread Hamish Moffatt
On Thu, Nov 20, 2008 at 12:48:50AM +0100, Denys Vlasenko wrote: > On Thursday 20 November 2008 00:41, Hamish Moffatt wrote: > > On Wed, Nov 19, 2008 at 08:45:53AM +0100, Denys Vlasenko wrote: > > > Does it help if you just add this one line? > > > > > > /* "2 -- Read from the log."

Re: klogd broken in 1.13.0?

2008-11-19 Thread Denys Vlasenko
On Thursday 20 November 2008 00:41, Hamish Moffatt wrote: > On Wed, Nov 19, 2008 at 08:45:53AM +0100, Denys Vlasenko wrote: > > Does it help if you just add this one line? > > > > /* "2 -- Read from the log." */ > > n = klogctl(2, log_buffer + used, KLOGD_LOGBUF_SIZ

Re: klogd broken in 1.13.0?

2008-11-19 Thread Hamish Moffatt
On Wed, Nov 19, 2008 at 08:45:53AM +0100, Denys Vlasenko wrote: > On Wednesday 19 November 2008 05:17, Hamish Moffatt wrote: > > I just switched from busybox 1.11.2 to 1.13.0 for a project and now kernel > > message logging seems a bit busted. It starts ok but then goes wrong. > > Application logg

Re: klogd broken in 1.13.0?

2008-11-18 Thread Denys Vlasenko
On Wednesday 19 November 2008 05:17, Hamish Moffatt wrote: > I just switched from busybox 1.11.2 to 1.13.0 for a project and now kernel > message logging seems a bit busted. It starts ok but then goes wrong. > Application logging seems to work ok still (see the last 5 lines of this > example). >

Re: klogd broken in 1.13.0?

2008-11-18 Thread Steve Bennett
I suspect strcpy vs memmove. Try this patch and let me know if it helps. Cheers, Steve On 19/11/2008, at 2:17 PM, Hamish Moffatt wrote: I just switched from busybox 1.11.2 to 1.13.0 for a project and now kernel message logging seems a bit busted. It starts ok but then goes wrong. Applicatio

klogd broken in 1.13.0?

2008-11-18 Thread Hamish Moffatt
I just switched from busybox 1.11.2 to 1.13.0 for a project and now kernel message logging seems a bit busted. It starts ok but then goes wrong. Application logging seems to work ok still (see the last 5 lines of this example). I backed out rev 23583 and now it works again. Viewing whole files o