Re: mdev : bug corrected (patch attached) - recursive_action version

2007-06-14 Thread Mike Frysinger
On Thursday 14 June 2007, Jason Curl wrote: > Mike Frysinger wrote: > > On Wednesday 13 June 2007, souf wrote: > >> Le mercredi 13 juin 2007 à 17:13 -0400, Mike Frysinger a écrit : > >>> plus, i think we're talking microseconds difference here, not seconds > >> > >> in an real time system that coun

Re: mdev : bug corrected (patch attached) - recursive_action version

2007-06-13 Thread Jason Curl
Mike Frysinger wrote: > On Wednesday 13 June 2007, souf wrote: >> Le mercredi 13 juin 2007 à 17:13 -0400, Mike Frysinger a écrit : >>> plus, i think we're talking microseconds difference here, not seconds >> in an real time system that counts much > > if we were talking costs that'd have to be pai

Re: mdev : bug corrected (patch attached) - recursive_action version

2007-06-13 Thread Mike Frysinger
On Wednesday 13 June 2007, souf wrote: > Le mercredi 13 juin 2007 à 17:13 -0400, Mike Frysinger a écrit : > > plus, i think we're talking microseconds difference here, not seconds > > in an real time system that counts much if we were talking costs that'd have to be paid over and over, you might h

Re: mdev : bug corrected (patch attached) - recursive_action version

2007-06-13 Thread souf
Le mercredi 13 juin 2007 à 17:13 -0400, Mike Frysinger a écrit : > plus, i think we're talking microseconds difference here, not seconds in an real time system that counts much ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/ma

Re: mdev : bug corrected (patch attached) - recursive_action version

2007-06-13 Thread Mike Frysinger
On Wednesday 13 June 2007, souf wrote: > example (kernel >= 2.6.20 without CONFIG_SYSFS_DEPRECATED [= n]): > /sys/class/sound/timer : timer is a symlink towards > ../../devices/virtual/sound/timer realpath(symlink, device_path); > device_path = /sys/devices/virtual/sound/timer > make_device(/sys/de

Re: mdev : bug corrected (patch attached) - recursive_action version

2007-06-13 Thread souf
Hi all, waow! there was change, it is well even if my patch was not chosen to improve mdev !? in mdev.c (svn): >#define MAX_SYSFS_DEPTH 3 /* prevent infinite loops in /sys symlinks */ >... >static int fileAction(const char *fileName, struct stat *statbuf, void >*userData, int depth) >... >static

Re: mdev : bug corrected (patch attached) - recursive_action version

2007-06-13 Thread Renaud Cerrato
Damned. I was too hurry (too much job in same time!). Thanks for noticing. Heres the correction. 2007/6/13, Mike Frysinger <[EMAIL PROTECTED]>: On Monday 11 June 2007, Renaud Cerrato wrote: > Here's the patch correcting mdev, using recursive_action : > > We noticed that some devices were not a

Re: mdev : bug corrected (patch attached) - recursive_action version

2007-06-13 Thread Mike Frysinger
On Monday 11 June 2007, Renaud Cerrato wrote: > Here's the patch correcting mdev, using recursive_action : > > We noticed that some devices were not attached to /dev/ using "mdev -s". > Looking at the source code, the function which walk through the /sys/ tree > make use of lstat, but the /sys tree

Re: mdev : bug corrected (patch attached) - recursive_action version

2007-06-11 Thread Renaud Cerrato
Oups, sorry.. Just corrected, attached patch modified in consequence. Size benchmark (Intel, defconfig): Busybox before : textdata bss dec hex filename 5678693008 46992 617869 96d8d busybox Busybox patched : textdata bss dec hex filename 5678213

Re: mdev : bug corrected (patch attached) - recursive_action version

2007-06-11 Thread Bernhard Fischer
On Mon, Jun 11, 2007 at 09:56:37AM +0200, Renaud Cerrato wrote: >Dear, > >Here's the patch correcting mdev, using recursive_action : > >We noticed that some devices were not attached to /dev/ using "mdev -s". >Looking at the source code, the function which walk through the /sys/ tree >make use of l

mdev : bug corrected (patch attached) - recursive_action version

2007-06-11 Thread Renaud Cerrato
Dear, Here's the patch correcting mdev, using recursive_action : We noticed that some devices were not attached to /dev/ using "mdev -s". Looking at the source code, the function which walk through the /sys/ tree make use of lstat, but the /sys tree can use symlink as seen here : $ ls -l /sys/c

Re: mdev : bug corrected (patch attached)

2007-06-02 Thread Natanael Copa
On Fri, 2007-06-01 at 19:08 +0200, Souf wrote: > I had already sent a large patch to improve mdev but it does not seem to > interest many people, in any case I resend it here, it uses: I am very interested in your patches. I have just been busy with other things lately. Natanael Copa __

Re: mdev : bug corrected (patch attached)

2007-06-02 Thread Souf
Le vendredi 01 juin 2007 à 23:43 +0200, Bernhard Fischer a écrit : > What's the bloat-o-meter output against pristine trunk and the size(1) > output of it? original mdev : without features : 3072 bytes with FEATURE_MDEV_CONF : 4464 bytes (delta : +1392 bytes) with FEATURE_MDEV_EXEC : 5052 by

Re: mdev : bug corrected (patch attached)

2007-06-01 Thread Bernhard Fischer
On Fri, Jun 01, 2007 at 08:36:19PM +0200, Souf wrote: >Le vendredi 01 juin 2007 à 19:16 +0200, Bernhard Fischer a écrit : >> On Fri, Jun 01, 2007 at 07:08:16PM +0200, Souf wrote: >> >Le vendredi 01 juin 2007 à 15:57 +0200, Bernhard Fischer a écrit : >> >> >> recursive_action() anyone? >> > >> >I h

Re: mdev : bug corrected (patch attached)

2007-06-01 Thread Souf
Le vendredi 01 juin 2007 à 19:16 +0200, Bernhard Fischer a écrit : > On Fri, Jun 01, 2007 at 07:08:16PM +0200, Souf wrote: > >Le vendredi 01 juin 2007 à 15:57 +0200, Bernhard Fischer a écrit : > > >> recursive_action() anyone? > > > >I had already sent a large patch to improve mdev but it does not

Re: mdev : bug corrected (patch attached)

2007-06-01 Thread Bernhard Fischer
On Fri, Jun 01, 2007 at 07:08:16PM +0200, Souf wrote: >Le vendredi 01 juin 2007 à 15:57 +0200, Bernhard Fischer a écrit : >> recursive_action() anyone? > >I had already sent a large patch to improve mdev but it does not seem to >interest many people, in any case I resend it here, it uses: > >xmall

Re: mdev : bug corrected (patch attached)

2007-06-01 Thread Renaud Cerrato
Great. I'll merge your patch with mine, and make use of recursive_action ;) Expected for next week. Cheers ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: mdev : bug corrected (patch attached)

2007-06-01 Thread Souf
Le vendredi 01 juin 2007 à 15:15 +0200, Renaud Cerrato a écrit : > Dear, > > Using mdev, we noticed that some devices were not attached to /dev/ > using "mdev -s". > Looking at the source code, the function which walk through the /sys/ > tree make use of lstat, but the /sys tree can use symlink as

Re: mdev : bug corrected (patch attached)

2007-06-01 Thread Souf
Le vendredi 01 juin 2007 à 15:57 +0200, Bernhard Fischer a écrit : > On Fri, Jun 01, 2007 at 03:15:10PM +0200, Renaud Cerrato wrote: > >Dear, > > > >Using mdev, we noticed that some devices were not attached to /dev/ using > >"mdev -s". > >Looking at the source code, the function which walk through

Re: mdev : bug corrected (patch attached)

2007-06-01 Thread Bernhard Fischer
On Fri, Jun 01, 2007 at 03:15:10PM +0200, Renaud Cerrato wrote: >Dear, > >Using mdev, we noticed that some devices were not attached to /dev/ using >"mdev -s". >Looking at the source code, the function which walk through the /sys/ tree >make use of lstat, but the /sys tree can use symlink as seen h

mdev : bug corrected (patch attached)

2007-06-01 Thread Renaud Cerrato
Dear, Using mdev, we noticed that some devices were not attached to /dev/ using "mdev -s". Looking at the source code, the function which walk through the /sys/ tree make use of lstat, but the /sys tree can use symlink as seen here : $ ls -l /sys/class/misc/ lrwxrwxrwx1 root root