Re: mysterious segfault with busybox 1.13.0 ash

2008-11-21 Thread Denys Vlasenko
On Friday 21 November 2008 18:33, Cristian Ionescu-Idbohrn wrote: > > > This patch should be added to fixes 1.13.0 > > > > http://busybox.net/downloads/fixes-1.13.0/busybox-1.13.0-ash.patch > > CC shell/ash.o > shell/ash.c:7578: error: 'NTO2' undeclared here (not in a function) > shell/ash.

Re: mysterious segfault with busybox 1.13.0 ash

2008-11-21 Thread Cristian Ionescu-Idbohrn
On Fri, 21 Nov 2008, Denys Vlasenko wrote: > On Fri, Nov 21, 2008 at 10:08 AM, Natanael Copa <[EMAIL PROTECTED]> wrote: > > On Fri, 2008-11-21 at 10:54 +0200, Timo Teräs wrote: > >> Looks like ash was broken in commit r23583 where the node type defines > >> were changed, but related arrays were no

Re: mysterious segfault with busybox 1.13.0 ash

2008-11-21 Thread Denys Vlasenko
On Fri, Nov 21, 2008 at 10:08 AM, Natanael Copa <[EMAIL PROTECTED]> wrote: > On Fri, 2008-11-21 at 10:54 +0200, Timo Teräs wrote: >> Looks like ash was broken in commit r23583 where the node type defines >> were changed, but related arrays were not updated. Especially the node >> size table which a

Re: mysterious segfault with busybox 1.13.0 ash

2008-11-21 Thread Natanael Copa
On Fri, 2008-11-21 at 10:54 +0200, Timo Teräs wrote: > Natanael Copa wrote: > > On Thu, 2008-11-20 at 23:42 +0100, Cristian Ionescu-Idbohrn wrote: > >> On Thu, 20 Nov 2008, Bernhard Reutner-Fischer wrote: > >> > >>> On Wed, Nov 19, 2008 at 09:30:27PM +0100, Natanael Copa wrote: > On Wed, 2008-

Re: mysterious segfault with busybox 1.13.0 ash

2008-11-21 Thread Timo Teräs
Natanael Copa wrote: > On Thu, 2008-11-20 at 23:42 +0100, Cristian Ionescu-Idbohrn wrote: >> On Thu, 20 Nov 2008, Bernhard Reutner-Fischer wrote: >> >>> On Wed, Nov 19, 2008 at 09:30:27PM +0100, Natanael Copa wrote: On Wed, 2008-11-19 at 21:17 +0100, Natanael Copa wrote: > shorter testcase

Re: mysterious segfault with busybox 1.13.0 ash

2008-11-20 Thread Michael Abbott
On Thu, 20 Nov 2008, Cristian Ionescu-Idbohrn wrote: > But this: > # ./busybox ash -c 'foo(){false||echo foo;};foo' > fail with: > ash: syntax error: ";" unexpected That's normal: for slightly mysterious reasons, { and } aren't parsed as special separators, for example in bash (though ash for

Re: mysterious segfault with busybox 1.13.0 ash

2008-11-20 Thread Natanael Copa
On Thu, 2008-11-20 at 23:42 +0100, Cristian Ionescu-Idbohrn wrote: > On Thu, 20 Nov 2008, Bernhard Reutner-Fischer wrote: > > > On Wed, Nov 19, 2008 at 09:30:27PM +0100, Natanael Copa wrote: > > >On Wed, 2008-11-19 at 21:17 +0100, Natanael Copa wrote: > > > > >> shorter testcase: > > >> > > >> ash

Re: mysterious segfault with busybox 1.13.0 ash

2008-11-20 Thread Cristian Ionescu-Idbohrn
On Thu, 20 Nov 2008, Bernhard Reutner-Fischer wrote: > On Wed, Nov 19, 2008 at 09:30:27PM +0100, Natanael Copa wrote: > >On Wed, 2008-11-19 at 21:17 +0100, Natanael Copa wrote: > > >> shorter testcase: > >> > >> ash -c "foo() { ! false && echo foo; }; foo" > > Works for me on trunk (on a debian bo

Re: mysterious segfault with busybox 1.13.0 ash

2008-11-20 Thread Natanael Copa
On Thu, 2008-11-20 at 09:45 +0100, Bernhard Reutner-Fischer wrote: > On Wed, Nov 19, 2008 at 09:30:27PM +0100, Natanael Copa wrote: > >On Wed, 2008-11-19 at 21:17 +0100, Natanael Copa wrote: > > >> shorter testcase: > >> > >> ash -c "foo() { ! false && echo foo; }; foo" > > Works for me on trunk

Re: mysterious segfault with busybox 1.13.0 ash

2008-11-20 Thread Natanael Copa
On Thu, 2008-11-20 at 09:45 +0100, Bernhard Reutner-Fischer wrote: > On Wed, Nov 19, 2008 at 09:30:27PM +0100, Natanael Copa wrote: > >On Wed, 2008-11-19 at 21:17 +0100, Natanael Copa wrote: > > >> shorter testcase: > >> > >> ash -c "foo() { ! false && echo foo; }; foo" > > Works for me on trunk

Re: mysterious segfault with busybox 1.13.0 ash

2008-11-20 Thread Bernhard Reutner-Fischer
On Wed, Nov 19, 2008 at 09:30:27PM +0100, Natanael Copa wrote: >On Wed, 2008-11-19 at 21:17 +0100, Natanael Copa wrote: >> shorter testcase: >> >> ash -c "foo() { ! false && echo foo; }; foo" Works for me on trunk (on a debian box).. ___ busybox mailin

Re: mysterious segfault with busybox 1.13.0 ash

2008-11-19 Thread Natanael Copa
On Wed, 2008-11-19 at 21:17 +0100, Natanael Copa wrote: > On Wed, 2008-11-19 at 21:11 +0100, Natanael Copa wrote: > > > > > interestingly enough, this happens only on a grsecurity kernel, but not > > on a default gentoo kernel (in chroot). tested in kvm only so far. > > my bad. it does segfault

Re: mysterious segfault with busybox 1.13.0 ash

2008-11-19 Thread Natanael Copa
On Wed, 2008-11-19 at 21:11 +0100, Natanael Copa wrote: > > interestingly enough, this happens only on a grsecurity kernel, but not > on a default gentoo kernel (in chroot). tested in kvm only so far. my bad. it does segfault on my desktop too with a normal gentoo kernel. shorter testcase: ash

Re: mysterious segfault with busybox 1.13.0 ash

2008-11-19 Thread Natanael Copa
On Wed, 2008-11-19 at 20:57 +0100, Natanael Copa wrote: > Hi, > > I have not been able to reproduce it in a small test script but it > happens exactly here: > http://dev.alpinelinux.org/cgit/cgit.cgi/alpine-baselayout/tree/init.d/runtimes#n178 ... Actually, I was able to create a smaller test sc

mysterious segfault with busybox 1.13.0 ash

2008-11-19 Thread Natanael Copa
Hi, I have not been able to reproduce it in a small test script but it happens exactly here: http://dev.alpinelinux.org/cgit/cgit.cgi/alpine-baselayout/tree/init.d/runtimes#n178 row 178. I suspect it is related to the ! operator. If I insert: ! false && echo foo the script will segfault and no