Re: pidfiles again

2007-03-27 Thread Denis Vlasenko
On Tuesday 27 March 2007 15:10, Stephane Billiart wrote: > This is a corrected patch, without O_EXCL in open and with a file mode. Applied to svn. open() of pidfile is: pid_fd = open(path, O_WRONLY|O_CREAT|O_TRUNC, 0666); Thanks. -- vda ___ busybox mai

Re: pidfiles again

2007-03-27 Thread Stephane Billiart
This is a corrected patch, without O_EXCL in open and with a file mode. -- Stéphane Billiart http://perso.orange.fr/billiart/ diff -ruN busybox.orig/Config.in busybox/Config.in --- busybox.orig/Config.in 2007-03-27 08:58:06.0 -0400 +++ busybox/Config.in 2007-03

Re: pidfiles again

2007-03-26 Thread Stephane Billiart
Thanks for your comments, I must admit that I never really looked at the remove_file code. I tried to follow your recommandations and here is another version which uses open/dprintf for writepidfile and a simple unlink for removepidfile. Let me know how it is. -- Stéphane Billiart

Re: pidfiles again

2007-03-26 Thread Denis Vlasenko
Hello Stephane, Thanks for your efforts to improve busybox. On Monday 26 March 2007 23:26, Stephane Billiart wrote: > With the patch, people who don't need pidfiles at all, because they're > using runsv or simply don't care can get a smaller busybox with no pidfile > at all and those, like me, wh

pidfiles again

2007-03-26 Thread Stephane Billiart
Once again, here is my patch that add pidfile support to crond and syslogd and simplify the pidfile code of inetd. Code is only enabled if CONFIG_FEATURE_PIDFILE is selected. With the patch, people who don't need pidfiles at all, because they're using runsv or simply don't care can get a smaller b