Re: some unnecessary preprocessor tests in libbb/

2008-07-17 Thread Robert P. J. Day
On Thu, 17 Jul 2008, Denys Vlasenko wrote: > On Thursday 17 July 2008 01:41, Robert P. J. Day wrote: > > > > in fact, it's misleading since it implies that the max length can be > > > > up to almost 32K when Config.in clearly restricts the value to 8K. > > > > > > > > rday > > > > > > These chec

Re: some unnecessary preprocessor tests in libbb/

2008-07-17 Thread Denys Vlasenko
On Thursday 17 July 2008 01:41, Robert P. J. Day wrote: > > > in fact, it's misleading since it implies that the max length can be > > > up to almost 32K when Config.in clearly restricts the value to 8K. > > > > > > rday > > > > These checks are there simply to make sure something didn't go bad..

Re: some unnecessary preprocessor tests in libbb/

2008-07-16 Thread Robert P. J. Day
On Wed, 16 Jul 2008, Poly-poly man wrote: > On Wednesday 16 July 2008 07:08:29 pm Robert P. J. Day wrote: > > some redundant or misleading preprocessor tests under libbb/. > > first, given this range restriction in Config.in: > > > > config MD5_SIZE_VS_SPEED > > int "MD5: Trade Bytes for

Re: some unnecessary preprocessor tests in libbb/

2008-07-16 Thread Poly-poly man
On Wednesday 16 July 2008 07:08:29 pm Robert P. J. Day wrote: > some redundant or misleading preprocessor tests under libbb/. > first, given this range restriction in Config.in: > > config MD5_SIZE_VS_SPEED > int "MD5: Trade Bytes for Speed" > default 2 > range 0 3 > > dup

some unnecessary preprocessor tests in libbb/

2008-07-16 Thread Robert P. J. Day
some redundant or misleading preprocessor tests under libbb/. first, given this range restriction in Config.in: config MD5_SIZE_VS_SPEED int "MD5: Trade Bytes for Speed" default 2 range 0 3 duplicating that range test in md5.c is redundant: #if CONFIG_MD5_SIZE_VS_SPEED