On 06/15/2012 04:44 PM, Denys Vlasenko wrote:
This should help:
commit c5b01016e622f01dfa9c8c542c0968fe37d4a5f2
Author: Denys Vlasenko
Date: Fri Jun 15 16:43:26 2012 +0200
unzip: make options parsing more robust on getopt w/o gnu extensions
After it, only -x will break.
thanks, this f
Actually, I didn't need to fix it on my system, but John Spencer wrote
"the unzip applet may be a candidate for custom argv parsing code,
getopt doesn't seem to be a good fit in this case" and I couldn't resist
the challenge.
Thanks for the specifics.
Doug Clapp
Denys Vlasenko wrote:
On Wed
On Wed, Jul 18, 2012 at 8:52 PM, Doug Clapp wrote:
>> Please send a diff.
>> Please follow code style of the surrounding code.
>> Please use tabs consistently.
>>
> Try this. I added more comments and tweaked the usage information slightly,
> as well as reworking the indentation. If the code sty
Denys Vlasenko wrote:
On Sat, Jun 23, 2012 at 9:52 PM, Doug Clapp wrote:
commit c5b01016e622f01dfa9c8c542c0968fe37d4a5f2
Author: Denys Vlasenko
Date: Fri Jun 15 16:43:26 2012 +0200
unzip: make options parsing more robust on getopt w/o gnu extensions
Also, code shrank:
func
On Sat, Jun 23, 2012 at 9:52 PM, Doug Clapp wrote:
>> commit c5b01016e622f01dfa9c8c542c0968fe37d4a5f2
>> Author: Denys Vlasenko
>> Date: Fri Jun 15 16:43:26 2012 +0200
>>
>> unzip: make options parsing more robust on getopt w/o gnu extensions
>>
>> Also, code shrank:
>>
>> function
Denys Vlasenko wrote:
This should help:
commit c5b01016e622f01dfa9c8c542c0968fe37d4a5f2
Author: Denys Vlasenko
Date: Fri Jun 15 16:43:26 2012 +0200
unzip: make options parsing more robust on getopt w/o gnu extensions
Also, code shrank:
function
This should help:
commit c5b01016e622f01dfa9c8c542c0968fe37d4a5f2
Author: Denys Vlasenko
Date: Fri Jun 15 16:43:26 2012 +0200
unzip: make options parsing more robust on getopt w/o gnu extensions
Also, code shrank:
function old new
Am 14.06.2012 23:36, schrieb John Spencer:
> On 06/14/2012 09:50 PM, Dan Fandrich wrote:
>> On Wed, Jun 13, 2012 at 07:37:13PM +0200, John Spencer wrote:
>>> I could trace it back to
>>>
>>> /* '-' makes getopt return 1 for non-options */
>>> while ((opt = getopt(argc, argv, "-d:lnopqxv")) != -1)
Original Message
Subject: Re: unzip applet not working ?
Date: Wed, 13 Jun 2012 13:34:41 -0400
From: Doug Clapp
Reply-To: doug.clapp1...@alumni.unc.edu
To: busybox
Denys Vlasenko wrote:
On Tue, Jun 12, 2012 at 11:22 PM, John Spencer
> wr
On 06/14/2012 09:50 PM, Dan Fandrich wrote:
On Wed, Jun 13, 2012 at 07:37:13PM +0200, John Spencer wrote:
I could trace it back to
/* '-' makes getopt return 1 for non-options */
while ((opt = getopt(argc, argv, "-d:lnopqxv")) != -1)
this returns *not* 1 with musl. according to Rich the commen
On Wed, Jun 13, 2012 at 07:37:13PM +0200, John Spencer wrote:
> I could trace it back to
>
> /* '-' makes getopt return 1 for non-options */
> while ((opt = getopt(argc, argv, "-d:lnopqxv")) != -1)
>
> this returns *not* 1 with musl. according to Rich the commented
> behaviour is a gnuism and not
On Wed, Jun 13, 2012 at 07:37:13PM +0200, John Spencer wrote:
> On 06/13/2012 01:39 PM, Denys Vlasenko wrote:
> >On Tue, Jun 12, 2012 at 11:22 PM, John Spencer
> > wrote:
> >>whatever option i pass to unzip, it only shows me the usage...
> >Cannot reproduce:
> >
> >I removed CONFIG_EXTRA_CFLAGS="-
Denys Vlasenko wrote:
On Tue, Jun 12, 2012 at 11:22 PM, John Spencer
wrote:
whatever option i pass to unzip, it only shows me the usage...
Cannot reproduce:
I removed CONFIG_EXTRA_CFLAGS="-D__musl__ -static"
from your .config, build 1.20.1 and resulting busybox
does work for me:
$ ./busybox
On 06/13/2012 01:39 PM, Denys Vlasenko wrote:
On Tue, Jun 12, 2012 at 11:22 PM, John Spencer
wrote:
whatever option i pass to unzip, it only shows me the usage...
Cannot reproduce:
I removed CONFIG_EXTRA_CFLAGS="-D__musl__ -static"
from your .config, build 1.20.1 and resulting busybox
does w
On Tue, Jun 12, 2012 at 11:22 PM, John Spencer
wrote:
> whatever option i pass to unzip, it only shows me the usage...
Cannot reproduce:
I removed CONFIG_EXTRA_CFLAGS="-D__musl__ -static"
from your .config, build 1.20.1 and resulting busybox
does work for me:
$ ./busybox unzip cyassl-2.2.0.zip
On 06/13/2012 02:59 AM, Denys Vlasenko wrote:
On Tuesday 12 June 2012 23:22, John Spencer wrote:
whatever option i pass to unzip, it only shows me the usage...
Your .config please?
https://github.com/rofl0r/sabotage/blob/master/KEEP/busybox.stage1.config
__
On Tuesday 12 June 2012 23:22, John Spencer wrote:
> whatever option i pass to unzip, it only shows me the usage...
Your .config please?
--
vda
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
whatever option i pass to unzip, it only shows me the usage...
root:/src/build/cyassl-cyassl-02079a2$ unzip cyassl-2.2.0.zip
BusyBox v1.20.1 (2012-06-08 13:15:44 UTC) multi-call binary.
Usage: unzip [-opts[modifiers]] FILE[.zip] [LIST] [-x XLIST] [-d DIR]
Extract files from ZIP archives
18 matches
Mail list logo
