Re: I'd like to require 2FA on github

SGTM! On Wed, Aug 23, 2017 at 8:25 AM, Daniel Stenberg wrote: > Hi friends! > > I would like us to start requiring members and collaborators of the c-ares > organization and repos to have two-factor authentication (2FA) enabled on > github. > > This of course to indirectly

Re: Handling of unexpectedly large UDP packets

On Thu, Oct 27, 2016 at 9:35 PM, Ben Nason via c-ares wrote: [snip] > You can see an example of a server that does this: "dig @81.218.119.11 > +notcp +ignore +noedns www.netflix.com" As an aside, wouldn't that response fit in 512 bytes if it used name compression

Re: [PATCH] Cmake-ify c-ares -- v2

On Thu, Sep 29, 2016 at 12:14 PM, Brad House <b...@mainstreetsoftworks.com> wrote: > On 9/28/16 9:19 AM, Brad House via c-ares wrote: >> >> On 9/28/16 7:40 AM, David Drysdale wrote: >>> >>> Any pull request will get run through Travis automatically [1], so

Re: [PATCH] Cmake-ify c-ares -- v2

On Wed, Sep 28, 2016 at 1:10 AM, Brad House via c-ares wrote: > On 9/27/16 9:52 AM, Gregor Jasny via c-ares wrote: >> >> Hi Brad, >> >> On 27/09/2016 13:44, Brad House via c-ares wrote: >>> >>> I've attached v2 of my CMake patch for c-ares. The changes are: >>> * Sync with

Re: Release coming up!

On Thu, Sep 29, 2016 at 7:46 AM, Daniel Stenberg <dan...@haxx.se> wrote: > On Tue, 27 Sep 2016, David Drysdale via c-ares wrote: > >>> That made me think. Do you think we should bump the version number for >>> the pending release to 1.12.0 because of th

Re: [PATCH] Cmake-ify c-ares -- v2

On Wed, Sep 28, 2016 at 1:09 AM, Brad House <b...@mainstreetsoftworks.com> wrote: > On 9/27/16 10:26 AM, David Drysdale via c-ares wrote: >> >> On Tue, Sep 27, 2016 at 2:52 PM, Gregor Jasny via c-ares >> <c-ares@cool.haxx.se> wrote: >>> >>> Hi

Re: [PATCH] Cmake-ify c-ares -- v2

Just following up on a couple of points from last time round, plus a question for Daniel below. On Tue, Sep 27, 2016 at 12:44 PM, Brad House via c-ares wrote: > I've attached v2 of my CMake patch for c-ares. The changes are: [snip] - The CMake build seems to assume

Re: Release coming up!

On Tue, Sep 27, 2016 at 8:26 AM, Daniel Stenberg <dan...@haxx.se> wrote: > On Sun, 25 Sep 2016, David Drysdale via c-ares wrote: > >> [Both merged; thanks for taking a look] > > > That made me think. Do you think we should bump the version number for the > pen

Re: arestest segfaults for me

On Sun, Sep 25, 2016 at 11:23 PM, Daniel Stenberg <dan...@haxx.se> wrote: > On Fri, 23 Sep 2016, David Drysdale wrote: > >> I can't reproduce the problem, so could you try doing a non-valgrind debug >> build and seeing what pops out in the debugger (e.g. libtool --mode=e

Re: Release coming up!

On Fri, Sep 23, 2016 at 2:54 PM, David Drysdale <drysd...@google.com> wrote: > On Fri, Sep 23, 2016 at 2:44 PM, Daniel Stenberg <dan...@haxx.se> wrote: >> >> Hello! >> >> I think it is about time to bring the band back together and do another >>

Re: Release coming up!

On Fri, Sep 23, 2016 at 2:44 PM, Daniel Stenberg wrote: > Hello! > > I think it is about time to bring the band back together and do another > c-ares release! I don't have a date just yet, this is just a wake-up call. > > So, if you have stuff to merge before we ship anything

Re: arestest segfaults for me

that seems odd... Thanks, David On Fri, Sep 23, 2016 at 9:38 AM, Daniel Stenberg <dan...@haxx.se> wrote: > On Fri, 23 Sep 2016, David Drysdale wrote: > > Is that just with valgrind, or are there problems with a normal run too? >> > > Ah sorry for being unclear: no it crashes i

Re: [PATCH] remove configure-time type size checks

t; > I'm sorry for that, but we seem to have a shortage of developers with energy > and time to spend on c-ares. There has primarly been David Drysdale over the > last few years and a single man on the job isn't good. I'm personally > certainly guilty of not spending much time on c-ares

Re: HTTPS and best practices for c-ares

Couple of updates below... On Mon, Aug 15, 2016 at 12:26 PM, David Drysdale <drysd...@google.com> wrote: > > Hi Daniel, > > I think there's a few things that aren't ticked but could be: > > - Quality: "It is SUGGESTED that this policy on adding tests be docu

Re: HTTPS and best practices for c-ares

Hi Daniel, I think there's a few things that aren't ticked but could be: - Quality: "It is SUGGESTED that this policy on adding tests be documented in the instructions for change proposals." - this is included since commit adc95e6bd68d, with the text "Please update the test suite to add a test

Re: Timeline for a new c-ares release

On Wed, Jan 13, 2016 at 2:27 PM, David Drysdale <drysd...@google.com> wrote: > On Wed, Jan 13, 2016 at 1:28 PM, Daniel Stenberg <dan...@haxx.se> wrote: >> On Sat, 9 Jan 2016, Gregor Jasny wrote: >> >>> Would it make sense to create a new release? >>

Re: Timeline for a new c-ares release

On Wed, Jan 13, 2016 at 1:28 PM, Daniel Stenberg wrote: > On Sat, 9 Jan 2016, Gregor Jasny wrote: > >> Would it make sense to create a new release? > > > Yes it would! > > There have been a bunch of patches flying around that I personally haven't > paid much attention to. Is

Re: Unit test suite for c-ares

On Wed, Nov 25, 2015 at 10:16 AM, Daniel Stenberg <dan...@haxx.se> wrote: > On Wed, 25 Nov 2015, David Drysdale wrote: > >> - Fix double-free from ares__read_line() failure case >> https://github.com/daviddrysdale/c-ares/commit/d91d731636f5 > > > +1 > >

Unit test suite for c-ares

Hi folks, I've made a start on a unit test suite for c-ares, and I'd be interested in any feedback. The changes so far are in a branch at https://github.com/daviddrysdale/c-ares/commits/test, with some key points being: - The tests are in C++11 (mostly so I can use gTest/gMock, using a local

Re: Visual studio 2013

Button pressed. On Thu, Aug 27, 2015 at 9:55 PM, David Hotham wrote: > c-ares currently doesn't compile under Microsoft Visual Studio 2013. All > that's required is to recognise the appropriate version number in > Makefile.msvc. I'd submit a patch, but someone

Re: [PATCH 1/5] Null check before dereference

LGTM On Fri, Sep 19, 2014 at 7:51 PM, Gregor Jasny gja...@googlemail.com wrote: Fix Coverity error CID 56880 Signed-off-by: Gregor Jasny gja...@googlemail.com --- ares_options.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ares_options.c b/ares_options.c index 76d82df..cf88433

Re: Extending EDNS support in c-ares for sub-options

OK, I've attached the combined patch -- it's got 3 small fixes to the existing EDNS code, plus 1 larger patch to do the sub-option support. Thanks, David On Mon, Oct 22, 2012 at 4:24 PM, Daniel Stenberg dan...@haxx.se wrote: On Mon, 22 Oct 2012, David Drysdale wrote: I've got some code

Extending EDNS support in c-ares for sub-options

Hi, I noticed that c-ares has recently been enhanced to support the EDNS OPT pseudo-RR (many thanks Ghennadi!). However, I'd like to also use the sub-option mechanism described in RFC2671 s4.4, which it doesn't look like the patch supports. Is there interest in a patch I'm preparing to add