Hello,
On 18.11.20 08:52, Daniel Stenberg wrote:
As some of you noticed, the 1.17.0 release was slightly borked and there
will soon be a patch release made. Thanks for your understanding and
cooperation!
After cherry-picking the soname and ares-dns.h changes from master into
the c-ares Debia
Hello,
c-ares 1.15 was released in October 2018. In the meantime the master
branch has accumulated quite some changes. How about scheduling a 1.16
release?
Thanks,
Gregor
On 2/5/18 3:44 PM, Brad House wrote:
> It seems like there's been a lot of fixes for Windows and Android since
> our last official release. I think it might be a good idea to start
> release planning for another release. Any thoughts on this or any PRs
> that should be addressed first? I think i
Hello,
On 03/01/2017 19:29, Stephen Sorley wrote:
Just submitted a PR for c-ares' CMake build system, pinging the list as
requested by the contributor instructions. Here's the link:
https://github.com/c-ares/c-ares/pull/77
The proposed patch explicitly sets the minimum version to 2.8.12 (the
On 17/10/2016 10:29, Daniel Stenberg wrote:
> On Sun, 16 Oct 2016, Gregor Jasny via c-ares wrote:
>
>> I think this branch is mergeable. Any of the requested changes can be
>> made with some small follow-up commits.
>
> Gregor, you can merge this yourself, can't
On 11/10/2016 15:31, Brad House via c-ares wrote:
> Any chance this pull request will be merged before too long? I don't like
> letting things just hang around.
I think this branch is mergeable. Any of the requested changes can be
made with some small follow-up commits.
Thanks,
Gregor
Hello,
On 29/09/2016 21:34, Gregor Jasny wrote:
> On 29/09/2016 14:34, David Drysdale wrote:
>>
>> Gregor / Daniel, did you have any thoughts on the CMake change?
>
> Yes, I'm reviewing it but the CVE took most of my spare time.
I think as soon as the latest comment
On 29/09/2016 14:34, David Drysdale wrote:
> On Wed, Sep 28, 2016 at 1:10 AM, Brad House via c-ares
>> https://github.com/c-ares/c-ares/pull/64
>>
>> -Brad
>
> Gregor / Daniel, did you have any thoughts on the CMake change?
Yes, I'm reviewing it but the CVE took most of my spare time.
-Gregor
Hi Brad,
On 27/09/2016 13:44, Brad House via c-ares wrote:
> I've attached v2 of my CMake patch for c-ares. The changes are:
> * Sync with master (no configure-time type size checks)
> * Support iOS multi-arch building
> * Require only CMake v2.8
>
> The main thing that still needs to be done
On 19/02/16 10:15, Daniel Stenberg wrote:
> Hello friends!
>
> I'm happy to once again offer a new c-ares release, approaching three
> years since the previous one. Thanks everyone for your contributions and
> help on making this release happen.
>
> c-ares version 1.11.0 is available for download
On 21/02/16 15:30, Gregor Jasny wrote:
> On 19/02/16 10:15, Daniel Stenberg wrote:
>> Hello friends!
>>
>> I'm happy to once again offer a new c-ares release, approaching three
>> years since the previous one. Thanks everyone for your contributions and
>&
Hello,
On 11/02/16 15:04, Daniel Stenberg wrote:
On Thu, 11 Feb 2016, Gregor Jasny wrote:
If you would create some kind of release candidate I could test it in
Debian Experimental against all architectures.
Good idea! It made me realize the test suite isn't bundled in the dist
archi
On 11/02/16 15:04, Daniel Stenberg wrote:
> On Thu, 11 Feb 2016, Gregor Jasny wrote:
>
>> If you would create some kind of release candidate I could test it in
>> Debian Experimental against all architectures.
>
> Good idea! It made me realize the test suite isn't
Hello,
On 11/02/16 11:22, Daniel Stenberg wrote:
On Sat, 9 Jan 2016, Gregor Jasny wrote:
Would it make sense to create a new release?
I hereby nominate Febrary 19th (Friday next week) as release date.
If you would create some kind of release candidate I could test it in
Debian
Hi,
David Drysdale wrote:
Thanks, I've pulled that change in (with a trvial tweak to break out of the
loop on strdup failure).
thanks for merging.
I would suggest that you remove the tweak because now deallocation is
broken. The problem is that now the upper array elements are
uninitialize
as and no
> address
>
> Gisle Vanem (2):
> Comment in ares_ipv6.h
> Support Visual Studio 2015
>
> Gregor Jasny (5):
> Null check before dereference
> Fix integer shift overflow if both tcp_socket and udp_socket are set
> Free temporary
Hello,
On 25/11/15 15:24, Gregor Jasny wrote:
> this is a reworked version of Yury Kirpichev's patch to add iOS support
> to cares. Compared to the former version the following has been added:
>
> * IPv6 name server now work properly. The ones ones in nsaddr_list have
>
t for a start.
Patch is attached and also in this PR:
https://github.com/bagder/c-ares/pull/29
Thanks,
Gregor
From 4e30c6ed3f9513c493729ed426f1a8885baf04fa Mon Sep 17 00:00:00 2001
From: Gregor Jasny
Date: Wed, 25 Nov 2015 15:03:26 +0100
Subject: [PATCH] Use libresolv to initialize cares on i
Hello,
On 05/12/14 14:19, David Drysdale wrote:
Well, an OSX build still seems to work with that patch, but I can't
comment about the iOS build. Anyone else able to look that over?
(Small nit btw -- there's trailing whitespace in the patch)
The patch works as expected on regular iOS. There a
Hello,
This works for me on master:
./configure CFLAGS=-m32
make -j4
$ sw_vers
ProductName: Mac OS X
ProductVersion: 10.10.1
BuildVersion: 14B25
$ xcodebuild -version
Xcode 6.1
Build version 6A1052d
Thanks,
Gregor
From: Vinay Kumar mailto:win_i...@yahoo.com>>
Reply-To: Vinay Kumar mailto:win_
Fix Coverity error CID 56882
Signed-off-by: Gregor Jasny
---
acountry.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/acountry.c b/acountry.c
index fae9f9f..1fe750c 100644
--- a/acountry.c
+++ b/acountry.c
@@ -200,7 +200,9 @@ static void wait_ares(ares_channel channel
Fix Coverity error CID 56880
Signed-off-by: Gregor Jasny
---
ares_options.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ares_options.c b/ares_options.c
index 76d82df..cf88433 100644
--- a/ares_options.c
+++ b/ares_options.c
@@ -158,6 +158,9 @@ int ares_set_servers_csv(ares_channel
this is the first batch of patches for errors reported by Coverity.
I addressed the review comments from David Drysdale.
Thanks,
Gregor
Gregor Jasny (5):
Null check before dereference
Fix integer shift overflow if both tcp_socket and udp_socket are set
Free temporary variable in error
Fix Coverity error CID 56886.
Signed-off-by: Gregor Jasny
---
ares_getnameinfo.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/ares_getnameinfo.c b/ares_getnameinfo.c
index 5b9f638..b0bc6da 100644
--- a/ares_getnameinfo.c
+++ b/ares_getnameinfo.c
increment of sockindex if it is still
valid.
Fix Coverity error CID 56878
Signed-off-by: Gregor Jasny
---
ares_getsock.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/ares_getsock.c b/ares_getsock.c
index 07d2854..22d3446 100644
--- a/ares_getsock.c
+++ b
Fix Coverity CID 56890
Signed-off-by: Gregor Jasny
---
acountry.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/acountry.c b/acountry.c
index 210ef84..fae9f9f 100644
--- a/acountry.c
+++ b/acountry.c
@@ -562,6 +562,7 @@ static void find_country_from_cname(const char *cname,
struct
Hi David,
Thank you for the review.
On 22/09/14 12:11, David Drysdale wrote:
> Thanks! The changes mostly look good to me; let's see if anyone else
> has comments
Should I send a pull request of will you merge from the mails?
Thanks,
Gregor
On 22/09/14 11:57, David Drysdale wrote:
> The code looks OK to me, but it might be easier to have an extra local
> variable (e.g. char *name) that is set to either sep->s_name or
> tmpbuf; that would reduce the code duplication. Maybe something like
> the following (untested)?
Good point. I'll s
safe than sorry.
>
> On Fri, Sep 19, 2014 at 7:51 PM, Gregor Jasny wrote:
>> Fix Coverity error CID 56878
>>
>> Signed-off-by: Gregor Jasny
>> ---
>> ares_getsock.c | 8 +++-
>> 1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --
Hello,
On 17/09/14 15:47, Jakub Hrozek wrote:
> On Wed, Sep 17, 2014 at 01:39:34PM +0000, Gregor Jasny wrote:
>> If you like I could set up a project and run a daily scan on my Debian
>> machine. I’m doing this some month for my v4l-utils package and it catched
>> many bugs
Hello,
I don't know if there are already some kind of CI-builds for c-ares in
place. I created a pull request to add a travis ci configuration file to
the c-ares tree.
https://github.com/bagder/c-ares/pull/23
Even if you decide to not use it for the official repository it might be
useful for con
Fix Coverity error CID 56880
Signed-off-by: Gregor Jasny
---
ares_options.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ares_options.c b/ares_options.c
index 76d82df..cf88433 100644
--- a/ares_options.c
+++ b/ares_options.c
@@ -158,6 +158,9 @@ int ares_set_servers_csv(ares_channel
Fix Coverity error CID 56886.
Signed-off-by: Gregor Jasny
---
ares_getnameinfo.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/ares_getnameinfo.c b/ares_getnameinfo.c
index 5b9f638..39337e7 100644
--- a/ares_getnameinfo.c
+++ b
Hello,
this is the first batch of patches for errors reported by Coverity.
Please review and apply.
Thanks,
Gregor
Gregor Jasny (5):
Null check before dereference
Fix integer shift overflow if both tcp_socket and udp_socket are set
Free temporary variable in error path
Re-start loop if
Fix Coverity error CID 56882
Signed-off-by: Gregor Jasny
---
acountry.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/acountry.c b/acountry.c
index fae9f9f..1fe750c 100644
--- a/acountry.c
+++ b/acountry.c
@@ -200,7 +200,9 @@ static void wait_ares(ares_channel channel
Fix Coverity error CID 56878
Signed-off-by: Gregor Jasny
---
ares_getsock.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/ares_getsock.c b/ares_getsock.c
index 07d2854..22d3446 100644
--- a/ares_getsock.c
+++ b/ares_getsock.c
@@ -30,9 +30,7 @@ int ares_getsock
Fix Coverity CID 56890
Signed-off-by: Gregor Jasny
---
acountry.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/acountry.c b/acountry.c
index 210ef84..fae9f9f 100644
--- a/acountry.c
+++ b/acountry.c
@@ -562,6 +562,7 @@ static void find_country_from_cname(const char *cname,
struct
Hello,
Coverity is a static code analyzer which provies a free scan service for Open
Source projects. I looked for c-ares in the project list at [1] but did not
found it.
If you like I could set up a project and run a daily scan on my Debian machine.
I’m doing this some month for my v4l-utils
Hello
On 8/26/13 4:43 PM, "Markus Rothe" wrote:
>I have a problem using c-ares in a multilib environment, for which I
>found a patch in Fedora that does not seem to have found its way
>upstream.
In Debian I just installed the ares_build.h header into the arch-specific
include path:
/usr/includ
Hello,
Recently I received a bug report about errors in the c-ares package
description.
It seems it was copied from the c-ares homepage, so you might want to
correct it there, too.
http://lists.debian.org/debian-l10n-english/2012/11/msg8.html
Thanks,
Gregor
--
Gregor Jasny
Senior Software
Hello,
I noticed that if I do a regular configure any CFLAGS related to
generating debug output are scrubbed and replaced by g0. If I set
‹enable-debug the optimization level drops from 2 to 0.
Is there a way to get g and O2?
Thanks,
Gregor
--
Gregor Jasny
Senior Software Developer
Citrix
Hello Daniel,
On 6/18/12 10:31 PM, "Daniel Stenberg" wrote:
>On Mon, 18 Jun 2012, Gregor Jasny wrote:
>
>> During Debian packaging I noticed the absence of a new symbol. It seems
>>the
>> tarball lacks the new file and the build system does not complain or
>
reply
During Debian packaging I noticed the absence of a new symbol.
It seems the tarball lacks the new file and the build system does not
complain or was not re-generated.
Thanks,
Gregor
--
Gregor Jasny
Senior Software Developer
Citrix Online Services Division
T: +49 351 49775 018 | F: +49 351 49
Hi,
On Thu, 10 Jun 2010, Jérémy Lal wrote:
> Could you check again the content of the release tarball ? Some files are
> missing !
Like ares_parse_mx_reply.c.
The function got added to ares.h but I cannot find it in the sources.
Thanks,
Gregor
On 3/25/10 1:18 PM, Daniel Stenberg wrote:
On Thu, 25 Mar 2010, Peter Pentchev wrote:
What do you think about the following patch that fixes a couple of
typos and grammar nits in several files?
There is another one spotted by lintian:
libc-ares-dev: spelling-error-in-manpage
usr/share/man/ma
Yang Tse wrote:
2009/6/9, Gregor Jasny wrote:
[...] I'll prepare a visibility patch within the next days for the GCC compiler.
That's very nice.
I'd like to go the following way:
* Check during configure if gcc-visibility is available.
* If yes, add -fvisibility=hidden
Yang Tse wrote:
2009/6/9, Gregor Jasny wrote:
Yang Tse wrote:
The -export-symbols-regex libtool option was introduced in libtool in
1999, now ten years later it certainly still misbehaves on solaris
systems using the solaris linker creating unusable shared libraries.
Do you have some
Yang Tse wrote:
The -export-symbols-regex libtool option was introduced in libtool in
1999, now ten years later it certainly still misbehaves on solaris
systems using the solaris linker creating unusable shared libraries.
Do you have some pointers to e.g. bug reports?
If this is the case with
Hi,
during Debian packaging of 1.6.0 I noticed that the shared library
exports public and private symbols. The attached patch uses libtool to
export only symbols named '^ares_[[:alnum:]].*'. At least adig, acountry
and ahost are still working.
Please apply the patch to HEAD, so that I can pr
Hi,
I've found some time to look at the IPv6 servers patch.
On Wed, Jan 14, 2009 at 02:23:01PM +0100, Daniel Stenberg wrote:
> On Thu, 18 Dec 2008, Gregor Jasny wrote:
> It struck me that the API for ares_get_servers() is not really solid. How
> would a user free the list of ser
Daniel Stenberg wrote:
Hey, here's my update of your patch from current CVS HEAD.
It struck me that the API for ares_get_servers() is not really solid. How
would a user free the list of servers again? We can't assume that free() is
fine on memory returned from c-ares.
Would it perhaps make sens
On Tue, Dec 16, 2008 at 11:51:25PM +0100, Daniel Stenberg wrote:
> On Mon, 15 Dec 2008, Gregor Jasny wrote:
> I would claim that setting an empty servers list should simply make the list
> in the handle empty: no servers available to use. IMO, the
> ares_set_servers()
> overrides
SOCKET_CALLBACK 3 "14 Dec 2008"
+.SH NAME
+ares_get_servers, ares_set_servers \- Get or set alternative servers to contact
+.SH SYNOPSIS
+.nf
+int ares_get_servers(ares_channel \fIchannel\fP,
+ struct ares_addr ** \fIservers\fP,
+ int * \fInservers\fP)
+int ares_set_servers(ares_channel \fIchannel\fP,
+ const struct ares_addr * \fIservers\fP,
+ int \fInservers\fP)
+.fi
+.SH DESCRIPTION
+\fIares_set_servers\fP sets a list of alternative servers to contact.
+Each name server address could be an IPv4 or IPv6 host.
+
+\fIares_get_servers\fP gets the configured name servers list. It allocates
+the required space by itself and sets \fInservers\fP accordingly.
+
+This two function obsoletes the \fIARES_OPT_SERVERS\fP option.
+.SH SEE ALSO
+.BR ares_init_options (3)
+.SH AVAILABILITY
+ares_get_servers(3) was added in c-ares 1.6.1
+ares_set_servers(3) was added in c-ares 1.6.1
+.SH AUTHOR
+Gregor Jasny
+
On Mon, Dec 08, 2008 at 01:39:15AM +0100, wrote:
> It's too late in the night now, an I won't have time before thursday, so
> I've attached my curent version.
Attached now :)
Index: adig.c
===
RCS file: /cvsroot/curl/curl/ares/adig.c
On Thu, Dec 04, 2008 at 01:52:10PM +0100, Daniel Stenberg wrote:
> This was just now committed with my two extensions:
Thanks!
> I want to put together and ship a 1.6.0 release soonish, so please let me
> know
> asap if you have anything you want fixed before that. Otherwise I'll work on
> putt
Hi,
For one of my c-ares changeset, I need to write a manual page. I've
noticed that all the manpages are written in directly in roff. Have you
ever considered using docbook/sgml for authoring and convert it to
roff at install time?
I'd volunteer converting the existing manpages to the new
Yang Tse wrote:
Now, let's imagine that someone has used ares_setopt() to setup a
couple of IPv6 nameservers. This information cannot be stored in a
variable of the existing ares_options struct, so somehow it will be
kept 'somewhere' before doing some sort of, some other new public
functions, are
On Thu, Nov 27, 2008 at 12:32:31PM +0100, Gregor Jasny wrote:
> Daniel Stenberg wrote:
> > * I would like to have the callback able to fail the operation by
> > returning an error code
> >
> > * I would like the callback to work on both UDP and TCP sockets
> >
&
Daniel Stenberg wrote:
On Thu, 27 Nov 2008, Gregor Jasny wrote:
2. AfterSocketCreationFuncPtr
We have something similar in libcurl too, as it allows for applications
to set
socket options or whatever that is specific to the surroundings or
requirements of the app.
However, I think the
(CCing Brad Spencer who initiated the transition)
Yang Tse wrote:
Are there any more patches pending for the reSIProcate transition from
ares to c-ares?
Starting from Brads email [1] there are two 'features' left:
1. TryServersOfNextNetworkUponRcode3
This seems to be a feature to help client
On Wed, Nov 26, 2008 at 08:29:01PM +0100, Yang Tse wrote:
> Attached is the patch, relative to current CVS, which would be
> committed to initially support using ipV6 servers. Its basically your
> work, with some minor adjustments.
>
> Please verify that it works as intended, or if something else
On Wed, Nov 26, 2008 at 11:48:49PM +0100, Gregor Jasny wrote:
> On Wed, Nov 26, 2008 at 09:26:03PM +, Phil Blundell wrote:
> > On Wed, 2008-11-26 at 20:29 +0100, Yang Tse wrote:
> > > As you have already mentioned it breaks ABI compatibility due to the
> > > change
On Wed, Nov 26, 2008 at 09:26:03PM +, Phil Blundell wrote:
> On Wed, 2008-11-26 at 20:29 +0100, Yang Tse wrote:
> > As you have already mentioned it breaks ABI compatibility due to the
> > change it introduces in one of the ares_options structure member. Yes
> > the affected member is the 'serv
Daniel Stenberg wrote:
On Wed, 26 Nov 2008, Gerald Combs wrote:
Thanks! Is there any estimate on the next release?
We tend to do releases on demand, when we think we have something
particular
that's enough to warrant one. You think we have enough reasons to make one?
I'd be happy if you c
On Mon, Nov 24, 2008 at 04:02:29PM +0100, Yang Tse wrote:
> > The reSIProcate developers substituted the in_addr field by an union
> > contruct to hold the in6_addr. As this would break API compatibility, I
> > have added a second nservers and servers field and suffixed it with a '6'.
>
> For c-ar
Hello,
Here comes another feature patch for the reSIProcate transition from
ares to c-ares. The embedded copy supports querying IPv6 nameservers and
setting these up via the options structure.
The reSIProcate developers substituted the in_addr field by an union
contruct to hold the in6_addr. As
66 matches
Mail list logo
