On Wed, Nov 25, 2015 at 10:16 AM, Daniel Stenberg wrote:
> On Wed, 25 Nov 2015, David Drysdale wrote:
>
>> - Fix double-free from ares__read_line() failure case
>> https://github.com/daviddrysdale/c-ares/commit/d91d731636f5
>
>
> +1
>
>> - Extend the injection of malloc/free to cover realloc too:
On Wed, 25 Nov 2015, David Drysdale wrote:
- Fix double-free from ares__read_line() failure case
https://github.com/daviddrysdale/c-ares/commit/d91d731636f5
+1
- Extend the injection of malloc/free to cover realloc too:
https://github.com/daviddrysdale/c-ares/commit/492a1cc5e4fa
This modif
On Thu, 22 Oct 2015, David Drysdale wrote:
By the way, I should observe that so far I've only seen one thing that might
count as a bug, even running with sanitizers/fuzzers etc -- so kudos for the
quality of the code!
Cool!
That one thing is in this change:
https://github.com/daviddrysdale
On Fri, 9 Oct 2015, David Drysdale wrote:
I've made a start on a unit test suite for c-ares, and I'd be interested in
any feedback.
In one word? AWESOME.
I'm not a big C++ guy myself so I'm not overly thrilled with that choice, but
I'm also much more *for* progress
On Fri, Oct 09, 2015 at 01:36:20PM +0100, David Drysdale wrote:
> On Fri, Oct 9, 2015 at 12:22 PM, Jakub Hrozek wrote:
> > On Fri, Oct 09, 2015 at 11:14:30AM +0100, David Drysdale wrote:
> >> Hi folks,
> >>
> >> I've made a start on a unit test suite for
On Fri, Oct 09, 2015 at 11:14:30AM +0100, David Drysdale wrote:
> Hi folks,
>
> I've made a start on a unit test suite for c-ares, and I'd be
> interested in any feedback.
>
> The changes so far are in a branch at
> https://github.com/daviddrysdale/c-ares/commi
Hi folks,
I've made a start on a unit test suite for c-ares, and I'd be
interested in any feedback.
The changes so far are in a branch at
https://github.com/daviddrysdale/c-ares/commits/test, with some key
points being:
- The tests are in C++11 (mostly so I can use gTest/gMock, usi
