iguessthislldo opened a new pull request, #49:
URL: https://github.com/apache/xerces-c/pull/49
Fixes https://issues.apache.org/jira/browse/XERCESC-2236, where trying to
use the generated CMake config package doesn't work because the dependencies
are not loaded using `find_package` in the co
Biswa96 opened a new pull request, #50:
URL: https://github.com/apache/xerces-c/pull/50
This fixes the following linking error:
```
ld.exe: ../src/.libs/libxerces-c.a(CurlURLInputStream.o): in function
'xercesc_4_0::CurlURLInputStream::readMore(int*)':
src/xercesc/util/NetAccess
scantor commented on PR #50:
URL: https://github.com/apache/xerces-c/pull/50#issuecomment-1142026862
To report issues or submit patches, please use the proper channel, see
https://issues.apache.org/jira/
--
This is an automated message from the Apache Git Service.
To respond to the messag
rouault opened a new pull request, #51:
URL: https://github.com/apache/xerces-c/pull/51
On .xsd files like the following ones (generated by ossfuzz, so broken),
integer overflows can happen in DFAContentModel::countLeafNodes() and
DFAContentModel::buildDFA() which can later cause out-of-bou
rouault commented on PR #51:
URL: https://github.com/apache/xerces-c/pull/51#issuecomment-1265749924
CC @rleigh-codelibre This should be relatively safe to apply
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rouault commented on code in PR #51:
URL: https://github.com/apache/xerces-c/pull/51#discussion_r986039665
##
src/xercesc/validators/common/DFAContentModel.cpp:
##
@@ -661,8 +662,15 @@ void DFAContentModel::buildDFA(ContentSpecNode* const
curNode)
// in the fLeafCount mem
rleigh-codelibre commented on code in PR #51:
URL: https://github.com/apache/xerces-c/pull/51#discussion_r986030234
##
src/xercesc/validators/common/DFAContentModel.cpp:
##
@@ -661,8 +662,15 @@ void DFAContentModel::buildDFA(ContentSpecNode* const
curNode)
// in the fLeaf
rleigh-codelibre commented on code in PR #51:
URL: https://github.com/apache/xerces-c/pull/51#discussion_r986046406
##
src/xercesc/validators/common/DFAContentModel.cpp:
##
@@ -661,8 +662,15 @@ void DFAContentModel::buildDFA(ContentSpecNode* const
curNode)
// in the fLeaf
rouault commented on code in PR #51:
URL: https://github.com/apache/xerces-c/pull/51#discussion_r986050269
##
src/xercesc/validators/common/DFAContentModel.cpp:
##
@@ -661,8 +662,15 @@ void DFAContentModel::buildDFA(ContentSpecNode* const
curNode)
// in the fLeafCount mem
rleigh-codelibre commented on PR #31:
URL: https://github.com/apache/xerces-c/pull/31#issuecomment-1268948199
I thought MSVC linked by name rather than by ordinal when you used
`__declspec`? We aren't manually assigning ordinals in a `.def` file, we're
linking by name, and the ordinals are
scantor commented on PR #31:
URL: https://github.com/apache/xerces-c/pull/31#issuecomment-1268955305
It *links* by name but I believe after that point the connection from the
calling code to the DLL is by ordinal. But I could also be wrong, and I have
someone I can ask. I don't think it's r
rleigh-codelibre commented on PR #31:
URL: https://github.com/apache/xerces-c/pull/31#issuecomment-1268971222
Some searching around shows some examples where the ordinals in core Windows
DLLs have changed, but it's not broken anything. This would break on any
symbol addition of any sort ex
scantor commented on PR #31:
URL: https://github.com/apache/xerces-c/pull/31#issuecomment-1268975788
Indeed, I fully believed that just about any change was inherently unsafe
because of that, but I must be mistaken.
--
This is an automated message from the Apache Git Service.
To respond t
scantor commented on PR #44:
URL: https://github.com/apache/xerces-c/pull/44#issuecomment-1269963838
Given that this is just fixing a memory leak in a case where the process is
going to die anyway, I'm inclined to leave it out of the branch and this patch
release. That's not a good enough r
scantor commented on PR #51:
URL: https://github.com/apache/xerces-c/pull/51#issuecomment-1269982071
@rleigh-codelibre If you can apply this to master that will make it easier
for me to cherry-pick back to the branch.
--
This is an automated message from the Apache Git Service.
To respon
scantor commented on PR #51:
URL: https://github.com/apache/xerces-c/pull/51#issuecomment-1269983028
(My only concern re: compatibility was the reference to size_it in the max
function possibly causing compatibility issues, but I'll take the risk.)
--
This is an automated message from the
scantor commented on PR #51:
URL: https://github.com/apache/xerces-c/pull/51#issuecomment-1273514080
I applied this to both branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
201 - 217 of 217 matches
Mail list logo