[ http://issues.apache.org/jira/browse/XERCESC-1579?page=comments#action_12371046 ]
Boris Kolpackov commented on XERCESC-1579: ------------------------------------------ It's somewhat un-intuitive that XMLReaderFactory::createXMLReader is defined in SAX2XMLReaderImpl.cpp but otherwise looks good. Thanks for fixing this! > sax2/XMLReaderFactory.hpp includes too much stuff > ------------------------------------------------- > > Key: XERCESC-1579 > URL: http://issues.apache.org/jira/browse/XERCESC-1579 > Project: Xerces-C++ > Type: Bug > Components: SAX/SAX2 > Versions: 2.7.0 > Environment: all > Reporter: Boris Kolpackov > > I was trying to get rid of a warning in Xerces-C++ that annoys > me in my code. I noticed that the place where the warning points > to is completely unrelated to what I do and I figured I must have > included some extra headers that I don't really need. Upon closer > examination it appears that the culprit is sax2/XMLReaderFactory.hpp. > The problem with the code in this file is that in order to inline > the createXMLReader function it has to include > parsers/SAX2XMLReaderImpl.hpp which in turn pulls in a lot of other > headers (like PSVI types, etc). This seems a lot more than I asked > for especially since createXMLReader returns the interface > (SAX2XMLReader), not the implementation (SAX2XMLReaderImpl). I don't > think there is any benefit in inlining createXMLReader while the > drawback is a much longer build times for client code. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
