Re: patch applied (cabal): First pass at parsing .cabal files as UTF8

2008-02-25 Thread Don Stewart
igloo: > On Mon, Feb 25, 2008 at 01:26:52PM -0800, Donald Bruce Stewart wrote: > > duncan.coutts: > > > > > > It's no use pretending that readFile returns Unicode, it just doesn't > > > (except on Hugs which does it properly). GHC is not going to catch up on > > > this any time soon. > > > > Why

Re: patch applied (cabal): First pass at parsing .cabal files as UTF8

2008-02-25 Thread Ian Lynagh
On Mon, Feb 25, 2008 at 01:26:52PM -0800, Donald Bruce Stewart wrote: > duncan.coutts: > > > > It's no use pretending that readFile returns Unicode, it just doesn't > > (except on Hugs which does it properly). GHC is not going to catch up on > > this any time soon. > > Why don't we use the existi

Re: patch applied (cabal): First pass at parsing .cabal files as UTF8

2008-02-25 Thread Ian Lynagh
On Mon, Feb 25, 2008 at 09:11:50PM +, Duncan Coutts wrote: > > On Mon, 2008-02-25 at 11:41 +, Ross Paterson wrote: > > > I don't follow you there. There's a copy of the .cabal file inside the > > tarball, which you say you're not changing, but it is the tarball that > > people will downl

Re: patch applied (cabal): First pass at parsing .cabal files as UTF8

2008-02-25 Thread Ross Paterson
On Mon, Feb 25, 2008 at 09:07:08PM +, Duncan Coutts wrote: > It's no use pretending that readFile returns Unicode, it just doesn't > (except on Hugs which does it properly). GHC is not going to catch up on > this any time soon. On the contrary, it's the only way to stay sane. readFile does re

Re: patch applied (cabal): First pass at parsing .cabal files as UTF8

2008-02-25 Thread Don Stewart
duncan.coutts: > > On Mon, 2008-02-25 at 11:53 +, Ross Paterson wrote: > > On Sun, Feb 24, 2008 at 05:46:35PM +, Duncan Coutts wrote: > > > I've added readTextFile and writeTextFile to the Utils module and > > > checked all other uses of readFile and writeFile. > > > > > > I've also switc

Re: patch applied (cabal): First pass at parsing .cabal files as UTF8

2008-02-25 Thread Duncan Coutts
On Mon, 2008-02-25 at 11:41 +, Ross Paterson wrote: > I don't follow you there. There's a copy of the .cabal file inside the > tarball, which you say you're not changing, but it is the tarball that > people will download and build. True, however when planning what to install, cabal-install

Re: patch applied (cabal): First pass at parsing .cabal files as UTF8

2008-02-25 Thread Duncan Coutts
On Mon, 2008-02-25 at 11:53 +, Ross Paterson wrote: > On Sun, Feb 24, 2008 at 05:46:35PM +, Duncan Coutts wrote: > > I've added readTextFile and writeTextFile to the Utils module and > > checked all other uses of readFile and writeFile. > > > > I've also switched the rawSystemStdout to as

Re: [Hackage] #247: Needless license warning on PublicDomain

2008-02-25 Thread Hackage
#247: Needless license warning on PublicDomain +--- Reporter: guest |Owner: Type: defect | Status: closed Priority: low|Milestone: Component: Cab

patch applied (cabal): GHC's package db files are actually ascii, not UTF8

2008-02-25 Thread Duncan Coutts
Mon Feb 25 05:32:55 PST 2008 Duncan Coutts <[EMAIL PROTECTED]> * GHC's package db files are actually ascii, not UTF8 Because they're in Haskell Read/Show format which escapes non-ascii chars in Strings. M ./Distribution/Simple/GHC.hs -1 +1 M ./Distribution/Simple/Utils.hs +8 View p

patch applied (cabal): Check for invalid UTF8 when parsing .cabal files

2008-02-25 Thread Duncan Coutts
Mon Feb 25 05:28:24 PST 2008 Duncan Coutts <[EMAIL PROTECTED]> * Check for invalid UTF8 when parsing .cabal files This assumes a permissive UTF8 decoder has inserted '\xfffd' as a replacement character. We should check strictly for errors when we decode instead, though it's nice to do that

patch applied (cabal): Don't include the version number in the xsl-stylesheets path

2008-02-25 Thread Duncan Coutts
Mon Feb 25 05:18:38 PST 2008 Duncan Coutts <[EMAIL PROTECTED]> * Don't include the version number in the xsl-stylesheets path This is still shockingly platform dependent. Sigh. M ./Makefile -1 +1 View patch online: http://darcs.haskell.org/cabal/_darcs/patches/20080225131838-adfee-4b

patch applied (cabal): Specify in the user guide that .cabal files must be valid UTF-8

2008-02-25 Thread Duncan Coutts
Mon Feb 25 05:17:56 PST 2008 Duncan Coutts <[EMAIL PROTECTED]> * Specify in the user guide that .cabal files must be valid UTF-8 M ./doc/Cabal.xml -4 +5 View patch online: http://darcs.haskell.org/cabal/_darcs/patches/20080225131756-adfee-37c53192cea22bdd7631fedcc90ff4554eb72515.gz __

patch applied (cabal): Don't warn about missing license file for public domain packages

2008-02-25 Thread Duncan Coutts
Mon Feb 25 05:02:28 PST 2008 Duncan Coutts <[EMAIL PROTECTED]> * Don't warn about missing license file for public domain packages Fixes ticket #247. The whole concept of public domain as a license is also rather dodgy. In many legal jurisdictions it has no legal meaning and where it does o

patch applied (cabal-install): Read package descriptions from the index as UTF8

2008-02-25 Thread Duncan Coutts
Mon Feb 25 05:33:57 PST 2008 Duncan Coutts <[EMAIL PROTECTED]> * Read package descriptions from the index as UTF8 M ./Hackage/IndexUtils.hs -2 +3 View patch online: http://darcs.haskell.org/cabal-install/_darcs/patches/20080225133357-adfee-26fcef97e3b4aa5179bc080233614d803828b64b.gz _

Re: patch applied (cabal): First pass at parsing .cabal files as UTF8

2008-02-25 Thread Ross Paterson
On Sun, Feb 24, 2008 at 05:46:35PM +, Duncan Coutts wrote: > I've added readTextFile and writeTextFile to the Utils module and > checked all other uses of readFile and writeFile. > > I've also switched the rawSystemStdout to assume UTF8 output format. The read and write functions ought to ope

Re: patch applied (cabal): First pass at parsing .cabal files as UTF8

2008-02-25 Thread Ross Paterson
On Mon, Feb 25, 2008 at 09:35:58AM +, Duncan Coutts wrote: > On Mon, 2008-02-25 at 00:52 +, Ross Paterson wrote: > > The tags stuff was just a quick hack, but in general my preference is > > to keep the additional data outside of the package, so that what one > > downloads under a particula

patch applied (cabal): help nhc98 by hinting an import decl

2008-02-25 Thread Malcolm Wallace
Mon Feb 25 02:24:50 PST 2008 [EMAIL PROTECTED] * help nhc98 by hinting an import decl M ./Distribution/Simple/Utils.hs -1 +1 View patch online: http://darcs.haskell.org/cabal/_darcs/patches/20080225102450-6871e-dfbbeccbb0f375573a7e5efebb9bb1f01a5661f8.gz __

Re: patch applied (cabal): First pass at parsing .cabal files as UTF8

2008-02-25 Thread Duncan Coutts
On Mon, 2008-02-25 at 00:52 +, Ross Paterson wrote: > The tags stuff was just a quick hack, but in general my preference is > to keep the additional data outside of the package, so that what one > downloads under a particular package-id is always what was uploaded. I rather like the idea of