Re: [Hackage] #233: case of Boolean values "true" and "false" should not matter

2008-03-27 Thread Hackage
#233: case of Boolean values "true" and "false" should not matter +--- Reporter: guest |Owner: Type: defect | Status: closed Priority: normal |Milestone:

patch applied (cabal): Tweak warning message about bool fields to include the field name

2008-03-27 Thread Duncan Coutts
Thu Mar 27 18:20:06 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Tweak warning message about bool fields to include the field name Warning: The 'buildable' field is case sensitive, use 'True' or 'False'. M ./Distribution/ParseUtils.hs -2 +2 View patch online: http://darcs.haskell.org

patch applied (cabal): Simplify the parser for flags in conditions

2008-03-27 Thread Duncan Coutts
Thu Mar 27 15:16:32 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Simplify the parser for flags in conditions It's a bit more consistent. M ./Distribution/PackageDescription/Configuration.hs -6 +5 View patch online: http://darcs.haskell.org/cabal/_darcs/patches/20080327221632-adfee-42

patch applied (cabal): We do not show the field value on a parse error so don't pretend we do.

2008-03-27 Thread Duncan Coutts
Thu Mar 27 15:14:42 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * We do not show the field value on a parse error so don't pretend we do. Drop the trailing ": " on the error message. We could provide the field value but they're often multi-line and we cannot pin-point where the error is exa

patch applied (cabal): Use the Text Bool instance for parsing literals in conditions

2008-03-27 Thread Duncan Coutts
Thu Mar 27 14:55:01 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Use the Text Bool instance for parsing literals in conditions Since it exactly matches what the previous condition parser did. So we have two different ways of parsing Bool depending on context. Sigh. Both match exactly what

patch applied (cabal): Parse Bool fields using more cunning, allow new parses with a warning

2008-03-27 Thread Duncan Coutts
Thu Mar 27 14:34:11 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Parse Bool fields using more cunning, allow new parses with a warning We want to allow case-insensitive parsing however we don't want packages being uploaded to hackage that will break older versions of Cabal. If we allow new

Re: [Hackage] #233: case of Boolean values "true" and "false" should not matter

2008-03-27 Thread Hackage
#233: case of Boolean values "true" and "false" should not matter +--- Reporter: guest |Owner: Type: defect | Status: reopened Priority: normal |Milestone:

Re: patch applied (cabal): Make UTF-8 decoding errors in .cabal files non-fatal

2008-03-27 Thread Duncan Coutts
In message <[EMAIL PROTECTED]> cabal-devel@haskell.org writes: > On Thu, Mar 27, 2008 at 04:39:17PM +, Duncan Coutts wrote: > > Can't we just reject them with the error message and ask people to fix the > > latin-1 sequences and re-upload using proper UTF-8? > > The problem is that there are p

Re: [Hackage] #233: case of Boolean values "true" and "false" should not matter

2008-03-27 Thread Hackage
#233: case of Boolean values "true" and "false" should not matter +--- Reporter: guest |Owner: Type: defect | Status: reopened Priority: normal |Milestone:

patch applied (cabal): Add scripts for testing compatability with hackage packages

2008-03-27 Thread Duncan Coutts
Thu Mar 27 09:15:40 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Add scripts for testing compatability with hackage packages So far just a test that all the non-trivial Setup.(l)hs scripts compile. This only tests the latest versions, though if one were to download a complete archive then

Re: [Hackage] #233: case of Boolean values "true" and "false" should not matter

2008-03-27 Thread Hackage
#233: case of Boolean values "true" and "false" should not matter +--- Reporter: guest |Owner: Type: defect | Status: reopened Priority: normal |Milestone:

Re: patch applied (cabal): Make UTF-8 decoding errors in .cabal files non-fatal

2008-03-27 Thread Ross Paterson
On Thu, Mar 27, 2008 at 04:39:17PM +, Duncan Coutts wrote: > Can't we just reject them with the error message and ask people to fix the > latin-1 sequences and re-upload using proper UTF-8? The problem is that there are packages there now with .cabal files assuming Latin-1. Stopping more of t

Re: [Hackage] #233: case of Boolean values "true" and "false" should not matter

2008-03-27 Thread Thomas Schilling
On 27 mar 2008, at 18.11, Hackage wrote: #233: case of Boolean values "true" and "false" should not matter +--- Reporter: guest |Owner: Type: defect | Status: reopened Priority

Re: [Hackage] #233: case of Boolean values "true" and "false" should not matter

2008-03-27 Thread Hackage
#233: case of Boolean values "true" and "false" should not matter +--- Reporter: guest |Owner: Type: defect | Status: reopened Priority: normal |Milestone:

Re: patch applied (cabal): Make UTF-8 decoding errors in .cabal files non-fatal

2008-03-27 Thread Duncan Coutts
In message <[EMAIL PROTECTED]> cabal-devel@haskell.org writes: > On Thu, Mar 27, 2008 at 08:45:29AM -0700, Duncan Coutts wrote: > > Wed Mar 26 20:17:40 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> > > * Make UTF-8 decoding errors in .cabal files non-fatal > > Previously we checked for invalid UT

Re: patch applied (cabal): Make UTF-8 decoding errors in .cabal files non-fatal

2008-03-27 Thread Ross Paterson
On Thu, Mar 27, 2008 at 08:45:29AM -0700, Duncan Coutts wrote: > Wed Mar 26 20:17:40 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> > * Make UTF-8 decoding errors in .cabal files non-fatal > Previously we checked for invalid UTF-8 in the first phase of the > parser, which splitting the file up i

patch applied (cabal-branches/cabal-1.4): Fix merge mistake, remove duplicate record field definition

2008-03-27 Thread Duncan Coutts
Wed Mar 26 21:45:51 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Fix merge mistake, remove duplicate record field definition M ./Distribution/Simple/Setup.hs -1 View patch online: http://darcs.haskell.org/cabal-branches/cabal-1.4/_darcs/patches/20080327044551-adfee-cd6b4415b937453a382c

patch applied (cabal-branches/cabal-1.4): Apply the same renaming trick to the copyDest flag

2008-03-27 Thread Duncan Coutts
Wed Mar 26 21:33:37 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Apply the same renaming trick to the copyDest flag Rename the real field to copyDest' and add copyDest with the same type as it had in Cabal-1.2. Use the Monoid's mappend again to keep the flag updated. M ./Distribution/

patch applied (cabal-branches/cabal-1.4): Add *Verbose flags back in with the old type

2008-03-27 Thread Duncan Coutts
Wed Mar 26 21:24:46 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Add *Verbose flags back in with the old type Abuse the Monoid instances for the flags types to keep the extra non-Flag type field up-to-date wrt the real Flag Verbosity field. Here's the pattern: copyVerbose = fromFlagOrD

patch applied (cabal-branches/cabal-1.4): Go back to conditionally using Text.ParserCombinators.ReadP

2008-03-27 Thread Duncan Coutts
Wed Mar 26 21:15:52 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Go back to conditionally using Text.ParserCombinators.ReadP Some Setup.hs scripts import Text.ParserCombinators.ReadP directly and try to use it with the parsers defined by Cabal. M ./Distribution/Compat/ReadP.hs +13 View

patch applied (cabal-branches/cabal-1.4): Rename various *Verbose fields to *Verbosity instead

2008-03-27 Thread Duncan Coutts
Wed Mar 26 20:48:15 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Rename various *Verbose fields to *Verbosity instead Despite appearances this is actually not completely pointless. For the Cabal-1.4 branch we need the *Verbose fields to have the same types as they did in Cabal-1.2, becuase

patch applied (cabal-branches/cabal-1.4): Add in a few small functions that some Setup.hs scripts use

2008-03-27 Thread Duncan Coutts
Wed Mar 26 21:10:49 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Add in a few small functions that some Setup.hs scripts use All marked as deprecated so hopefully people will stop using them. M ./Distribution/Package.hs -1 +11 M ./Distribution/PackageDescription.hs -2 +14 M ./Dist

patch applied (cabal-branches/cabal-1.4): Make UTF-8 decoding errors in .cabal files non-fatal

2008-03-27 Thread Duncan Coutts
Wed Mar 26 20:17:40 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Make UTF-8 decoding errors in .cabal files non-fatal Previously we checked for invalid UTF-8 in the first phase of the parser, which splitting the file up into nested sections and fields. This meant the whole parser falls ove

patch applied (cabal-branches/cabal-1.4): Separate the OS/Arch classifiation used for different purposes

2008-03-27 Thread Duncan Coutts
Wed Mar 26 17:53:21 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Separate the OS/Arch classifiation used for different purposes We have to classify System.Info.{os,arch} strings into the OS and Arch enums. For that purpose we have to be quite permissive since there are lots of ailases that

patch applied (cabal-branches/cabal-1.4): Arch and OS names were previously allowed to contain "_-", restore that.

2008-03-27 Thread Duncan Coutts
Wed Mar 26 17:46:31 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Arch and OS names were previously allowed to contain "_-", restore that. That is the arch and os strings in conditionals in .cabal files, like: if arch(x86_64) Previously the parser used isAlphaNum c || (c `elem` "_-"). Thi

patch applied (cabal-branches/cabal-1.4): allow underscores in arch names

2008-03-27 Thread Duncan Coutts
Wed Mar 26 09:59:12 PDT 2008 Ross Paterson <[EMAIL PROTECTED]> * allow underscores in arch names Stops it barfing on arch(x86_64). M ./Distribution/System.hs -1 +2 View patch online: http://darcs.haskell.org/cabal-branches/cabal-1.4/_darcs/patches/20080326165912-b47d3-08d7ea8f4e6c

patch applied (cabal-install): Update to recent Cabal lib changes

2008-03-27 Thread Duncan Coutts
Wed Mar 26 22:34:54 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Update to recent Cabal lib changes M ./Hackage/Config.hs -3 +4 M ./Hackage/Setup.hs -6 +7 M ./Hackage/SrcDist.hs -1 +1 M ./Main.hs -4 +4 View patch online: http://darcs.haskell.org/cabal-install/_darcs/patches

patch applied (cabal): Rename various *Verbose fields to *Verbosity instead

2008-03-27 Thread Duncan Coutts
Wed Mar 26 20:48:15 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Rename various *Verbose fields to *Verbosity instead Despite appearances this is actually not completely pointless. For the Cabal-1.4 branch we need the *Verbose fields to have the same types as they did in Cabal-1.2, becuase

patch applied (cabal): Make UTF-8 decoding errors in .cabal files non-fatal

2008-03-27 Thread Duncan Coutts
Wed Mar 26 20:17:40 PDT 2008 Duncan Coutts <[EMAIL PROTECTED]> * Make UTF-8 decoding errors in .cabal files non-fatal Previously we checked for invalid UTF-8 in the first phase of the parser, which splitting the file up into nested sections and fields. This meant the whole parser falls ove