Re: Code Review in Cabal Project

2023-05-08 Thread Artem Pelenitsyn
Mikolaj writes on IRC w.r.t. moving the meeting to the coming Thursday: > yes, that sounds fine, the only problem being that I can't edit the calendar invitation; I think Emily either can or should know who can

Re: Code Review in Cabal Project

2023-05-07 Thread Artem Pelenitsyn
Hey Emily, Thank you for your perspective. Also, > I have a standup now at exactly that time. If we offset by a week, I'd be able to make all of them. I'd be down to shift one week forward/backward. Last meeting was particularly long (longer than an hour), with a guest speaker on Manual QA and12

Re: Code Review in Cabal Project

2023-05-04 Thread Emily Pillmore
Just to pile on, I read the conversation and thank you Francesco for giving complete and meaningful feedback instead of throwing in the towel on such a large PR. I don't think there's any general means of making sure that contributors have a smooth contribution experience, but in this case, one

Re: Code Review in Cabal Project

2023-05-04 Thread Theophile Hécate Choutri via cabal-devel
Hi Artem, and thank you for the email. Yes, thank you very much Francesco, the feedback you left certainly avoided a lot of pain, and you contributed to maintain this patch up to standards. Regarding the "why" and the "how not to reproduce this", interactions that leave a sour taste in the mouth

Code Review in Cabal Project

2023-05-04 Thread Artem Pelenitsyn
Dear Cabal team, I have a couple points on the multiple components PR (https://github.com/haskell/cabal/pull/8726) drama. I didn't want to spend everyone's time during the meeting, and you can decide if you want to hear more about it now. The whole discussion on the meeting (with one exception) s