Re: darcs patch: Pass additional parameters in generated shell scripts

2010-05-16 Thread Matthias Kilian
On Sun, May 16, 2010 at 09:10:32PM +0100, Ross Paterson wrote: > On Sun, May 16, 2010 at 08:30:25PM +0100, Ian Lynagh wrote: > > On Sun, May 16, 2010 at 08:17:26PM +0200, Matthias Kilian wrote: > > > > > > - ++ quote path ++ concatMap (\arg -> ' ':quote arg) args ] > > > + ++ unwor

Re: darcs patch: Pass additional parameters in generated shell scripts

2010-05-16 Thread Ross Paterson
On Sun, May 16, 2010 at 08:30:25PM +0100, Ian Lynagh wrote: > On Sun, May 16, 2010 at 08:17:26PM +0200, Matthias Kilian wrote: > > > > - ++ quote path ++ concatMap (\arg -> ' ':quote arg) args ] > > + ++ unwords (map quote $ path : args) ++ " \"$...@\""] > > This looks liks it oug

Re: darcs patch: Pass additional parameters in generated shell scripts

2010-05-16 Thread Ian Lynagh
On Sun, May 16, 2010 at 08:17:26PM +0200, Matthias Kilian wrote: > > - ++ quote path ++ concatMap (\arg -> ' ':quote arg) args ] > + ++ unwords (map quote $ path : args) ++ " \"$...@\""] This looks liks it ought to be " ${1+\"$...@\"}" rather than " \"$...@\"", to correctly handle

darcs patch: Pass additional parameters in generated shell scripts

2010-05-16 Thread Matthias Kilian
1 patch for repository http://darcs.volkswurst.de/packages/Cabal: Sun May 16 18:12:30 CEST 2010 Matthias Kilian * Pass additional parameters in generated shell scripts While here, simplify the argument list construction in invocationAsShellScript a little bit. New patches: [Pass addition