RE: cvs commit: jakarta-cactus/framework/src/java/share/org/apache/cactus/util CookieUtil.java

2003-06-23 Thread Vincent Massol
> -Original Message- > From: news [mailto:[EMAIL PROTECTED] On Behalf Of Christopher Lenz > Sent: 23 June 2003 13:08 > To: [EMAIL PROTECTED] > Subject: Re: cvs commit: jakarta- > cactus/framework/src/java/share/org/apache/cactus/util CookieUtil.java > > [EMAIL PROTECTED] wrote: > > vmass

RE: cvs commit: jakarta-cactus/documentation/docs/xdocs/writing howto_testcase_servlet.xml

2003-06-23 Thread Vincent Massol
> -Original Message- > From: news [mailto:[EMAIL PROTECTED] On Behalf Of Christopher Lenz > Sent: 23 June 2003 13:14 > To: [EMAIL PROTECTED] > Subject: Re: cvs commit: jakarta-cactus/documentation/docs/xdocs/writing > howto_testcase_servlet.xml > > [EMAIL PROTECTED] wrote: > > vmassol

RE: cvs commit: jakarta-cactus/samples/servlet/src/test-cactus/share/org/apache/cactus/sample/unit TestHttpSession.java

2003-06-23 Thread Vincent Massol
Yeah, I know it fails! I have just added the tests that shows it fail! It was previously throwing a NPE. I guess this error must have been introduced by Nick's recent changes. I've spent several hours yesterday trying to track it, but I haven't found the culprit and in the end I had other things t

RE: cvs commit: jakarta-cactus/framework/src/java/share/org/apache/cactus/client/connector/http HttpUtil.java JdkConnectionHelper.java HttpClientConnectionHelper.java AbstractConnectionHelper.java

2003-06-23 Thread Vincent Massol
> -Original Message- > From: news [mailto:[EMAIL PROTECTED] On Behalf Of Christopher Lenz > Sent: 23 June 2003 13:05 > To: [EMAIL PROTECTED] > Subject: Re: cvs commit: jakarta- > cactus/framework/src/java/share/org/apache/cactus/client/connector/http > HttpUtil.java JdkConnectionHelper.ja

Re: [GUMP] Build Failure - jakarta-cactus-sample-servlet-12

2003-06-23 Thread Christopher Lenz
g/builds/gump/2003-06-23/jakarta-cactus-sample-servlet-12.html> Buildfile: samples/servlet/build.xml init.display: [echo] - Cactus Servlet Sample 20030623 - [echo] java.class.path = /home/rubys/jakarta/xml-commons/java/ex

[GUMP] Build Failure - jakarta-cactus-sample-servlet-12

2003-06-23 Thread Vincent Massol
isplay: [echo] - Cactus Servlet Sample 20030623 - [echo] java.class.path = /home/rubys/jakarta/xml-commons/java/external/build/xml-apis.jar:/home/rubys/jakarta/xml-xerces2/java/build/xmlParserAPIs.jar:/home/rubys/jakarta/xml-xerces2/java/build/xercesImpl.jar:.:/usr/java/j2sdk1.4.1_

Re: cvs commit: jakarta-cactus/framework/src/java/share/org/apache/cactusAbstractWebServerTestCase.java

2003-06-23 Thread Christopher Lenz
Lesiecki Nicholas wrote: Are we sure we need to add static text to the generated id? (I mean all the "testCase:", "_", etc? No, I'm not sure. I guess I just wanted it there to check if the IDs were really unique, and if not, why...So I'll take it out... The string is also unnecessarily long, thus j

Re: cvs commit: jakarta-cactus/documentation/docs/xdocs/writing howto_testcase_servlet.xml

2003-06-23 Thread Christopher Lenz
[EMAIL PROTECTED] wrote: vmassol 2003/06/22 02:11:03 Modified:documentation/docs/xdocs/writing howto_testcase_servlet.xml Log: Added documentation for the new setRemoteUser() simulation method Revision ChangesPath 1.5 +4 -0 jakarta-cactus/documentation/docs/xdo

Re: cvs commit: jakarta-cactus/framework/src/java/share/org/apache/cactus/utilCookieUtil.java

2003-06-23 Thread Christopher Lenz
[EMAIL PROTECTED] wrote: vmassol 2003/06/22 08:03:55 Modified:framework/src/java/share/org/apache/cactus/client/connector/http AbstractConnectionHelper.java JdkConnectionHelper.java HttpClientConnectionHelper.java

Re: cvs commit: jakarta-cactus/framework/src/java/share/org/apache/cactus/client/connector/httpHttpUtil.java JdkConnectionHelper.java HttpClientConnectionHelper.java AbstractConnectionHelper.java

2003-06-23 Thread Christopher Lenz
Hi Vincent, [EMAIL PROTECTED] wrote: vmassol 2003/06/22 08:25:19 Modified:framework/src/java/share/org/apache/cactus/client/connector/http JdkConnectionHelper.java HttpClientConnectionHelper.java Added: framework/src/java/share/org

Re: Some idea: Ant xmltasks

2003-06-23 Thread Christopher Lenz
Hi Vincent, Vincent Massol wrote: Hi, I've just discovered the Ant xmltasks task: http://www.oopsconsultancy.com/software/xmltask.html The xmltask stuff is indeed pretty nice. But I'm generally reluctant to add dependancies to the build (as you probably know by now :-) ). Unless something reall

Re: cvs commit: jakarta-cactus/samples/servlet/src/test-cactus/share/org/apache/cactus/sample/unitTestHttpSession.java

2003-06-23 Thread Christopher Lenz
Vincent, have you run the tests with this assertion? It fails for me on every container I tried: - jboss3x - orion1x - orion2x - resin2x - tomcat3x - tomcat4x - tomcat5x -chris (not a container ;-) ) [EMAIL PROTECTED] wrote: vmassol 2003/06/22 10:14:43 Modified:samples/servlet/sr

RE: cvs commit: jakarta-cactus/framework/src/java/share/org/apache/cactus AbstractWebServerTestCase.java

2003-06-23 Thread Vincent Massol
> -Original Message- > From: Christopher Lenz [mailto:[EMAIL PROTECTED] > Sent: 23 June 2003 11:13 > To: Cactus Developers List > Subject: Re: cvs commit: jakarta- > cactus/framework/src/java/share/org/apache/cactus > AbstractWebServerTestCase.java > [snip] > > Okay, I hope I've read a

Re: cvs commit: jakarta-cactus/framework/src/java/share/org/apache/cactusAbstractWebServerTestCase.java

2003-06-23 Thread Christopher Lenz
Vincent Massol wrote: I've been thinking about this and I find it a little inconsistent. We're calling addCommand() for all data that need to be passed to the server side. However, we don't call this for the id. Instead we call setUniqueId() (BTW, am I wrong in thinking that an id is always unique

Re: [PROPOSAL] Naming test methods

2003-06-23 Thread Christopher Lenz
Vincent Massol wrote: Hi, I'd like to propose a way to name our test methods. Instead of naming them with "test" such as in: testSetUniqueIdOk() testSetUniqueIdCannotBeRest() I propose to name them with a sentence. This means that if you remove the "test" prefix it should make a sentence. For exam