Dave Miner wrote:
> Moinak Ghosh wrote:
>
>> Hello,
>>
>>I have posted an updated webrev for my changes here:
>> http://cr.opensolaris.org/~moinakg/tm_python/
>>
>>
>
> Looks good, just a few nits:
>
> transfer_mod.py
>
> 485: Looks like this is implemented already
>
Yes via the
> Will fix. BTW as an aside, since we are using so much of Python across
> various projects it will be nice to look at Python specific
> lint/cstyle tools.
IPS has done some work with pylint.
Dave
Moinak Ghosh wrote:
> Hello,
>
>I have posted an updated webrev for my changes here:
> http://cr.opensolaris.org/~moinakg/tm_python/
>
Looks good, just a few nits:
transfer_mod.py
485: Looks like this is implemented already
489,511: we're tracking the number of files copied, but never do
* Dave Miner [2008-03-25 16:57]:
>
> > Will fix. BTW as an aside, since we are using so much of Python across
> > various projects it will be nice to look at Python specific
> > lint/cstyle tools.
>
> IPS has done some work with pylint.
And we're looking at the Coverage module, too, when
Hello,
I have posted an updated webrev for my changes here:
http://cr.opensolaris.org/~moinakg/tm_python/
These changes incorporate Dave's review comments and adds several
more changes:
* It introduces support for the new interfaces defined in:
http://src.opensolaris.org/source/xref/caima