Re: [Cake] Hopefully fixed ACK filter for v6

2018-04-28 Thread Ryan Mounce
On 29 April 2018 at 07:19, Toke Høiland-Jørgensen wrote: > Think I finally managed to fix the ACK filter so it works for both 6in4 > and regular v6 (the latter seems to have been broken since the commit > "e6b72c2 ack_filter: make less aggressive by default" which accidentally > reversed the addre

[Cake] Hopefully fixed ACK filter for v6

2018-04-28 Thread Toke Høiland-Jørgensen
Think I finally managed to fix the ACK filter so it works for both 6in4 and regular v6 (the latter seems to have been broken since the commit "e6b72c2 ack_filter: make less aggressive by default" which accidentally reversed the address compare logic). It should also be safe against weirdly fragment

Re: [Cake] [PATCH net-next v5] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-28 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen writes: > +static inline struct tcphdr *cake_get_tcphdr(struct sk_buff *skb) > +{ > + struct ipv6hdr *ipv6h; > + struct iphdr *iph; > + struct tcphdr *th; > + > + > + switch (skb->protocol) { > + case cpu_to_be16(ETH_P_IP): As someone was kind enough to

Re: [Cake] [PATCH iproute2-next v7] Add support for cake qdisc

2018-04-28 Thread Toke Høiland-Jørgensen
Stephen Hemminger writes: > On Fri, 27 Apr 2018 21:57:20 +0200 > Toke Høiland-Jørgensen wrote: > >> sch_cake is intended to squeeze the most bandwidth and latency out of even >> the slowest ISP links and routers, while presenting an API simple enough >> that even an ISP can configure it. >> >>

Re: [Cake] Thanks to Toke

2018-04-28 Thread Kevin Darbyshire-Bryant via Cake
--- Begin Message --- > On 28 Apr 2018, at 10:59, Toke Høiland-Jørgensen wrote: > > > > Does it actually filter any ACKs if you run a TCP download on a 6in4 > connection? As Ryan pointed out, I think I may have broken that :P > > -Toke Sadly my 6in4 tunnel is deranged at the moment….irresp

Re: [Cake] Thanks to Toke

2018-04-28 Thread Toke Høiland-Jørgensen
On 28 April 2018 10:48:17 CEST, Kevin Darbyshire-Bryant wrote: > > >> On 27 Apr 2018, at 16:06, Toke Høiland-Jørgensen >wrote: >> >> Kevin Darbyshire-Bryant via Cake writes: >> >>> Thank you Toke for your continued and continuing efforts in >submitting >>> CAKE to upstream kernel land. I a

Re: [Cake] Thanks to Toke

2018-04-28 Thread Kevin Darbyshire-Bryant via Cake
--- Begin Message --- > On 27 Apr 2018, at 16:06, Toke Høiland-Jørgensen wrote: > > Kevin Darbyshire-Bryant via Cake writes: > >> Thank you Toke for your continued and continuing efforts in submitting >> CAKE to upstream kernel land. I am at least one person who greatly >> values and appreci