Re: [Cake] [PATCH net] sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb

2022-08-31 Thread Jakub Kicinski via Cake
On Thu, 01 Sep 2022 00:13:24 +0200 Toke Høiland-Jørgensen wrote: > Ah, crossed streams (just sent v2[0]). Sorry about that, traveling knocked out my sense of time and I kept thinking it's Thursday, and the discussion happened yesterday :S > Hmm, okay, so as noted in the changelog to v2, just

Re: [Cake] [PATCH net] sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb

2022-08-31 Thread Toke Høiland-Jørgensen via Cake
patchwork-bot+netdev...@kernel.org writes: > Hello: > > This patch was applied to netdev/net.git (master) > by Jakub Kicinski : > > On Wed, 31 Aug 2022 11:21:03 +0200 you wrote: >> When the GSO splitting feature of sch_cake is enabled, GSO superpackets >> will be broken up and the resulting

Re: [Cake] [PATCH net] sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb

2022-08-31 Thread Toke Høiland-Jørgensen via Cake
Eric Dumazet writes: > On Wed, Aug 31, 2022 at 2:25 AM Toke Høiland-Jørgensen wrote: >> >> When the GSO splitting feature of sch_cake is enabled, GSO superpackets >> will be broken up and the resulting segments enqueued in place of the >> original skb. In this case, CAKE calls consume_skb() on

Re: [Cake] [PATCH net] sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb

2022-08-31 Thread Eric Dumazet via Cake
On Wed, Aug 31, 2022 at 2:25 AM Toke Høiland-Jørgensen wrote: > > When the GSO splitting feature of sch_cake is enabled, GSO superpackets > will be broken up and the resulting segments enqueued in place of the > original skb. In this case, CAKE calls consume_skb() on the original skb, > but still

Re: [Cake] CAKE saves someone's job during the pandemic...

2022-08-31 Thread Dave Taht via Cake
On Thu, Aug 25, 2022 at 2:39 PM Toke Høiland-Jørgensen via Cake wrote: > > I figured y'all would find this an uplifting story - I certainly did! > > https://forum.openwrt.org/t/nftables-and-qos-in-2021/112013/530 I cried. thx. > -Toke > ___ > Cake

Re: [Cake] [PATCH net] sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb

2022-08-31 Thread Dave Taht via Cake
hmm. what did this break above it? just stats? or a mem leak? or? On Wed, Aug 31, 2022 at 2:25 AM Toke Høiland-Jørgensen via Cake wrote: > > When the GSO splitting feature of sch_cake is enabled, GSO superpackets > will be broken up and the resulting segments enqueued in place of the > original

[Cake] [PATCH net] sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb

2022-08-31 Thread Toke Høiland-Jørgensen via Cake
When the GSO splitting feature of sch_cake is enabled, GSO superpackets will be broken up and the resulting segments enqueued in place of the original skb. In this case, CAKE calls consume_skb() on the original skb, but still returns NET_XMIT_SUCCESS. This can confuse parent qdiscs into assuming