[jira] [Comment Edited] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279833#comment-13279833 ] Randy McMillan edited comment on CB-362 at 5/20/12 6:26 PM: -(BOOL

Re: API function: Open url in system web browser

Oops, you provided the source link. I'll test later today and report the results. On Sun, May 20, 2012 at 11:01 AM, Shazron wrote: > iOS doesn't differentiate between target attributes in my testing. If you > set it to _self or _blank, it would always set navigationType to > UIWebViewNavigationT

[jira] [Commented] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279833#comment-13279833 ] Randy McMillan commented on CB-362: --- -(BOOL)webView:(UIWebView *)webView shouldStartLoadWith

Re: API function: Open url in system web browser

iOS doesn't differentiate between target attributes in my testing. If you set it to _self or _blank, it would always set navigationType to UIWebViewNavigationTypeOther, so I don't know how you are getting these results. Send me your test project so I can verify your results and confirm. This is wh

[jira] [Comment Edited] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279819#comment-13279819 ] Olivier Louvignes edited comment on CB-362 at 5/20/12 5:18 PM: ---

[jira] [Comment Edited] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279819#comment-13279819 ] Olivier Louvignes edited comment on CB-362 at 5/20/12 5:18 PM: ---

[jira] [Comment Edited] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279819#comment-13279819 ] Olivier Louvignes edited comment on CB-362 at 5/20/12 5:18 PM: ---

[jira] [Comment Edited] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279819#comment-13279819 ] Olivier Louvignes edited comment on CB-362 at 5/20/12 5:17 PM: ---

[jira] [Commented] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279819#comment-13279819 ] Olivier Louvignes commented on CB-362: -- There is also the "tel:" & "maps:" scheme that sh

[jira] [Comment Edited] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279819#comment-13279819 ] Olivier Louvignes edited comment on CB-362 at 5/20/12 5:17 PM: ---

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: RandyMcMillan-openInSafari.zip > [ios] target="_blank" links should open in browser (ignori

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: (was: senchaTwo.png) > [ios] target="_blank" links should open in browser (ignoring ext

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: (was: whitelist.png) > [ios] target="_blank" links should open in browser (ignoring ext

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: (was: phonegap.com.both.png) > [ios] target="_blank" links should open in browser (igno

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: (was: senchaOne.png) > [ios] target="_blank" links should open in browser (ignoring ext

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: (was: linkOpenedInSafari.png) > [ios] target="_blank" links should open in browser (ign

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: (was: self_rejected.png) > [ios] target="_blank" links should open in browser (ignoring

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: (was: phonegap.png) > [ios] target="_blank" links should open in browser (ignoring exte

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: (was: blanknotrejected.png) > [ios] target="_blank" links should open in browser (ignor

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: (was: index.html.png) > [ios] target="_blank" links should open in browser (ignoring ex

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: (was: googleOpened.png) > [ios] target="_blank" links should open in browser (ignoring

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: (was: addGoogle.png) > [ios] target="_blank" links should open in browser (ignoring ext

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: (was: openInSafari.zip) > [ios] target="_blank" links should open in browser (ignoring

[jira] [Commented] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279809#comment-13279809 ] Randy McMillan commented on CB-362: --- https://github.com/RandyMcMillan/openInSafari

[jira] [Comment Edited] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279805#comment-13279805 ] Randy McMillan edited comment on CB-362 at 5/20/12 4:13 PM: -(BOOL

[jira] [Commented] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279805#comment-13279805 ] Randy McMillan commented on CB-362: --- -(BOOL)webView:(UIWebView *)webView shouldStartLoadWith

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: phonegap.png phonegap.com.both.png reference phonegap.com.both.png phonegap.p

[jira] [Commented] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279792#comment-13279792 ] Randy McMillan commented on CB-362: --- Q. Is it something im doing or is there lag between the

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: whitelist.png self_rejected.png blanknotrejected.png _self load

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: openInSafari.zip senchaTwo.png senchaOne.png I clicked the gene

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: googleOpened.png addGoogle.png tested link provided in the description as well.

[jira] [Updated] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy McMillan updated CB-362: -- Attachment: linkOpenedInSafari.png index.html.png It may need further testing but when adde

[jira] [Commented] (CB-362) [ios] target="_blank" links should open in browser (ignoring externalhosts)

[ https://issues.apache.org/jira/browse/CB-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279781#comment-13279781 ] Randy McMillan commented on CB-362: --- -(BOOL)webView:(UIWebView *)webView shouldStartLoadWith

incubator-cordova-ios pull request: openInSafari

GitHub user RandyMcMillan opened a pull request: https://github.com/apache/incubator-cordova-ios/pull/19 openInSafari https://issues.apache.org/jira/browse/CB-362 Adding -(BOOL)webView:(UIWebView *)webView shouldStartLoadWithRequest:(NSURLRequest *)request n

Re: API function: Open url in system web browser

On Sun, May 20, 2012 at 12:43 AM, Brian LeRoux wrote: > How is opening a URL in a web browser a security risk to the Cordova code > shaz? By opening up the whitelist to exclude urls that have the query param, which your proposal requires, it allows malicious code to bypass the whitelist by just i

Re: API function: Open url in system web browser

Also, pls consider the solution I propose comes with the benefit that links continue to work in the browser without modification. On May 20, 2012 9:43 AM, "Brian LeRoux" wrote: > How is opening a URL in a web browser a security risk to the Cordova code > shaz? > > Jesse: a declarative approach j

Re: API function: Open url in system web browser

How is opening a URL in a web browser a security risk to the Cordova code shaz? Jesse: a declarative approach just means devs need to manually add the URL param themselves (quirk). A fair trade while we wait for the beefier programmatic child browser API. On May 20, 2012 6:45 AM, "Shazron" wrote: