Re: Changes to File API

2012-02-22 Thread Simon MacDonald
Okay, here is the updated commit. https://github.com/macdonst/callback-js/commit/bd36b200f61754e15467cb3617738f410018f451 If I don't get any objections I will push it up after my next meeting. Simon Mac Donald http://hi.im/simonmacdonald On Wed, Feb 22, 2012 at 1:01 PM, Filip Maj wrote: > +1

Re: Changes to File API

2012-02-22 Thread Filip Maj
+1 to taking it out - not even exactly sure what it's there for "Users may supply mimeType in order to simulate the optional mime-type header associated with HTTP downloads." On 12-02-22 9:42 AM, "Simon MacDonald" wrote: >It is in this spec which is the working draft: > >http://www.w3.org/TR/fi

Re: Changes to File API

2012-02-22 Thread Simon MacDonald
It is in this spec which is the working draft: http://www.w3.org/TR/file-system-api/#widl-Entry-toURL but not in the editors draft: http://dev.w3.org/2009/dap/file-system/file-dir-sys.html so I'm happy to take it out if everyone is okay with that. Simon Mac Donald http://hi.im/simonmacdonald

Re: Changes to File API

2012-02-22 Thread Drew Walters
mimetype is not a parameter of toURL either though right? On Wed, Feb 22, 2012 at 11:30 AM, Simon MacDonald wrote: > Okay, I've just put a change that adds toURI back into the Entry class for > backwards compatibility. I also removed the success/error parameters from > toURL as they are not accor

Re: Changes to File API

2012-02-22 Thread Simon MacDonald
Okay, I've just put a change that adds toURI back into the Entry class for backwards compatibility. I also removed the success/error parameters from toURL as they are not according spec and they are never used. Take a look at the change and let me know if anything else is needed: https://github.c

Re: Changes to File API

2012-02-20 Thread Brian LeRoux
I'd like us to keep drawing our attention to that world 'everything is a plugin'. That said, having tagged versions that target specific api releases would be the way to go. On Mon, Feb 20, 2012 at 10:10 AM, Dave Johnson wrote: > In the land of "everything is a plugin" I guess those old versions

Re: Changes to File API

2012-02-20 Thread Dave Johnson
In the land of "everything is a plugin" I guess those old versions just become another plugin that's available for use? On Monday, February 20, 2012, Patrick Mueller wrote: > On Mon, Feb 20, 2012 at 11:57, Dave Johnson > > >wrote: > > > Yah I think that makes sense. We can even remove the old o

Re: Changes to File API

2012-02-20 Thread Patrick Mueller
On Mon, Feb 20, 2012 at 11:57, Dave Johnson wrote: > Yah I think that makes sense. We can even remove the old one when we hit a > major release. > It's not clear what the lifetime of such "versioned spec'd APIs from somewhere" should be. While it seems that we would certainly "drop support" for

Re: Changes to File API

2012-02-20 Thread Dave Johnson
Yah I think that makes sense. We can even remove the old one when we hit a major release. -dave On Monday, February 20, 2012, Patrick Mueller wrote: > On Fri, Feb 17, 2012 at 15:33, Dave Johnson > > >wrote: > > > For all of these sorts of changes lets endevour to maintain backwards > > compati

Re: Changes to File API

2012-02-20 Thread Patrick Mueller
On Fri, Feb 17, 2012 at 15:33, Dave Johnson wrote: > For all of these sorts of changes lets endevour to maintain backwards > compatibility and put in deprecation notices. Ideally the deprecated APIs > are removed at a major version change, e.g. when we hit 2.0. This will always be a problem for

Re: Changes to File API

2012-02-17 Thread Dave Johnson
For all of these sorts of changes lets endevour to maintain backwards compatibility and put in deprecation notices. Ideally the deprecated APIs are removed at a major version change, e.g. when we hit 2.0. On Friday, February 17, 2012, Filip Maj wrote: > I like that idea, Simon. Simple to add a me

Re: Changes to File API

2012-02-17 Thread Filip Maj
I like that idea, Simon. Simple to add a method copy from toURL -> toURI, add a console.log, tag for 1.5, done. As for updating the error codes - can we shelve that for 1.6? On 12-02-17 11:52 AM, "Simon MacDonald" wrote: >For the 1.5.0 release can we support .toURI() and .toURL()? >We'll mark t

Re: Changes to File API

2012-02-17 Thread Simon MacDonald
For the 1.5.0 release can we support .toURI() and .toURL()? We'll mark toURI as deprecated and remove it in 1.6.0 or 1.7.0. What do you think? As for the FileError codes. Gr...why did they have to change them. Simon Mac Donald http://hi.im/simonmacdonald On Fri, Feb 17, 2012 at 2:36 PM, Bec

Re: Changes to File API

2012-02-17 Thread Becky Gibson
Yes, it isn't a huge change but could be a gotcha for many folks. Also, the new toURL() API no longer takes the mimetype parameter. So we need to modify the entry.js one way or another. -b On Fri, Feb 17, 2012 at 2:48 PM, Filip Maj wrote: > Yeah I made the change in cordova-js to the new API

Re: Changes to File API

2012-02-17 Thread Filip Maj
Yeah I made the change in cordova-js to the new API as I was going over our File API implementation with a magnifying glass and make sure it was doing the right things. I'm ambivalent either way, really. On 12-02-17 11:36 AM, "Becky Gibson" wrote: >I was running the mobile-spec after Shaz compl

Changes to File API

2012-02-17 Thread Becky Gibson
I was running the mobile-spec after Shaz completed and checked in the iOS name change (THANKS, Shaz!) and found that several file tests fail. The issue is the name change of the .toURI() api to .toURL(). Checking on the W3C File API: Directories and Systems spec. this API was indeed renamed from th