Re: Java Style

2012-05-15 Thread Dave Johnson
4 tabs, 1 space. On Tue, May 15, 2012 at 2:48 PM, Simon MacDonald wrote: > +1 on 4 spaces, no tabs. > > Simon Mac Donald > http://hi.im/simonmacdonald > > > On Tue, May 15, 2012 at 5:39 PM, Joe Bowser wrote: > >> Remember to set Indentation and Tabs the same.  I had Indentation 2 and >> Tabs 4.

Re: Java Style

2012-05-15 Thread Simon MacDonald
+1 on 4 spaces, no tabs. Simon Mac Donald http://hi.im/simonmacdonald On Tue, May 15, 2012 at 5:39 PM, Joe Bowser wrote: > Remember to set Indentation and Tabs the same. I had Indentation 2 and > Tabs 4. > > On Tue, May 15, 2012 at 2:30 PM, Filip Maj wrote: > > > Holy crap a bit tougher in E

Re: Java Style

2012-05-15 Thread Joe Bowser
Remember to set Indentation and Tabs the same. I had Indentation 2 and Tabs 4. On Tue, May 15, 2012 at 2:30 PM, Filip Maj wrote: > Holy crap a bit tougher in Eclipse on mac. > > Eclipse -> Preferences -> Java -> Code Style -> Formatter -> Edit the > selected Profile -> Change its name -> First

Re: Java Style

2012-05-15 Thread Filip Maj
Holy crap a bit tougher in Eclipse on mac. Eclipse -> Preferences -> Java -> Code Style -> Formatter -> Edit the selected Profile -> Change its name -> First option (tab policy): Spaces only -> Indentation: 4 Phew! On 5/15/12 2:17 PM, "Filip Maj" wrote: >OK will add that to the style guide the

Re: Java Style

2012-05-15 Thread Shazron
Huh, so hard to find in Eclipse, here's how: http://stackoverflow.com/questions/407929/how-do-i-change-eclipse-to-use-spaces-instead-of-tabs On Tue, May 15, 2012 at 2:17 PM, Filip Maj wrote: > OK will add that to the style guide then. Please adjust Eclipse > accordingly, everyone! > > On 5/15/12

Re: Java Style

2012-05-15 Thread Filip Maj
OK will add that to the style guide then. Please adjust Eclipse accordingly, everyone! On 5/15/12 2:12 PM, "Bryce Curtis" wrote: >+1 on 4 spaces, no tabs. > >On Tue, May 15, 2012 at 4:07 PM, Michael Brooks > wrote: >> +1 on 4 spaces in Java. >> >> On Tue, May 15, 2012 at 1:55 PM, Joe Bowser wro

Re: Java Style

2012-05-15 Thread Jesse
+1 to 4 spaces everywhere. On Tue, May 15, 2012 at 2:07 PM, Michael Brooks wrote: > +1 on 4 spaces in Java. > > On Tue, May 15, 2012 at 1:55 PM, Joe Bowser wrote: > > > +1 on spaces. It should be noted that this isn't the default in Eclipse. > > :( > > > > On Tue, May 15, 2012 at 1:52 PM, Drew

Re: Java Style

2012-05-15 Thread Bryce Curtis
+1 on 4 spaces, no tabs. On Tue, May 15, 2012 at 4:07 PM, Michael Brooks wrote: > +1 on 4 spaces in Java. > > On Tue, May 15, 2012 at 1:55 PM, Joe Bowser wrote: > >> +1 on spaces.  It should be noted that this isn't the default in Eclipse. >> :( >> >> On Tue, May 15, 2012 at 1:52 PM, Drew Walter

Re: Java Style

2012-05-15 Thread Michael Brooks
+1 on 4 spaces in Java. On Tue, May 15, 2012 at 1:55 PM, Joe Bowser wrote: > +1 on spaces. It should be noted that this isn't the default in Eclipse. > :( > > On Tue, May 15, 2012 at 1:52 PM, Drew Walters wrote: > > > Should note, all the BlackBerry Java code is 4 space indentation > > except

Re: Java Style

2012-05-15 Thread Joe Bowser
+1 on spaces. It should be noted that this isn't the default in Eclipse. :( On Tue, May 15, 2012 at 1:52 PM, Drew Walters wrote: > Should note, all the BlackBerry Java code is 4 space indentation > except for maybe a few spots where someone else edited the file. > > On Tue, May 15, 2012 at 3:50

Re: Java Style

2012-05-15 Thread Drew Walters
Should note, all the BlackBerry Java code is 4 space indentation except for maybe a few spots where someone else edited the file. On Tue, May 15, 2012 at 3:50 PM, Drew Walters wrote: > +1 spaces > > On Tue, May 15, 2012 at 3:48 PM, Shazron wrote: >> Spaces. >> I've an issue filed against iOS reg

Re: Java Style

2012-05-15 Thread Drew Walters
+1 spaces On Tue, May 15, 2012 at 3:48 PM, Shazron wrote: > Spaces. > I've an issue filed against iOS regarding this: > https://issues.apache.org/jira/browse/CB-625 > > > On Tue, May 15, 2012 at 1:49 PM, Filip Maj wrote: >> I suppose I should post my refs too >> >> [1] http://wiki.apache.org/cor

Re: Java Style

2012-05-15 Thread Shazron
Spaces. I've an issue filed against iOS regarding this: https://issues.apache.org/jira/browse/CB-625 On Tue, May 15, 2012 at 1:49 PM, Filip Maj wrote: > I suppose I should post my refs too > > [1] http://wiki.apache.org/cordova/StyleGuide > [2] > http://www.oracle.com/technetwork/java/javase/doc

Re: Java Style

2012-05-15 Thread Filip Maj
I suppose I should post my refs too [1] http://wiki.apache.org/cordova/StyleGuide [2] http://www.oracle.com/technetwork/java/javase/documentation/codeconventions -136091.html#262 On 5/15/12 1:48 PM, "Filip Maj" wrote: >Let's see how this one pans out ;) > >This came up during the code review o

Java Style

2012-05-15 Thread Filip Maj
Let's see how this one pans out ;) This came up during the code review of the CordovaWebView stuff for Android. Our style guide [1] specifies to follow the Eclipse Coding Conventions, which point to standards set out by Sun, which of course now points to an Oracle web site. The Sun standards say