I reviewed the changes and pulled the latest JS code into my Android
project to do some testing. As expected the changes did not affect any
of the current Android functionality. So it looks good from my
perspective.
One question I wonder about is whether CameraPopoverOptions should
only be in iOS
Hey Becky (and rest of team), I'm not back in action until Wednesday so..
I'll check it out then :)
On 5/25/12 10:03 PM, "Becky Gibson" wrote:
>OK, I realize an hour and a half isn't much time for a code review. But, I
>gotta power down as my office is moving. Checked in the code. Will check
>
OK, I realize an hour and a half isn't much time for a code review. But, I
gotta power down as my office is moving. Checked in the code. Will check
in later to make sure there are no issues.
On Fri, May 25, 2012 at 2:30 PM, Becky Gibson wrote:
> The pull request for codova-js didn't come thro
The pull request for codova-js didn't come through - although the one for
cordova-ios did post to the list?
At any rate, since I am changing common code, would appreciate a quick code
review of my changes for camera. Will commit as soon as some gives this a
once over. Note that I added the Came
