Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/ --- Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/#review66867 --- Works great! Minor fixes needed. libs/db/CMakeLists.txt

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

> On Sept. 18, 2014, 10:46 p.m., Jarosław Staniek wrote: > > libs/db/tableviewdata.cpp, line 56 > > > > > > use K_GLOBAL_STATIC (from KGlobal) so the object gets destroyed on > > app's exit Collator is abstract

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

> On Sept. 19, 2014, 12:46 a.m., Jarosław Staniek wrote: > > libs/db/tableviewdata.cpp, line 56 > > > > > > use K_GLOBAL_STATIC (from KGlobal) so the object gets destroyed on > > app's exit > > Michal Poteralski

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/ --- (Updated Sept. 19, 2014, 9:54 p.m.) Review request for Calligra, Andrius

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/ --- (Updated Sept. 19, 2014, 9:56 p.m.) Review request for Calligra, Andrius

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/ --- (Updated Sept. 19, 2014, 9:58 p.m.) Review request for Calligra, Andrius

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

> On Sept. 18, 2014, 10:46 p.m., Jarosław Staniek wrote: > > libs/db/tableviewdata.cpp, line 156 > > > > > > - use kWarning() << ... > > - don't you want to return false here? I don't want return false becau

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

> On Sept. 19, 2014, 12:46 a.m., Jarosław Staniek wrote: > > libs/db/CMakeLists.txt, line 15 > > > > > > ${ICU_INCLUDE_DIRS} needed I guess like in libs/db/drivers/sqlite/icu > > > > The reason why it wor

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/#review67015 --- Ship it! One fix left (include), then please push to 2.8 and

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/#review67040 --- Ship it! Ship It! - Michal Poteralski On Sept. 20, 2014, 1

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/ --- (Updated Sept. 20, 2014, 10:04 a.m.) Review request for Calligra, Andrius

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/ --- (Updated Sept. 20, 2014, 6:55 p.m.) Status -- This change has been m