Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-03-02 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122045/ --- (Updated March 2, 2015, 3:11 p.m.) Status -- This change has been ma

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-02-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122045/#review75215 --- Ship it! Looks cool! Minor notes, mostly for the future. fi

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-21 Thread Lassi Nieminen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122045/#review74521 --- Ooxml related parts look fine to me. - Lassi Nieminen On Ja

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122045/ --- (Updated Jan. 18, 2015, 4:26 a.m.) Review request for Calligra, Lassi Nie

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Inge Wallin
> On Jan. 18, 2015, 3:21 a.m., Friedrich W. H. Kossebau wrote: > > filters/libodf2/CMakeLists.txt, line 4 > > > > > > Including libmso files for libodf2 seems wrong as well, similar as > > Charting.h is non-odf st

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122045/#review74220 --- filters/libmso/MsoUtils.cpp

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122045/#review74212 --- Hm... nothing wrong seen. But one thing seems questionable to

Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-13 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122045/ --- Review request for Calligra, Lassi Nieminen and Jarosław Staniek. Reposit