On Mon, Jul 6, 2020 at 8:34 AM Kenton Varda wrote:
> On Mon, Jul 6, 2020 at 10:22 AM Vitali Lovich wrote:
>
>> I don't feel great about the duplication approach (or allowing retrieving
>> the raw handle directly) as it can be subtly tricky to actually use
>> correctly. For example, if you dup &
On Mon, Jul 6, 2020 at 10:22 AM Vitali Lovich wrote:
> I don't feel great about the duplication approach (or allowing retrieving
> the raw handle directly) as it can be subtly tricky to actually use
> correctly. For example, if you dup & make the dup'ed FD blocking, that will
> impact correct beh
On Mon, Jul 6, 2020 at 8:13 AM Kenton Varda wrote:
> On Mon, Jul 6, 2020 at 9:28 AM Vitali Lovich wrote:
>
>> Yeah, that's what I figured. The KJ API is s much more user friendly
though :). It would be cool to be able to consume the raw file
descriptor/socket out of the pipes the
On Mon, Jul 6, 2020 at 7:41 AM Vitali Lovich wrote:
>
> On Mon, Jul 6, 2020 at 7:26 AM Kenton Varda wrote:
>
>> Almost. Two issues I can think of:
>>
>> 1. After each pump completes, you probably want to call shutdownWrite()
>> to propagate the EOF.
>> 2. `joinPromises()` always waits for all pr
On Mon, Jul 6, 2020 at 9:28 AM Vitali Lovich wrote:
> Yeah, that's what I figured. The KJ API is s much more user friendly
>>> though :). It would be cool to be able to consume the raw file
>>> descriptor/socket out of the pipes the LowlevelIoProvider constructs to
>>> simplify code/error ha
On Mon, Jul 6, 2020 at 7:26 AM Kenton Varda wrote:
> Almost. Two issues I can think of:
>
> 1. After each pump completes, you probably want to call shutdownWrite() to
> propagate the EOF.
> 2. `joinPromises()` always waits for all promises to resolve. I've often
> found that this turns out to be
On Mon, Jul 6, 2020 at 7:14 AM Kenton Varda wrote:
> On Mon, Jul 6, 2020 at 8:02 AM Vitali Lovich wrote:
>
>> On Sun, Jul 5, 2020 at 3:02 PM Kenton Varda
>> wrote:
>>
>>> On Sun, Jul 5, 2020 at 1:48 PM Vitali Lovich wrote:
>>>
Yeah, so I'm still working through getting executeSync working
Almost. Two issues I can think of:
1. After each pump completes, you probably want to call shutdownWrite() to
propagate the EOF.
2. `joinPromises()` always waits for all promises to resolve. I've often
found that this turns out to be the wrong behavior when one of the joined
promises throws an exc
On Mon, Jul 6, 2020 at 8:02 AM Vitali Lovich wrote:
> On Sun, Jul 5, 2020 at 3:02 PM Kenton Varda wrote:
>
>> On Sun, Jul 5, 2020 at 1:48 PM Vitali Lovich wrote:
>>
>>> Yeah, so I'm still working through getting executeSync working. I do
>>> wish executeAsync would still be able to do the right
On Sun, Jul 5, 2020 at 3:02 PM Kenton Varda wrote:
> On Sun, Jul 5, 2020 at 1:48 PM Vitali Lovich wrote:
>
>> Yeah, so I'm still working through getting executeSync working. I do wish
>> executeAsync would still be able to do the right thing when invoked from
>> off-thread to avoid creating arti
10 matches
Mail list logo