Re: [casper] Fixed FFT block status

FWIW, I've noticed another related problem in the pfb_fir and pfb_fir_real blocks. The mask callbacks for the TotalTaps parameter of these blocks assign and use a variable named size. Unfortunately, this seems to wind up in the global workspace and overrides the built-in size function. This

Re: [casper] Fixed FFT block status

On Jun 24, 2010, at 23:06 , Andrew Martens wrote: I shall have a look at this too Thanks, Andrew! Dave P.S. Sorry to talk about you in the third person when you're on the list.

Re: [casper] Fixed FFT block status

There are three bugs we know of in the FFT. The first one (the biggest one) involves the twiddle coefficients and matlab's understanding of i and j as sqrt(-1) for complex numbers. This one's been fixed and should be checked-in. See earlier emails for details. The second bug is a little

Re: [casper] Fixed FFT block status

Hi, Jason, Thanks for the details! This kind of commentary would be great to include in the commit log message. See git help commit (the DISCUSSION part)... Though not required, it's a good idea to begin the commit message with a single short (less than 50 character) line summarizing

Re: [casper] Fixed FFT block status

Agreed. At the very least, you shouldn't be able to override function names with variable names. 1 point to strongly typed languages... On Jun 24, 2010, at 12:40 PM, Aaron Parsons wrote: FWIW, I've noticed another related problem in the pfb_fir and pfb_fir_real blocks. The mask callbacks