Re: [Catalyst] Contributing code

2010-07-03 Thread Tomas Doran
On 30 Jun 2010, at 13:40, Alexander Hartmaier wrote: I'd prefer *much* more inline comments as well to make it easier to work on code parts I've never touched before when debugging or adding features as it's very hard to figure out what the methods do and how they interact. Entirely prepare

Re: [Catalyst] Contributing code

2010-07-03 Thread Tomas Doran
On 23 Jun 2010, at 07:23, Toby Corkindale wrote: Cheers - can I suggest that URL is added to the Contributing Code wiki page that was originally linked in this email thread? Wiki like wiki is like a wiki. Thanks in advance! t0m ___ List: Catalys

Re: [Catalyst] Contributing code

2010-06-30 Thread Alexander Hartmaier
I'd prefer *much* more inline comments as well to make it easier to work on code parts I've never touched before when debugging or adding features as it's very hard to figure out what the methods do and how they interact. -- Best regards, Alex Am Montag, den 21.06.2010, 16:55 +0200 schrieb J. Sh

Re: [Catalyst] Contributing code

2010-06-22 Thread Toby Corkindale
On 23/06/10 01:03, Tomas Doran wrote: On 22 Jun 2010, at 08:55, Toby Corkindale wrote: I think I asked about this last time (to great silence), but.. what's the correct base path for the Git repos there? ie. git clone http://git.shadowcat.co.uk//Catalyst-Devel.git Like the CPAN search p

Re: [Catalyst] Contributing code

2010-06-22 Thread Nigel Metheringham
On 22 Jun 2010, at 18:26, Tomas Doran wrote: > > But I get exactly what you're saying about the clone URI - that would be > entirely useful here.. Should just be a case of setting @git_base_url_list in the overall gitweb config file. Nigel. -- [ Nigel Metheringham nigel.meth

Re: [Catalyst] Contributing code

2010-06-22 Thread Tomas Doran
On 22 Jun 2010, at 17:01, Chisel wrote: I'm spoiled by github and gitosis having easy to spot, copy and use git:// URLs for a repo clone action. Erm, you are looking at a gitosis install :) But I get exactly what you're saying about the clone URI - that would be entirely useful here.. Ch

Re: [Catalyst] Contributing code

2010-06-22 Thread Chisel
On Tue, Jun 22, 2010 at 4:04 PM, Tomas Doran wrote: > By 'the summary page for the project', you mean something other than the > search.cpan page, right (as that does contain this info)? > > What? > If you happen upon the git repo there's no obvious git clone URL ... http://git.shadowcat.co.uk/

Re: [Catalyst] Contributing code

2010-06-22 Thread Tomas Doran
On 22 Jun 2010, at 11:27, Chisel wrote: I agree that it's a bit annoying that the summary page for the project isn't more helpful by explicitly showing the clone URL and relies on a bit of educated guessing to find. By 'the summary page for the project', you mean something other than the sea

Re: [Catalyst] Contributing code

2010-06-22 Thread Tomas Doran
On 22 Jun 2010, at 08:55, Toby Corkindale wrote: I think I asked about this last time (to great silence), but.. what's the correct base path for the Git repos there? ie. git clone http://git.shadowcat.co.uk//Catalyst-Devel.git Like the CPAN search page says, it is git://git.shadowcat.c

Re: [Catalyst] Contributing code

2010-06-22 Thread Sir Robert Burbridge
On 06/21/2010 05:38 PM, Kieren Diment wrote: On 21/06/2010, at 11:48 PM, Sir Robert Burbridge wrote: Out of a discussion last week, I have some code to contribute (largely to Catalyst::Helper). Two quick questions: [snip q 1 ] 2) I've noticed many times in the CPAN modules I've looked th

Re: [Catalyst] Contributing code

2010-06-22 Thread Chisel
On Tue, Jun 22, 2010 at 8:55 AM, Toby Corkindale wrote: > > I think I asked about this last time (to great silence), but.. what's the > correct base path for the Git repos there? > > ie. git clone http://git.shadowcat.co.uk//Catalyst-Devel.git $ git clone git://git.shadowcat.co.uk/catagits/C

Re: [Catalyst] Contributing code

2010-06-22 Thread Toby Corkindale
On 22/06/10 00:19, Ævar Arnfjörð Bjarmason wrote: On Mon, Jun 21, 2010 at 13:48, Sir Robert Burbridge wrote: Out of a discussion last week, I have some code to contribute (largely to Catalyst::Helper). Two quick questions: 1) I've never contributed code to a project outside my work before.

Re: [Catalyst] Contributing code

2010-06-21 Thread Kieren Diment
On 21/06/2010, at 11:48 PM, Sir Robert Burbridge wrote: > Out of a discussion last week, I have some code to contribute (largely to > Catalyst::Helper). > > Two quick questions: > [snip q 1 ] > 2) I've noticed many times in the CPAN modules I've looked through tend to > be very sparsely comme

Re: [Catalyst] Contributing code

2010-06-21 Thread Chris Jackson
Larry Leszczynski wrote: Have you read http://wiki.catalystframework.org/wiki/contrib ? To whom it may concern: This URL is currently (Jun. 21, 15:22:18 UTC) returning a 500 server error. I'm afraid Mojomojo simply does that sometimes. Experienced Catalyst developers willing to work on it

Re: [Catalyst] Contributing code

2010-06-21 Thread piotr pogorzelski
Original Message Subject: Re: [Catalyst] Contributing code From: Larry Leszczynski To: The elegant MVC web framework Date: Mon Jun 21 2010 17:23:46 GMT+0200 (CEST) Have you read http://wiki.catalystframework.org/wiki/contrib ? To whom it may concern: This URL is

Re: [Catalyst] Contributing code

2010-06-21 Thread Larry Leszczynski
> Have you read http://wiki.catalystframework.org/wiki/contrib ? To whom it may concern: This URL is currently (Jun. 21, 15:22:18 UTC) returning a 500 server error. Larry ___ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.scsys.co.uk/cgi-bi

Re: [Catalyst] Contributing code

2010-06-21 Thread Dwalu Z. Khasu
On Mon, 21 Jun 2010, Sir Robert Burbridge wrote: =>On 06/21/2010 10:19 AM, Ævar Arnfjörð Bjarmason wrote: =>> On Mon, Jun 21, 2010 at 13:48, Sir Robert Burbridge =>> wrote: =>> =>> > Out of a discussion last week, I have some code to contribute (largely to =>> > Catalyst::Helper). =>> > =>> >

Re: [Catalyst] Contributing code

2010-06-21 Thread J. Shirley
On Mon, Jun 21, 2010 at 7:43 AM, iain wrote: > Ævar Arnfjörð Bjarmason wrote: >> >> It depends on what sort of comments you're making. Comments that >> explain tricky code that help with maintenance down the road are >> welcome everywhere. If you're just making comments that help someone >> comple

Re: [Catalyst] Contributing code

2010-06-21 Thread iain
Ævar Arnfjörð Bjarmason wrote: It depends on what sort of comments you're making. Comments that explain tricky code that help with maintenance down the road are welcome everywhere. If you're just making comments that help someone completely unfamiliar with Catalyst to read the code it'll probably

Re: [Catalyst] Contributing code

2010-06-21 Thread Sir Robert Burbridge
On 06/21/2010 10:19 AM, Ævar Arnfjörð Bjarmason wrote: On Mon, Jun 21, 2010 at 13:48, Sir Robert Burbridge wrote: Out of a discussion last week, I have some code to contribute (largely to Catalyst::Helper). Two quick questions: 1) I've never contributed code to a project outside my work

Re: [Catalyst] Contributing code

2010-06-21 Thread Ævar Arnfjörð Bjarmason
On Mon, Jun 21, 2010 at 13:48, Sir Robert Burbridge wrote: > Out of a discussion last week, I have some code to contribute (largely to > Catalyst::Helper). > > Two quick questions: > > 1)  I've never contributed code to a project outside my work before.  How do > I go about it? Have you read http

[Catalyst] Contributing code

2010-06-21 Thread Sir Robert Burbridge
Out of a discussion last week, I have some code to contribute (largely to Catalyst::Helper). Two quick questions: 1) I've never contributed code to a project outside my work before. How do I go about it? 2) I've noticed many times in the CPAN modules I've looked through tend to be very spa