Re: [Catalyst] Plugin::Authentication overrides $c->req->user

2009-02-24 Thread Daniel Westermann-Clark
On 2009-02-21 01:49:51 +, Tomas Doran wrote: >> Attached is a set of patches to add support for $c->req->remote_user, >> including a basic test. > > Good stuff, thanks. I've branched 5.80 trunk and applied your > Runtime change, and then I've fiddled the 'do we warn' logic to be a > bit safer.

Re: [Catalyst] Plugin::Authentication overrides $c->req->user

2009-02-20 Thread Tomas Doran
On 20 Feb 2009, at 22:57, Daniel Westermann-Clark wrote: On 2009-02-11 21:53:48 +, Tomas Doran wrote: Why not just add a remote_user() method on $c->req instead? It's a little more typing, but is more explicit about where the value comes from and doesn't potentially break any existing apps

Re: [Catalyst] Plugin::Authentication overrides $c->req->user

2009-02-20 Thread Daniel Westermann-Clark
On 2009-02-11 21:53:48 +, Tomas Doran wrote: >> Why not just add a remote_user() method on $c->req instead? It's a >> little more typing, but is more explicit about where the value comes >> from and doesn't potentially break any existing apps. > > Patches on 5.80 welcome :) Attached is a set o

Re: [Catalyst] Plugin::Authentication overrides $c->req->user

2009-02-11 Thread Tomas Doran
On 11 Feb 2009, at 21:37, Peter Karman wrote: Daniel Westermann-Clark wrote on 02/11/2009 02:53 PM: If no one is using this behavior, I'd be happy to provide patches to deprecate or remove it. Why not just add a remote_user() method on $c->req instead? It's a little more typing, but is more

Re: [Catalyst] Plugin::Authentication overrides $c->req->user

2009-02-11 Thread Peter Karman
Daniel Westermann-Clark wrote on 02/11/2009 02:53 PM: > On 2009-02-11 10:06:42 +0100, Rodrigo wrote: >> I'm not familiar with $c->req->user, but isn't REMOTE_USER a header >> you can read with $c->req->header('remote_user'), or whatever header >> name is being passed around? > > Some authenticatio

Re: [Catalyst] Plugin::Authentication overrides $c->req->user

2009-02-11 Thread Daniel Westermann-Clark
On 2009-02-11 10:06:42 +0100, Rodrigo wrote: > I'm not familiar with $c->req->user, but isn't REMOTE_USER a header > you can read with $c->req->header('remote_user'), or whatever header > name is being passed around? Some authentication schemes might provide headers containing the username, but RE

Re: [Catalyst] Plugin::Authentication overrides $c->req->user

2009-02-11 Thread Rodrigo
On Tue, Feb 10, 2009 at 9:46 PM, Daniel Westermann-Clark wrote: > Hi, > > At work we use, among other things, the value of REMOTE_USER in the > request environment to authenticate users using our single-sign on > system. We access this via $c->req->user, which the various engines > set using the

[Catalyst] Plugin::Authentication overrides $c->req->user

2009-02-10 Thread Daniel Westermann-Clark
Hi, At work we use, among other things, the value of REMOTE_USER in the request environment to authenticate users using our single-sign on system. We access this via $c->req->user, which the various engines set using the data available to them. However, Catalyst::Plugin::Authentication->set_auth