Re: [Catalyst] Why no extra attributes on Private actions?

2009-08-17 Thread Moritz Onken
__PACKAGE__-config( actions = { foo = { Path = 'bar' } } ); sub foo {} This has been introduced in 5.80006. The Catalyst-Manual just didn't catch up with the changes. cheers, moritz ___ List: Catalyst@lists.scsys.co.uk Listinfo:

Re: [Catalyst] Why no extra attributes on Private actions?

2009-08-17 Thread Bill Moseley
On Sun, Aug 16, 2009 at 10:40 AM, Bill Moseley mose...@hank.org wrote: On Sat, Aug 15, 2009 at 4:28 PM, Eden Cardim edencar...@gmail.com wrote: Is there a specific reason that Private actions may not have additional attributes? You can achieve the same effect by using the :Action tag

Re: [Catalyst] Why no extra attributes on Private actions?

2009-08-17 Thread Paul Makepeace
On Mon, Aug 17, 2009 at 4:14 PM, Eden Cardimedencar...@gmail.com wrote: On Mon, Aug 17, 2009 at 10:57 AM, Bill Moseleymose...@hank.org wrote: I'm just after a bit more flexibility.  Perhaps that limitation could be based on what dispatch types are available (i.e. don't allow Private with any

Re: [Catalyst] Why no extra attributes on Private actions?

2009-08-17 Thread Bill Moseley
On Mon, Aug 17, 2009 at 8:14 AM, Eden Cardim edencar...@gmail.com wrote: I don't understand your obsession over :Private. A method tagged with :Action, or any other attribute that doesn't make it use one of the available dispatch types is effectively *the same thing* as a Private action,

Re: [Catalyst] Why no extra attributes on Private actions?

2009-08-17 Thread Tomas Doran
On 15 Aug 2009, at 19:44, Bill Moseley wrote: Is there a specific reason that Private actions may not have additional attributes? No, there is not. At the time when that code was written, additional attributes (for example, those used by Catalyst::Controller::ActionRole) weren't

Re: [Catalyst] Why no extra attributes on Private actions?

2009-08-17 Thread Tomas Doran
On 17 Aug 2009, at 09:47, Moritz Onken wrote: __PACKAGE__-config( actions = { foo = { Path = 'bar' } } ); sub foo {} This has been introduced in 5.80006. The Catalyst-Manual just didn't catch up with the changes. No, it was not. What gave you that impression?

Re: [Catalyst] Why no extra attributes on Private actions?

2009-08-17 Thread Moritz Onken
Am 17.08.2009 um 23:19 schrieb Tomas Doran: On 17 Aug 2009, at 09:47, Moritz Onken wrote: __PACKAGE__-config( actions = { foo = { Path = 'bar' } } ); sub foo {} This has been introduced in 5.80006. The Catalyst-Manual just didn't catch up with the changes. No, it was not. What gave

Re: [Catalyst] Why no extra attributes on Private actions?

2009-08-17 Thread Tomas Doran
On 17 Aug 2009, at 22:50, Moritz Onken wrote: Until then it was necessary to add at least one attribute to the method. The calendar uses :Local as attribute. Aah, yes - my bad, you're totally correct, you needed to sprinkle :Action around as decoration.. :) ++ Whoever fixed that...

Re: [Catalyst] Why no extra attributes on Private actions?

2009-08-16 Thread Bill Moseley
On Sat, Aug 15, 2009 at 4:28 PM, Eden Cardim edencar...@gmail.com wrote: Is there a specific reason that Private actions may not have additional attributes? You can achieve the same effect by using the :Action tag instead, as mst suggested in reply to the same thread:

[Catalyst] Why no extra attributes on Private actions?

2009-08-15 Thread Bill Moseley
Why does Catalyst::Controller not allow additional attributes on Private actions? Marcus added this code in r5558 back in November of 2006. 5558 marcus if ( $attrs-{Private} ( keys %$attrs 1 ) ) { 5558 marcus $c-log-debug( 'Bad action definition ' Yes, I

Re: [Catalyst] Why no extra attributes on Private actions?

2009-08-15 Thread Eden Cardim
On Sat, Aug 15, 2009 at 3:44 PM, Bill Moseleymose...@hank.org wrote: Why does Catalyst::Controller not allow additional attributes on Private actions? Marcus added this code in r5558 back in November of 2006.   5558 marcus if ( $attrs-{Private} ( keys %$attrs 1 ) ) {   5558

[Catalyst] Why no extra attributes on Private actions?

2008-01-22 Thread Bill Moseley
In Catalyst::Controller register_actions() there's this code: my $attrs = $self-_parse_attrs( $c, $method, @{ $cache-[1] } ); if ( $attrs-{Private} ( keys %$attrs 1 ) ) { $c-log-debug( 'Bad action definition ' . join( ' ', @{ $cache-[1] } ) . qq/ for

Re: [Catalyst] Why no extra attributes on Private actions?

2008-01-22 Thread Jonathan Rockway
On Tue, 2008-01-22 at 09:29 -0800, Bill Moseley wrote: This came up because I'm using SSL to indicate actions that require SSL: sub secret : Local SSL {} But, it would also be handy to be able to protect all actions below a give controller via: sub auto : Private SSL { 1 }

Re: [Catalyst] Why no extra attributes on Private actions?

2008-01-22 Thread Christopher H. Laco
Bill Moseley wrote: In Catalyst::Controller register_actions() there's this code: my $attrs = $self-_parse_attrs( $c, $method, @{ $cache-[1] } ); if ( $attrs-{Private} ( keys %$attrs 1 ) ) { $c-log-debug( 'Bad action definition ' . join( ' ', @{ $cache-[1] } )