Re: [Catalyst] patch for C::P::Session::Store::Cookie

2009-06-09 Thread Tomas Doran
On 9 Jun 2009, at 21:29, J. Shirley wrote: On Tue, Jun 9, 2009 at 1:15 PM, Tomas Doran wrote: How would something like a 'cookie_name_stash_key' configuration parameter sit with you? If not provided, we do what we do now, if provided then that stash key will be used if present and def

Re: [Catalyst] patch for C::P::Session::Store::Cookie

2009-06-09 Thread J. Shirley
On Tue, Jun 9, 2009 at 1:15 PM, Tomas Doran wrote: > > On 9 Jun 2009, at 19:19, J. Shirley wrote: > >> Being able to specify the session cookie name based on the request would >> be useful for edge cases. >> > > I totally agree. > > How would something like a 'cookie_name_stash_key' configuration

Re: [Catalyst] patch for C::P::Session::Store::Cookie

2009-06-09 Thread Tomas Doran
On 9 Jun 2009, at 19:19, J. Shirley wrote: Being able to specify the session cookie name based on the request would be useful for edge cases. I totally agree. How would something like a 'cookie_name_stash_key' configuration parameter sit with you? If not provided, we do what we do now, i

Re: [Catalyst] patch for C::P::Session::Store::Cookie

2009-06-09 Thread J. Shirley
On Tue, Jun 9, 2009 at 10:41 AM, Tomas Doran wrote: > Fayland Lam wrote: > >> hey, it's a patch for Catalyst::Plugin::Session::Store::Cookie. to make >> cookie_domain more configurable. >> >>__PACKAGE__->config->{session}->{cookie_domain} = sub { >>my $c = shift; >>if ( $c->re

Re: [Catalyst] patch for C::P::Session::Store::Cookie

2009-06-09 Thread Tomas Doran
Fayland Lam wrote: hey, it's a patch for Catalyst::Plugin::Session::Store::Cookie. to make cookie_domain more configurable. __PACKAGE__->config->{session}->{cookie_domain} = sub { my $c = shift; if ( $c->req->uri->host =~ /xxx\.com/ ) { return '.xxx.com

[Catalyst] patch for C::P::Session::Store::Cookie

2009-06-08 Thread Fayland Lam
hey, it's a patch for Catalyst::Plugin::Session::Store::Cookie. to make cookie_domain more configurable. __PACKAGE__->config->{session}->{cookie_domain} = sub { my $c = shift; if ( $c->req->uri->host =~ /xxx\.com/ ) { return '.xxx.com'; } else {