Re: [ccache] [PATCH] Detect __DATE__ and __TIME__ correctly.

2012-10-09 Thread Andrew Stubbs
On 08/10/12 19:25, Justin Lebar wrote: I think this fails on at least one edge case: If the file contains only the string "__date__", then len == i == 8 and we never enter the loop, right? I think we in general fail to detect temporal macros at the very end of the file, with this patch. The sol

Re: [ccache] [PATCH] Detect __DATE__ and __TIME__ correctly.

2012-10-09 Thread Justin Lebar
Can you update the Python script in the comment right above the code and confirm that it matches your new table? It's hard for me to see what you did here based on just the patch... On Tue, Oct 9, 2012 at 10:43 AM, Andrew Stubbs wrote: > On 08/10/12 19:25, Justin Lebar wrote: >> >> I think this

Re: [ccache] [PATCH] Detect __DATE__ and __TIME__ correctly.

2012-10-09 Thread Justin Lebar
Okay, I think this is right. Thanks a lot for fixing my bug. :) It's not so surprising that the tests pass as-is, since we only test one offset of "__TIME__". But I tried modifying test.sh to move "__TIME__" to different offsets, and everything still worked. We should really get test coverage