Re: [ccache] [PATCH] Use bash for test.sh.

2012-11-06 Thread Eitan Adler
On 6 November 2012 04:54, Andrew Stubbs wrote: > > While it is true that "/usr/bin/env bash" is more portable than "/bin/bash", > I also don't like it as much. > > If I run a "#!/bin/bash" script without bash installed I get: > > /bin/bash: bad interpreter: No such file or directory > > If I try

Re: [ccache] [PATCH] Use bash for test.sh.

2012-11-06 Thread Andrew Stubbs
On 06/11/12 10:05, g@free.fr wrote: On my debian stable machine (x86 32 bits), I set sh as a symlink to dash and changed my script to emit SHELL='/bin/dash' test is ok with 3.1.8 (ccache is statically linked to glibc in my configuration). I looked with checkbashims on test.sh git version a

Re: [ccache] [PATCH] Use bash for test.sh.

2012-11-06 Thread g . esp
- Mail original - > De: "Andrew Stubbs" > À: "g esp" > Cc: ccache@lists.samba.org > Envoyé: Mardi 6 Novembre 2012 10:55:23 > Objet: Re: [ccache] [PATCH] Use bash for test.sh. > > On 05/11/12 22:35, g@free.fr wrote: > > ccache-3.1.8 'make check' work with dash, no? > > There's no p

Re: [ccache] [PATCH] Use bash for test.sh.

2012-11-06 Thread Andrew Stubbs
On 05/11/12 22:35, g@free.fr wrote: ccache-3.1.8 'make check' work with dash, no? There's no problem with configure or make, only with test.sh. Andrew ___ ccache mailing list ccache@lists.samba.org https://lists.samba.org/mailman/listinfo/ccache

Re: [ccache] [PATCH] Use bash for test.sh.

2012-11-06 Thread Andrew Stubbs
On 05/11/12 17:58, Eitan Adler wrote: -#!/bin/sh +#!/bin/bash This line is buggy: please http://blog.eitanadler.com/2012/10/binbash-considered-harmful.html for why. I ideally the non-portable bashims get fixed but if not the shebang line must be "/usr/bin/env bash" not /bin/bash. While it i