Re: [cdesktopenv-devel] NetBSD/DragonFlyBSD progress

2012-09-24 Thread Peter Howkins
On Sun, Sep 23, 2012 at 10:39:53PM +0200, Jelle Hermsen wrote: > Good evening (in GMT+1 that is), > > On Sep 23, 2012, at 11:53 AM, Marcin Cieslak wrote: > > > On Sun, 23 Sep 2012, Jelle Hermsen wrote: > > > >> CDE might also benefit from a better website. > > > > Go ahead :) > > I'd love to. I

[cdesktopenv-devel] [PATCH 4/5] dtmail: fix warning: NULL used in arithmetic

2012-09-24 Thread Marcin Cieslak
NULL != NULL makes no sense, really... --- cde/programs/dtmail/dtmail/AntiCheckBoxUiItem.C |2 +- cde/programs/dtmail/dtmail/CheckBoxUiItem.C |2 +- cde/programs/dtmail/dtmail/ComposeCmds.C|2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cde/programs/dt

[cdesktopenv-devel] [PATCH 1/5] Get rid of unpleasant cast, it causes SIGSEGV

2012-09-24 Thread Marcin Cieslak
Having a difficult choice between unplasant cast to get a void * into an enumeration type and "Something's wrong here" double cast I decided for the latter. At least it does not crash when the legal value of zero is passed as the argument. --- cde/programs/dtmail/dtmail/DmxPrintOptions.C |7 +

[cdesktopenv-devel] [PATCH 2/5] dtmail: Fix XtVaGetValues() return value storage

2012-09-24 Thread Marcin Cieslak
At least one crash was caused by this on the 64-bit system --- cde/programs/dtmail/MotifApp/MenuBar.C | 20 +--- cde/programs/dtmail/MotifApp/MenuWindow.C |7 +-- cde/programs/dtmail/MotifApp/SelectFileCmd.C |6 +++--- cde/programs/dtmail/dtmail/AttachA

[cdesktopenv-devel] [PATCH] Add -Wno-write-strings to C++ compiler flags

2012-09-24 Thread Marcin Cieslak
For now we need to give up on this warning: warning: deprecated conversion from string constant to 'char*' Until both C and C++ code and APIs defined here are fully const correct we will run into this warning in the C++ code. --- cde/config/cf/Imake.tmpl |4 ++-- 1 file changed, 2 insertions

[cdesktopenv-devel] [PATCH 3/5] dtmail: warning: 'DtMailBoolean' is promoted to (int)

2012-09-24 Thread Marcin Cieslak
Fix this warning: RFCTransport.C: In function 'long unsigned int writeToFileDesc(const char*, int, __va_list_tag*)': RFCTransport.C:91: warning: 'DtMailBoolean' is promoted to 'int' when passed thr ough '...' RFCTransport.C:91: warning: (so you should pass 'int' not 'DtMailBoolean' to 'va _arg')

[cdesktopenv-devel] [PATCH 5/5] dtmail: fix warning: comparison is always false

2012-09-24 Thread Marcin Cieslak
This warning was caused by a typo: warning: comparison is always false due to limited range of data type --- cde/programs/dtmail/dtmail/dtb_utils.C |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cde/programs/dtmail/dtmail/dtb_utils.C b/cde/programs/dtmail/dtmail/dtb_utils

Re: [cdesktopenv-devel] xinetd support

2012-09-24 Thread Marcin Cieslak
>> Ecmel Ercan wrote: > --00248c768d8625554104ca5f70f5 > Content-Type: text/plain; charset=UTF-8 > > Hi, > > While packaging CDE for Arch I added the attached xinetd services > which may be useful for other distros. Would that make sense to add "flags = IPv4" for IPv6-enabled systems (until of co

[cdesktopenv-devel] [PATCH] 157 warnings: remove -DXK_MISCELLANY from Makefiles

2012-09-24 Thread Marcin Cieslak
Fixes the following warning: In file included from ../../../imports/x11/include/X11/Xutil.h:54, from ../../../imports/x11/include/X11/Intrinsic.h:54, from Action.c:64: ../../../imports/x11/include/X11/keysym.h:49:1: warning: "XK_MISCELLANY" redefined : warning: t

[cdesktopenv-devel] C++: warning: invalid access to non-static data memeber of NULL object

2012-09-24 Thread Marcin Cieslak
Hello, When building dtmail with gcc 4.2 I get the following warning: making all in programs/dtmail/MotifApp... rm -f Application.o CC -c -O -Wno-write-strings -I../include/MotifApp -I../include -I../include/utils -I../../.. -I../. ./../exports/include -I../../../imports/motif/include -I../../

[cdesktopenv-devel] [PATCH] dtpdm: XtVaGetValues, XtPointer, XtArgVal, ...

2012-09-24 Thread Marcin Cieslak
Make XtVaGetValues return variables safe for 64-bit --- cde/programs/dtpdm/Main.c |5 +++- cde/programs/dtpdm/MainWindow.c |5 ++-- cde/programs/dtpdm/PrinterBox.c | 55 +++ 3 files changed, 39 insertions(+), 26 deletions(-) diff --git a/cde/pro

[cdesktopenv-devel] fix CDE compilation with __guard_local on OpenBSD

2012-09-24 Thread Pascal Stumpf
>From 061fd82a233136724c3c5e591f379e58fcc5de0b Mon Sep 17 00:00:00 2001 From: Pascal Stumpf Date: Mon, 24 Sep 2012 21:50:19 +0200 Subject: [PATCH] Add csu objects to shared libraries on OpenBSD. This is required by recent changes to the stack protector code in gcc, generating references to __guar

[cdesktopenv-devel] Test Suite

2012-09-24 Thread Peter Howkins
Hi All, As part of the CDE code drop from The Open Group we also received the automated suite for CDE. In theory this would allow us a measure of regression testing for the project. I've spent a few hours with this code trying to get it to build, but I've run into issues with Imake using the C

[cdesktopenv-devel] [PATCH] FreeBSD: Add /usr/dt/lib to runtime linker

2012-09-24 Thread Marcin Cieslak
Create $LOCALBASE/libdata/ldconfig/cde which points the runtime linker to /usr/dt/lib There is no need to invoke ldconfig manually after this. --- .../post_install/freebsd/configShlibs.src |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cde/admin/IntegTools/po

[cdesktopenv-devel] [PATCH] 2 warnings fixed (64-bit)

2012-09-24 Thread Marcin Cieslak
Fix XtVaGetValues() output for 64-bit Fix filename comparison in Dts.c --- cde/examples/tt/broadcast.c |2 +- cde/lib/DtSvc/DtUtil1/Dts.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cde/examples/tt/broadcast.c b/cde/examples/tt/broadcast.c index 039a83c..d9fc195 1

Re: [cdesktopenv-devel] [PATCH] Add -Wno-write-strings to C++ compiler flags

2012-09-24 Thread Jon Trulson
On Mon, 24 Sep 2012, Marcin Cieslak wrote: > For now we need to give up on this warning: > > warning: deprecated conversion from string constant to 'char*' > > Until both C and C++ code and APIs defined here > are fully const correct we will run into this > warning in the C++ code. A couple of t

Re: [cdesktopenv-devel] [PATCH 1/5] Get rid of unpleasant cast, it causes SIGSEGV

2012-09-24 Thread Jon Trulson
On Mon, 24 Sep 2012, Marcin Cieslak wrote: Applied. -- Jon Trulson The Higgs Field is what make atoms matter. -- Tom L. -- Live Security Virtual Conference Exclusive live event will cover all the ways

Re: [cdesktopenv-devel] [PATCH 4/5] dtmail: fix warning: NULL used in arithmetic

2012-09-24 Thread Jon Trulson
On Mon, 24 Sep 2012, Marcin Cieslak wrote: > NULL != NULL makes no sense, really... heh, a comedy of cut/paste errors... > --- > cde/programs/dtmail/dtmail/AntiCheckBoxUiItem.C |2 +- > cde/programs/dtmail/dtmail/CheckBoxUiItem.C |2 +- > cde/programs/dtmail/dtmail/ComposeCmds.C

Re: [cdesktopenv-devel] [PATCH 5/5] dtmail: fix warning: comparison is always false

2012-09-24 Thread Jon Trulson
On Mon, 24 Sep 2012, Marcin Cieslak wrote: > This warning was caused by a typo: > > warning: comparison is always false due to limited range of data type All 5 patches in this series applied. (Don't want to respond with 'applied' to every single one :) -- Jon Trulson The Higgs Field is what m

Re: [cdesktopenv-devel] xinetd support

2012-09-24 Thread Jon Trulson
On Mon, 24 Sep 2012, Marcin Cieslak wrote: >>> Ecmel Ercan wrote: >> --00248c768d8625554104ca5f70f5 >> Content-Type: text/plain; charset=UTF-8 >> >> Hi, >> >> While packaging CDE for Arch I added the attached xinetd services >> which may be useful for other distros. > > Would that make sense to a

Re: [cdesktopenv-devel] [PATCH] 157 warnings: remove -DXK_MISCELLANY from Makefiles

2012-09-24 Thread Jon Trulson
On Mon, 24 Sep 2012, Marcin Cieslak wrote: > Fixes the following warning: > Applied. -- Jon Trulson The Higgs Field is what make atoms matter. -- Tom L. -- Live Security Virtual Conference Exclusive l

Re: [cdesktopenv-devel] [PATCH] dtpdm: XtVaGetValues, XtPointer, XtArgVal, ...

2012-09-24 Thread Jon Trulson
On Mon, 24 Sep 2012, Marcin Cieslak wrote: Applied. -- Jon Trulson The Higgs Field is what make atoms matter. -- Tom L. -- Live Security Virtual Conference Exclusive live event will cover all the ways

Re: [cdesktopenv-devel] fix CDE compilation with __guard_local on OpenBSD

2012-09-24 Thread Jon Trulson
On Mon, 24 Sep 2012, Pascal Stumpf wrote: This one would not apply (corrupt?) -- Jon Trulson The Higgs Field is what make atoms matter. -- Tom L. -- Live Security Virtual Conference Exclusive live e

Re: [cdesktopenv-devel] [PATCH] FreeBSD: Add /usr/dt/lib to runtime linker

2012-09-24 Thread Jon Trulson
On Tue, 25 Sep 2012, Marcin Cieslak wrote: Applied. -- Jon Trulson The Higgs Field is what make atoms matter. -- Tom L. -- Live Security Virtual Conference Exclusive live event will cover all the way

Re: [cdesktopenv-devel] [PATCH] 2 warnings fixed (64-bit)

2012-09-24 Thread Jon Trulson
On Tue, 25 Sep 2012, Marcin Cieslak wrote: Applied. -- Jon Trulson The Higgs Field is what make atoms matter. -- Tom L. -- Live Security Virtual Conference Exclusive live event will cover all the ways

Re: [cdesktopenv-devel] xinetd support

2012-09-24 Thread Marcin Cieslak
On Mon, 24 Sep 2012, Jon Trulson wrote: > On Mon, 24 Sep 2012, Marcin Cieslak wrote: > > > > > Would that make sense to add "flags = IPv4" for IPv6-enabled > > systems (until of course our daemons support IPv6)? > > > > //Marcin > > > > Will it matter? I don't for for Linux and xinetd, but I

Re: [cdesktopenv-devel] C++: warning: invalid access to non-static data memeber of NULL object

2012-09-24 Thread Jon Trulson
On Mon, 24 Sep 2012, Marcin Cieslak wrote: > Hello, > > When building dtmail with gcc 4.2 I get the following warning: > Hmmm. Yes we could ignore the warning, but I'd suggest we don't if it has the potential to create grief in the future... -- Jon Trulson The Higgs Field is what make atoms ma

Re: [cdesktopenv-devel] xinetd support

2012-09-24 Thread Jon Trulson
On Tue, 25 Sep 2012, Marcin Cieslak wrote: > On Mon, 24 Sep 2012, Jon Trulson wrote: > >> On Mon, 24 Sep 2012, Marcin Cieslak wrote: >> >>> >>> Would that make sense to add "flags = IPv4" for IPv6-enabled >>> systems (until of course our daemons support IPv6)? >>> >>> //Marcin >>> >> >> Will it ma

Re: [cdesktopenv-devel] [PATCH] Add -Wno-write-strings to C++ compiler flags

2012-09-24 Thread Marcin Cieslak
On Mon, 24 Sep 2012, Jon Trulson wrote: > A couple of things - Peter was not fond of this commit since he thinks > it wise that we be reminded of these warnings so they will actually be > fixed someday. That said, who knows how long this will take, or > exactly what is involved (openmotif fixes t

Re: [cdesktopenv-devel] xinetd support

2012-09-24 Thread Marcin Cieslak
On Mon, 24 Sep 2012, Jon Trulson wrote: > If I read this right, the connection will only be rejected if a > request come in over IP6 - which should not be able to happen with > current CDE, right? Depending on your operating system + libc combination you may send an IPv4 connection to (x)inetd fr

Re: [cdesktopenv-devel] [PATCH] FreeBSD: Add /usr/dt/lib to runtime linker - update

2012-09-24 Thread Marcin Cieslak
On Mon, 24 Sep 2012, Jon Trulson wrote: > On Tue, 25 Sep 2012, Marcin Cieslak wrote: > > Applied. I'm sorry - it turns out this one does not fully work as expected. This one is better (it's relative to the old master) - so it might cause a conflict: diff --git a/cde/admin/IntegTools/post_insta

Re: [cdesktopenv-devel] [PATCH] FreeBSD: Add /usr/dt/lib to runtime linker - update

2012-09-24 Thread Jon Trulson
On Tue, 25 Sep 2012, Marcin Cieslak wrote: yep, conflict - just send an updated patch against your branch if you still have it, or from master. I'll push master once my linux/32b build completes (successfully :). -- Jon Trulson The Higgs Field is what make atoms matter. -- Tom

Re: [cdesktopenv-devel] [PATCH] FreeBSD: Add /usr/dt/lib to runtime linker - update

2012-09-24 Thread Jon Trulson
On Tue, 25 Sep 2012, Marcin Cieslak wrote: > On Mon, 24 Sep 2012, Jon Trulson wrote: > >> On Tue, 25 Sep 2012, Marcin Cieslak wrote: >> >> Applied. > > I'm sorry - it turns out this one does not fully > work as expected. > Never mind - since I didn't push yet, I just reverted previous patch and a

Re: [cdesktopenv-devel] xinetd support

2012-09-24 Thread Jon Trulson
On Tue, 25 Sep 2012, Marcin Cieslak wrote: > On Mon, 24 Sep 2012, Jon Trulson wrote: > >> If I read this right, the connection will only be rejected if a >> request come in over IP6 - which should not be able to happen with >> current CDE, right? > > Depending on your operating system + libc combi