[cdesktopenv-devel] [PATCH] Remove code blocks marked as 'NOTDONE'

2019-10-14 Thread Wesley Moxam
This is the first of a series of patches to remove dead code. There seems to be a decent amount of half finished code that's omitted via ifdef, it'll be good to remove it. -- W remove-NOTDONE.patch Description: Binary data ___ cdesktopenv-devel mailing

Re: [cdesktopenv-devel] [PATCH] Remove code blocks marked as 'NOTDONE'

2019-10-14 Thread Jon Trulson
On 10/14/19 8:16 AM, Wesley Moxam wrote: > This is the first of a series of patches to remove dead code. There > seems to be a decent amount of half finished code that's omitted via > ifdef, it'll be good to remove it. Agreed, and merged. Thanks! -- Jon Trulson "Nothing unreal exists."

Re: [cdesktopenv-devel] [PATCH] Remove code blocks marked as 'NOTDONE'

2019-10-14 Thread Wesley Moxam
Here are 3 more removal patches: 1) HP_EXTENSIONS is for HPUX systems. It doesn't seemed to be used anymore. 2) `legacysun` is presumably for older sun systems. I doubt anyone is using it 3) `oldcode` seems to be a name that was used to comment out old code. On Mon, Oct 14, 2019 at 10:16 AM Wesl

Re: [cdesktopenv-devel] [PATCH] Remove code blocks marked as 'NOTDONE'

2019-10-14 Thread Jon Trulson
On 10/14/19 3:36 PM, Wesley Moxam wrote: > Here are 3 more removal patches: > > 1) HP_EXTENSIONS is for HPUX systems. It doesn't seemed to be used anymore. > 2) `legacysun` is presumably for older sun systems. I doubt anyone is > using it > 3) `oldcode` seems to be a name that was used to comment

Re: [cdesktopenv-devel] [PATCH] Remove code blocks marked as 'NOTDONE'

2019-10-15 Thread Wesley Moxam
Ok, two more removal patches: 1) Remove HP_VUE compatibility ifdefs 2) Remove `notdef` ifdefs On Mon, Oct 14, 2019 at 5:36 PM Wesley Moxam wrote: > Here are 3 more removal patches: > > 1) HP_EXTENSIONS is for HPUX systems. It doesn't seemed to be used anymore. > 2) `legacysun` is presumably for

Re: [cdesktopenv-devel] [PATCH] Remove code blocks marked as 'NOTDONE'

2019-10-15 Thread Jon Trulson
On 10/15/19 8:18 PM, Wesley Moxam wrote: > Ok, two more removal patches: > > 1) Remove HP_VUE compatibility ifdefs > 2) Remove `notdef` ifdefs > Applied, thanks! -jon > On Mon, Oct 14, 2019 at 5:36 PM Wesley Moxam > wrote: > > Here are 3 more removal patche

Re: [cdesktopenv-devel] [PATCH] Remove code blocks marked as 'NOTDONE'

2019-10-17 Thread Wesley Moxam
Another clean up, this time I went through the various flags listed in programs/dtwm/README and removed the ones that are definitely not needed. Perhaps some others could be also removed in the future. -- W On Tue, Oct 15, 2019 at 10:18 PM Wesley Moxam wrote: > Ok, two more removal patches: >

Re: [cdesktopenv-devel] [PATCH] Remove code blocks marked as 'NOTDONE'

2019-10-17 Thread Jon Trulson
Hi, This one failed to build in WmInitWs.c - you accidentally removed two important #includes. I re-added them and applied them to your patch. Please compile test your submissions :) Merged, thanks! -jon On 10/17/19 7:18 PM, Wesley Moxam wrote: > Another clean up, this time I went through the

Re: [cdesktopenv-devel] [PATCH] Remove code blocks marked as 'NOTDONE'

2019-10-17 Thread Wesley Moxam
Oh sorry about that! I thought this was tested 😅 Thanks! On Thu, Oct 17, 2019 at 10:39 PM Jon Trulson wrote: > Hi, > > This one failed to build in WmInitWs.c - you accidentally removed two > important #includes. > > I re-added them and applied them to your patch. > > Please compile test your su