Re: [cdesktopenv-devel] [PATCH] updated ksh to most recent commit

2021-01-24 Thread Chase via cdesktopenv-devel
I think you could also use git clone --recurse-submodules to clone in the source and the submodule in the same pass. Thank you for your time, -Chase ‐‐‐ Original Message ‐‐‐ On Sunday, January 24, 2021 1:37 PM, Jon Trulson wrote: > On 1/23/21 8:36 PM, Chase wrote: > >> Jon, >> Hmm, If

Re: [cdesktopenv-devel] [PATCH] updated ksh to most recent commit

2021-01-24 Thread Jon Trulson
On 1/23/21 8:36 PM, Chase wrote: > Jon, > Hmm, If I am understanding you correctly (which I don't think I am), > git wouldn't properly clone the submodule into the ksh93 directory? > Maybe if thats the case, it could be fixed with adding in an empty > ksh93 directory for it to clone into to the rep

Re: [cdesktopenv-devel] [PATCH] updated ksh to most recent commit

2021-01-23 Thread Chase via cdesktopenv-devel
Jon, Hmm, If I am understanding you correctly (which I don't think I am), git wouldn't properly clone the submodule into the ksh93 directory? Maybe if thats the case, it could be fixed with adding in an empty ksh93 directory for it to clone into to the repo. It is worth noting however that git s

Re: [cdesktopenv-devel] [PATCH] updated ksh to most recent commit

2021-01-23 Thread Jon Trulson
On 1/22/21 4:41 PM, Chase via cdesktopenv-devel wrote: > Since Lev fixed the errors in upstream for musl and upstreamed them, > lets pull that in so any potential merge to master also can safely > build on musl (thus the old changes from Lev we would throw away for > old ksh would be replaced with

Re: [cdesktopenv-devel] [PATCH] updated ksh to most recent commit

2021-01-22 Thread Lev via cdesktopenv-devel
The new ksh93 maintainer seems amenable to getting it working on every Unix system, so that allays my earlier concerns. I still think it would be nice to get some feedback from someone running NetBSD on whether the new shell is worse or broken compared to the existing one. Perhaps we could maint

[cdesktopenv-devel] [PATCH] updated ksh to most recent commit

2021-01-22 Thread Chase via cdesktopenv-devel
Since Lev fixed the errors in upstream for musl and upstreamed them, lets pull that in so any potential merge to master also can safely build on musl (thus the old changes from Lev we would throw away for old ksh would be replaced with the new changes)l. I also threw in compiler warning fixes fo