Re: [cdesktopenv-devel] strcasestr detection patch

2018-06-27 Thread Jon Trulson
Applied to master, thanks! -jon On 06/26/2018 10:56 PM, Matthew R. Trower wrote: Alright, here's the patch. -mrt -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org!

Re: [cdesktopenv-devel] strcasestr detection patch

2018-06-26 Thread Matthew R. Trower
Alright, here's the patch. -mrt >From 9121aba9ec8786d52c54b3847d187ad960d0ce6d Mon Sep 17 00:00:00 2001 From: "Matthew R. Trower" Date: Tue, 26 Jun 2018 22:47:09 -0500 Subject: [PATCH] Fix DtMail compilation on Sun with GCC --- cde/programs/dtmail/dtmail/FindDialog.C | 2 +- 1 file changed, 1

Re: [cdesktopenv-devel] strcasestr detection patch

2018-06-26 Thread Matthew R. Trower
Jon Trulson writes: > On 06/26/2018 08:08 PM, Matthew R. Trower wrote: >> Jon Trulson writes: >> >>> Should I expect a patch from someone for this? >>> -jon >> >> I'll send one in. While I'm at it, tell me this - would you prefer to >> keep detection logic, using system strcasestr where we thin

Re: [cdesktopenv-devel] strcasestr detection patch

2018-06-26 Thread Jon Trulson
On 06/26/2018 08:08 PM, Matthew R. Trower wrote: Jon Trulson writes: Should I expect a patch from someone for this? -jon I'll send one in. While I'm at it, tell me this - would you prefer to keep detection logic, using system strcasestr where we think it is probably available, or just use o

Re: [cdesktopenv-devel] strcasestr detection patch

2018-06-26 Thread Matthew R. Trower
Jon Trulson writes: > Should I expect a patch from someone for this? > -jon I'll send one in. While I'm at it, tell me this - would you prefer to keep detection logic, using system strcasestr where we think it is probably available, or just use our custom strcasestr on all platforms? -mrt ---

Re: [cdesktopenv-devel] strcasestr detection patch

2018-06-26 Thread Jon Trulson
Should I expect a patch from someone for this? -jon On 06/26/2018 04:35 PM, Matthew R. Trower wrote: Ulrich Wilkens writes: On 06/19/18 22:56, Matthew R. Trower wrote: DtMail attempts to detect whether the non-standard strcasestr() is available, and defines it if it is not. Unfortunately, t

Re: [cdesktopenv-devel] strcasestr detection patch

2018-06-26 Thread Matthew R. Trower
Ulrich Wilkens writes: > On 06/19/18 22:56, Matthew R. Trower wrote: >> DtMail attempts to detect whether the non-standard strcasestr() is >> available, and defines it if it is not. Unfortunately, the detection >> code is imperfect. Fortunately, we can make it a class method to avoid >> collisi

Re: [cdesktopenv-devel] strcasestr detection patch

2018-06-26 Thread Ulrich Wilkens
On 06/19/18 22:56, Matthew R. Trower wrote: DtMail attempts to detect whether the non-standard strcasestr() is available, and defines it if it is not. Unfortunately, the detection code is imperfect. Fortunately, we can make it a class method to avoid collision even if it does exist. I've fou

Re: [cdesktopenv-devel] strcasestr detection patch

2018-06-20 Thread Matthew R. Trower
Jon Trulson writes: > I used the first patch. The second one failed for fbsd/clang (static > definition should only be in class definition, not function > definition). Gcc didn't complain. At anyrate, applied to master. Oh... Yeah, SunPro warned me about that being an anachronism. I didn't wa

Re: [cdesktopenv-devel] strcasestr detection patch

2018-06-20 Thread Jon Trulson
On 06/19/2018 02:56 PM, Matthew R. Trower wrote: DtMail attempts to detect whether the non-standard strcasestr() is available, and defines it if it is not. Unfortunately, the detection code is imperfect. Fortunately, we can make it a class method to avoid collision even if it does exist. I off

[cdesktopenv-devel] strcasestr detection patch

2018-06-19 Thread Matthew R. Trower
DtMail attempts to detect whether the non-standard strcasestr() is available, and defines it if it is not. Unfortunately, the detection code is imperfect. Fortunately, we can make it a class method to avoid collision even if it does exist. I offer a choice of two patches here. The first patch r