Re: [PATCH] ceph: fix memory leak in async readpages

On Wed, 28 Sep 2011, Sage Weil wrote: > I'll send this upstream with the other patches so it'll hopefully make > 3.1... Er, not really.. this'll go upstream during the next merge window, along with the readahead code. :) sage > > Thanks! > sage > > > On Wed, 28 Sep 2011, David Flynn wrote

Re: [PATCH] ceph: fix memory leak in async readpages

Can I add your Signed-off-by: on that? I'll send this upstream with the other patches so it'll hopefully make 3.1... Thanks! sage On Wed, 28 Sep 2011, David Flynn wrote: > The finish_read callback introduced in 63c90314546c1cec1f220f6ab24ea > fails to release the page list allocated in star

[PATCH] ceph: fix memory leak in async readpages

The finish_read callback introduced in 63c90314546c1cec1f220f6ab24ea fails to release the page list allocated in start_read. --- fs/ceph/addr.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index e06a322..4144caf 100644 --- a/fs/ceph/addr.

[PATCH] Fix memory leak in async readahead (ceph-client/master)

While running a test to improve read performance on 1GbE and 10GbE clients, a memory leak in the async readahead code was discovered. A trivial fix follows. In case it is of interest, using three separately hosted OSDs (10GbE), each configured to use six disks, i get the following read performanc

Re: heartbeat epoch

Hi Huang, On Wed, 28 Sep 2011, huang jun wrote: > hi,all > we encountered some problem > origin cluster OSD0??OSD23 > we add OSD24??OSD27 > > the OSD20 log: > 2011-09-28 10:32:50.602820 7f63498b6700 osd20 27 > update_heartbeat_peers: new _from osd24 192.168.0.118:6802/10487 > 2011-09-28 10:32:50

Re: [PATCH] Use LIBEDIT_LIBS in Makefile.am

Hi Hannes! Applied this, thanks. sage On Wed, 28 Sep 2011, Hannes Reinecke wrote: > > The editline library might require some additional libs, so > instead of hardcoding '-ledit' we should be using LIBEDIT_LIBS > in Makefile.am > > Signed-off-by: Hannes Reinecke > --- > src/Makefile.am |

[PATCH 4/5] libceph: fix pg_temp mapping calculation

We need to apply the modulo pg_num calculation before looking up a pgid in the pg_temp mapping rbtree. This fixes pg_temp mappings, and fixes (some) misdirected requests that result in messages like [WRN] client4104 10.0.1.219:0/275025290 misdirected client4104.1:129 0.1 to osd0 not [1,0] in e11

[PATCH 5/5] libceph: fix pg_temp mapping update

The incremental map updates have a record for each pg_temp mapping that is to be add/updated (len > 0) or removed (len == 0). The old code was written as if the updates were a complete enumeration; that was just wrong. Update the code to remove 0-length entries and drop the rbtree traversal. This

[PATCH 2/5] libceph: fix parse options memory leak

From: Noah Watkins ceph_destroy_options does not free opt->mon_addr that is allocated in ceph_parse_options. Signed-off-by: Noah Watkins Signed-off-by: Sage Weil --- net/ceph/ceph_common.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/ceph/ceph_common.c b/net/ce

[PATCH 3/5] libceph: fix linger request requeuing

The r_req_lru_item list node moves between several lists, and that cycle is not directly related (and does not begin) with __register_request(). Initialize it in the request constructor, not __register_request(). This fixes later badness (below) when OSDs restart underneath an rbd mount. Crashes w

[PATCH 1/5] libceph: initialize ack_stamp to avoid unnecessary connection reset

From: Jim Schutt Commit 4cf9d544631c recorded when an outgoing ceph message was ACKed, in order to avoid unnecessary connection resets when an OSD is busy. However, ack_stamp is uninitialized, so there is a window between when the message is sent and when it is ACKed in which handle_timeout() in

[PATCH 0/5] Ceph fixes for 3.1[-rc9]

Here is my fix queue for 3.1. The first two patches are pretty straightforward. The third was a list lifecycle issue that was crashing RBD reliably on any OSD state change. It's been pretty well tested now (the fix is a couple weeks old). The last two patches are new. The bug responsible fo

Re: ping_pong test of ceph

On Wed, Sep 28, 2011 at 12:33 AM, mowang da wrote: > hi all: > > l used ping_pong tool to test ceph, as shown below : > 1.If it supports coherent byte range locks between cluster nodes > 2.How fast it handles lock contention > 3.If it supports coherent read/write IO between nodes > 4.How fast it h

Re: ping_pong test of ceph

On Wed, 28 Sep 2011, mowang da wrote: > hi all: > > l used ping_pong tool to test ceph, as shown below : > 1.If it supports coherent byte range locks between cluster nodes > 2.How fast it handles lock contention > 3.If it supports coherent read/write IO between nodes > 4.How fast it handles conten

heartbeat epoch

hi,all we encountered some problem origin cluster OSD0……OSD23 we add OSD24……OSD27 the OSD20 log: 2011-09-28 10:32:50.602820 7f63498b6700 osd20 27 update_heartbeat_peers: new _from osd24 192.168.0.118:6802/10487 2011-09-28 10:32:50.602831 7f63498b6700 -- 192.168.0.116:6802/10666 --> 192.168.0.118:6

[PATCH] Use LIBEDIT_LIBS in Makefile.am

The editline library might require some additional libs, so instead of hardcoding '-ledit' we should be using LIBEDIT_LIBS in Makefile.am Signed-off-by: Hannes Reinecke --- src/Makefile.am |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Makefile.am b/src/Makefi

ping_pong test of ceph

hi all: l used ping_pong tool to test ceph, as shown below : 1.If it supports coherent byte range locks between cluster nodes 2.How fast it handles lock contention 3.If it supports coherent read/write IO between nodes 4.How fast it handles contended IO between nodes 5.If it supports coherent mmap