Re: ceph keyring

2013-02-25 Thread Wido den Hollander
On 02/20/2013 10:01 AM, Gandalf Corvotempesta wrote: I'm trying to configure RGW following this guide: http://ceph.com/docs/master/radosgw/config/ I have some questions about keyring. Should keyring files copied on each cluster node? For example, these commands: sudo ceph-authtool

Re: OpenStack summit : Ceph design session

2013-02-25 Thread Loic Dachary
On 02/25/2013 12:16 AM, Josh Durgin wrote: On 02/23/2013 02:33 AM, Loic Dachary wrote: Hi, In anticipation of the next OpenStack summit http://www.openstack.org/summit/portland-2013/, I proposed a session to discuss OpenStack and Ceph integration. Our meeting during FOSDEM earlier this

Re: OpenStack summit : Ceph design session

2013-02-25 Thread Loic Dachary
Hi Neil, I've added RBD backups secondary clusters within Openstack to the list of blueprints. Do you have links to mail threads / chat logs related to this topic ? I moved the content of the session to an etherpad for collaborative editing

Re: OSD memory leaks?

2013-02-25 Thread Sébastien Han
Ok thanks guys. Hope we will find something :-). -- Regards, Sébastien Han. On Mon, Feb 25, 2013 at 8:51 AM, Wido den Hollander w...@42on.com wrote: On 02/25/2013 01:21 AM, Sage Weil wrote: On Mon, 25 Feb 2013, S?bastien Han wrote: Hi Sage, Sorry it's a production system, so I can't test

Re: Four miscellaneous patches

2013-02-25 Thread Josh Durgin
On 02/22/2013 09:15 AM, Alex Elder wrote: The following patches address some issues that were found while investigating a kernel rbd client performance issue this week. These patches are available in the branch test/wip-4234,5,7,8 in the ceph-client git repository.

Re: Updated sparse warning message patches

2013-02-25 Thread Josh Durgin
On 02/22/2013 09:18 AM, Alex Elder wrote: I'm re-posting these patches because I've updated them to be based on the patches I just posted (Four miscellaneous patches). These patches are available in the branch test/wip-4184 in the ceph-client git repository. That branch is based on branch

Re: osdc/ObjectCacher.cc: 834: FAILED assert(ob-last_commit_tid tid)

2013-02-25 Thread Travis Rhoden
Any word on what the status of this is? I just ran into it myself, all on 0.56.3, latest KVM/qemu for Ubuntu 12.04. Looking at the bug in tracker, it's resolved. Is this going to be backported to bobtail? I'm booting VMs directly off of RBD, and this bug takes a few of them down at startup. I

[PATCH] libceph: fix a osd request memory leak

2013-02-25 Thread Alex Elder
If an invalid layout is provided to ceph_osdc_new_request(), its call to calc_layout() might return an error. At that point in the function we've already allocated an osd request structure, so we need to free it (drop a reference) in the event such an error occurs. The only other value

[PATCH] libceph: make ceph_msg-bio_seg be unsigned

2013-02-25 Thread Alex Elder
The bio_seg field is used by the ceph messenger in iterating through a bio. It should never have a negative value, so make it an unsigned. Change variables used to hold bio_seg values to all be unsigned as well. Change two variable names in init_bio_iter() to match the convention used

[PATCH 0/3] libceph: focus calc_layout() on filling in the osd op

2013-02-25 Thread Alex Elder
This series refactors the code involved with identifying the details of the name, offset, and length of an object involved with an osd request based on a file layout. It makes the focus of calc_layout() be filling in an osd op structure based on the file layout it is provided. The caller

[PATCH 1/3] libceph: pass object number back to calc_layout() caller

2013-02-25 Thread Alex Elder
Have calc_layout() pass the computed object number back to its caller. (This is a small step to simplify review.) Signed-off-by: Alex Elder el...@inktank.com --- net/ceph/osd_client.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/net/ceph/osd_client.c

[PATCH 2/3] libceph: format target object name in caller

2013-02-25 Thread Alex Elder
Move the formatting of the object name (oid) to use for an object request into the caller of calc_layout(). This makes the vino parameter no longer necessary, so get rid of it. Signed-off-by: Alex Elder el...@inktank.com --- net/ceph/osd_client.c | 12 +--- 1 file changed, 5

[PATCH 3/3] libceph: don't pass request to calc_layout()

2013-02-25 Thread Alex Elder
The only remaining reason to pass the osd request to calc_layout() is to fill in its r_num_pages and r_page_alignment fields. Once it fills those in, it doesn't do anything more with them. We can therefore move those assignments into the caller, and get rid of the req parameter entirely. Note,

[PATCH 0/4] libceph: abstract setting message data info

2013-02-25 Thread Alex Elder
This series makes the fields related to the data portion of a ceph message not get manipulated by code outside the ceph messenger. It implements some interface functions that can be used to assign data-related fields. Doing this will allow the way message data is managed to be changed

[PATCH 1/4] libceph: distinguish page array and pagelist count

2013-02-25 Thread Alex Elder
Use distinct fields for tracking the number of pages in a message's page array and in a message's page list. Currently only one or the other is used at a time, but that will be changing soon. Signed-off-by: Alex Elder el...@inktank.com --- fs/ceph/mds_client.c |4 ++--

[PATCH 2/4] libceph: set page alignment in start_request()

2013-02-25 Thread Alex Elder
The page alignment field for a request is currently set in ceph_osdc_build_request(). It's not needed at that point nor do either of its callers need that value assigned at any point before they call ceph_osdc_start_request(). So move that assignment into ceph_osdc_start_request().

[PATCH 3/4] libceph: isolate message page field manipulation

2013-02-25 Thread Alex Elder
Define a function ceph_msg_data_set_pages(), which more clearly abstracts the assignment page-related fields for data in a ceph message structure. These fields should never be set more than once (add BUG_ON() calls to guarantee that). Use this new function in the osd client and mds client.

[PATCH 4/4] libceph: isolate other message data fields

2013-02-25 Thread Alex Elder
Define ceph_msg_data_set_pagelist(), ceph_msg_data_set_bio(), and ceph_msg_data_set_trail() to clearly abstract the assignment the remaining data-related fields in a ceph message structure. These fields should never be used more than once; add BUG_ON() calls to guarantee this. Use the new

Re: [PATCH 3/3] ceph: fix vmtruncate deadlock

2013-02-25 Thread Gregory Farnum
On Fri, Feb 22, 2013 at 8:31 PM, Yan, Zheng zheng.z@intel.com wrote: On 02/23/2013 02:54 AM, Gregory Farnum wrote: I haven't spent that much time in the kernel client, but this patch isn't working out for me. In particular, I'm pretty sure we need to preserve this: diff --git

Re: [PATCH 3/3] ceph: fix vmtruncate deadlock

2013-02-25 Thread Yan, Zheng
On 02/26/2013 08:01 AM, Gregory Farnum wrote: On Fri, Feb 22, 2013 at 8:31 PM, Yan, Zheng zheng.z@intel.com wrote: On 02/23/2013 02:54 AM, Gregory Farnum wrote: I haven't spent that much time in the kernel client, but this patch isn't working out for me. In particular, I'm pretty sure we

Re: [PATCH 3/3] ceph: fix vmtruncate deadlock

2013-02-25 Thread Sage Weil
On Tue, 26 Feb 2013, Yan, Zheng wrote: It looks to me like truncates can get queued for later, so that's not the case? And how could the client receive a truncate while in the middle of writing? Either it's got the write caps (in which case nobody else can truncate), or it shouldn't be