Indeed. http://tracker.ceph.com/issues/4678. Thanks for the report.
On 4/5/2013 5:49 PM, Lorieri wrote:
Hi,
My colleague run ceph pg dump --format with no other arguments.
It crashes all mon daemons in the cluster.
happens in ceph 0.60 and 0.56
3 mon, 3 osd, default crush map
# ceph pg dump
Hi Sage,
cloud someone please update also the "Mailing lists & IRC" webpage at
ceph.com (http://ceph.com/resources/mailing-list-irc/)?
The issues are:
- ceph-commit: points still to ceph-com...@lists.ceph.newdream.net
Note: you may need to add a link to the old archives or you need to
merge t
Hey Danny,
Thanks for pointing this out. I updated the links this morning and
will work on merging or linking the old archives soon.
Best Regards,
Patrick McGarry
Director, Community || Inktank
http://ceph.com || http://inktank.com
@scuttlemonkey || @ceph || @inktank
On Mon, Apr 8, 2013 a
Reviewed-by: Josh Durgin
On 04/05/2013 07:03 AM, Alex Elder wrote:
An osd request keeps a pointer to the osd operations (ops) array
that it builds in its request message.
In order to allow each op in the array to have its own distinct
data, we will need to keep track of each op's data, and tha
Reviewed-by: Josh Durgin
On 04/05/2013 07:03 AM, Alex Elder wrote:
There are fields "indata" and "indata_len" defined the ceph osd
request op structure. The "in" part is with from the point of view
of the osd server, but is a little confusing here on the client
side. Change their names to use
Reviewed-by: Josh Durgin
On 04/05/2013 07:04 AM, Alex Elder wrote:
An osd request now holds all of its source op structures, and every
place that initializes one of these is in fact initializing one
of the entries in the the osd request's array.
So rather than supplying the address of the op t
Reviewed-by: Josh Durgin
On 04/05/2013 07:04 AM, Alex Elder wrote:
Currently an object request has its osd request's data field set in
rbd_osd_req_format_op(). That assumes a single osd op per object
request, and that won't be the case for long.
Move the code that sets this out and into the c
Reviewed-by: Josh Durgin
On 04/05/2013 07:04 AM, Alex Elder wrote:
The osd data for a request is currently initialized inside
rbd_osd_req_create(), but that assumes an object request's data
belongs in the osd request's data in or data out field.
There are only three places where requests with
Just a couple nits.
Reviewed-by: Josh Durgin
Alex Elder wrote:
This patch just trivially moves around some code for consistency.
In preparation for initializing osd request data fields in
ceph_osdc_build_request(), I wanted to verify that rbd did in fact
call that immediatley before it calle
Reviewed-by: Josh Durgin
On 04/05/2013 07:05 AM, Alex Elder wrote:
An object class method is formatted using a pagelist which contains
the class name, the method name, and the data concatenated into an
osd request's outbound data.
Currently when a class op is initialized in osd_req_op_cls_init
Reviewed-by: Josh Durgin
On 04/05/2013 07:05 AM, Alex Elder wrote:
This simply moves ceph_osdc_build_request() later in its source
file without any change. Done as a separate patch to facilitate
review of the change in the next patch.
Signed-off-by: Alex Elder
---
net/ceph/osd_client.c |
Reviewed-by: Josh Durgin
On 04/05/2013 07:05 AM, Alex Elder wrote:
All calls of ceph_osdc_start_request() are preceded (in the case of
rbd, almost) immediately by a call to ceph_osdc_build_request().
Move the build calls at the top of ceph_osdc_start_request() out of
there and into the ceph_os
Reviewed-by: Josh Durgin
On 04/05/2013 07:03 AM, Alex Elder wrote:
An extent type osd operation currently implies that there will
be corresponding data supplied in the data portion of the request
(for write) or response (for read) message. Similarly, an osd class
method operation implies a dat
Reviewed-by: Josh Durgin
On 04/05/2013 07:05 AM, Alex Elder wrote:
This ends up being a rather large patch but what it's doing is
somewhat straightforward.
Basically, this is replacing two calls with one. The first of the
two calls is initializing a struct ceph_osd_data with data (either a
pa
Reviewed-by: Josh Durgin
On 04/05/2013 07:06 AM, Alex Elder wrote:
Finally! Convert the osd op data pointers into real structures, and
make the switch over to using them instead of having all ops share
the in and/or out data structures in the osd request.
Set up a new function to traverse the
Reviewed-by: Josh Durgin
On 04/05/2013 03:17 PM, Alex Elder wrote:
This patch:
15a0d7b libceph: record message data length
did not enclose some bio-specific code inside CONFIG_BLOCK as
it should have. Fix that.
Signed-off-by: Alex Elder
---
include/linux/ceph/messenger.h |2 ++
n
Reviewed-by: Josh Durgin
On 04/05/2013 07:06 AM, Alex Elder wrote:
Still using the osd request r_data_in and r_data_out pointer, but
we're basically only referring to it via the data pointers in the
osd ops. And we're transferring that information to the request
or reply message only when the
Sorry, I've found another problem with this patch.
I've updated it below, and have updated the patches
that followed it. The result is available in the
"review/wip-3761-5" branch of the ceph-client git
repository.
Previously there were assertions that caught attempts
to add more than one data ite
Reviewed-by: Josh Durgin
On 04/05/2013 03:25 PM, Alex Elder wrote:
The bio is the only data item type that doesn't record its full
length. Fix that.
Signed-off-by: Alex Elder
---
include/linux/ceph/messenger.h |5 -
net/ceph/messenger.c |1 +
2 files changed, 5 inse
Reviewed-by: Josh Durgin
On 04/05/2013 03:25 PM, Alex Elder wrote:
A message will only be processing a single data item at a time, so
there's no need for each data item to have its own cursor.
Move the cursor embedded in the message data structure into the
message itself. To minimize the impa
Reviewed-by: Josh Durgin
On 04/05/2013 03:26 PM, Alex Elder wrote:
In place of the message data pointer, use a list head which links
through message data items. For now we only support a single entry
on that list.
Signed-off-by: Alex Elder
---
include/linux/ceph/messenger.h |3 ++-
ne
Reviewed-by: Josh Durgin
On 04/05/2013 03:25 PM, Alex Elder wrote:
Rather than having a ceph message data item point to the cursor it's
associated with, have the cursor point to a data item. This will
allow a message cursor to be used for more than one data item.
Signed-off-by: Alex Elder
--
Reviewed-by: Josh Durgin
On 04/05/2013 03:26 PM, Alex Elder wrote:
Change the names of the functions that put data on a pagelist to
reflect that we're adding to whatever's already there rather than
just setting it to the one thing. Currently only one data item is
ever added to a message, but t
Reviewed-by: Josh Durgin
On 04/08/2013 04:48 PM, Alex Elder wrote:
Sorry, I've found another problem with this patch.
I've updated it below, and have updated the patches
that followed it. The result is available in the
"review/wip-3761-5" branch of the ceph-client git
repository.
Previously t
Reviewed-by: Josh Durgin
On 04/05/2013 04:40 PM, Alex Elder wrote:
(This patch is available on the end of the last series I
posted in the "review/wip-3761-3" branch of the ceph-client
git repository. Note that the series was updated, reflect
version 2 of the patch "libceph: implement multiple
Assuming we'll come back and clean this up soon:
Reviewed-by: Josh Durgin
On 04/06/2013 01:42 PM, Alex Elder wrote:
I found a bug in this and am posting the following
update. If a connection's alloc_msg() method sets
the skip flag, it will return with con->in_msg being
a null pointer. The or
26 matches
Mail list logo
