[PATCH] Fix for corrupted ceph cluster

2014-02-10 Thread Daniel Poelzleithner
Hi, I wrote a small patch that ignores object_trim requests when he does not find the context of this request. We have a node that fails to start permanently and there is no way to get all nodes back up. As far as I understood, deleting something that does not exist should not cause an assert. It

[PATCH 2/5] ceph: remove zero-size xattr

2014-02-10 Thread Yan, Zheng
Signed-off-by: Yan, Zheng --- fs/ceph/xattr.c | 9 + 1 file changed, 9 insertions(+) diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c index 28f9793..6ed0e5a 100644 --- a/fs/ceph/xattr.c +++ b/fs/ceph/xattr.c @@ -12,6 +12,9 @@ #define XATTR_CEPH_PREFIX "ceph." #define XATTR_CEPH_PREFIX_LE

[PATCH 3/5] ceph: fix ceph_removexattr()

2014-02-10 Thread Yan, Zheng
Signed-off-by: Yan, Zheng --- fs/ceph/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c index 6ed0e5a..79f9c12 100644 --- a/fs/ceph/xattr.c +++ b/fs/ceph/xattr.c @@ -463,7 +463,7 @@ static int __remove_xattr(struct ceph_inode_info *ci,

[PATCH 1/5] ceph: properly handle XATTR_CREATE and XATTR_REPLACE

2014-02-10 Thread Yan, Zheng
return -EEXIST if XATTR_CREATE is set and xattr alread exists. return -ENODATA if XATTR_REPLACE is set but xattr does not exist. Signed-off-by: Yan, Zheng --- fs/ceph/xattr.c | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/fs/ceph/xatt

[PATCH 5/5] ceph: fix ceph_set_acl()

2014-02-10 Thread Yan, Zheng
If acl is equivalent to file mode permission bits, ceph_set_acl() needs to remove any existing acl xattr. Use __ceph_setxattr() to handle both setting and removing acl xattr cases, it doesn't return -ENODATA when there is no acl xattr. Signed-off-by: Yan, Zheng --- fs/ceph/acl.c | 6 +- 1 fi

[PATCH 4/5] ceph: add missing init_acl() for mkdir() and atomic_open()

2014-02-10 Thread Yan, Zheng
Signed-off-by: Yan, Zheng --- fs/ceph/dir.c | 9 + fs/ceph/file.c | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c index 6da4df8..3bbd0eb 100644 --- a/fs/ceph/dir.c +++ b/fs/ceph/dir.c @@ -695,9 +695,8 @@ static int ceph_mknod(struct ino

ceph branch status

2014-02-10 Thread ceph branch robot
-- All Branches -- Alfredo Deza 2013-09-27 10:33:52 -0400 wip-5900 2014-01-21 16:29:22 -0500 wip-6465 2014-02-07 11:55:01 -0500 wip-7334 Dan Mick 2013-07-16 23:00:06 -0700 wip-5634 David Zafman 2013-01-28 20:26:34 -0800 wip-wireshark-zafman

Re: [ceph-users] Kernel rbd & cephx signatures

2014-02-10 Thread Sage Weil
Correct. During the intiial handshake, the to ends will decide whether to use signatures based on whether it is supported by both ends. That option allows them to continue even if it is not. You probably want the more specific options: cephx_require_signatures = false cephx_cluster_require_

Re: [ceph-users] Kernel rbd & cephx signatures

2014-02-10 Thread Kurt Bauer
Hi Sage, thanks for your answer. Am I right, that the communication between nodes that support cephx signatures is still signed, although the option is set to false? So only the communication between the client, mapping the rbd, and the relevant OSDs and MONs is not signed? Thanks, best regards,

Re: [ceph-users] Kernel rbd & cephx signatures

2014-02-10 Thread Sage Weil
Hi Kurt, Your original analysis is correct: cephx signatures aren't yet implemented in the kernel client. I don't have a good indication of when this will be prioritized, unfortunately. I'm not aware of anybody who has targetted this or has even made note of the potential vulnerability. It r